mir/Android-Password-Store
2
0
Fork 0
mirror of https://github.com/android-password-store/Android-Password-Store synced 2025-08-31 14:25:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Append trailing newline to .gpg-id during creation (#1344)

Browse Source
This commit is contained in:
Harsh Shandilya
2021-03-13 03:05:03 +05:30
committed by GitHub
parent 6206850eb2
commit 197af98bb5
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
CHANGELOG.md
View File

@@ -13,17 +13,23 @@ All notable changes to this project will be documented in this file.
### Fixed ### Fixed
- Autofill now works much more reliably in Chrome 89 and later, including support for saving passwords if no accessibility service is enabled.
- Pressing the back button in the navigation bar and the one in the toolbar behaved differently - Pressing the back button in the navigation bar and the one in the toolbar behaved differently
- Editing a password allowed accidentally overwriting an existing one
- App shortcuts would never update once the first 4 were set - App shortcuts would never update once the first 4 were set
- Clipboard history now attempts to flush through 35 times rather than 20 to combat increased clipboard history item count in Samsung devices - Clipboard history now attempts to flush through 35 times rather than 20 to combat increased clipboard history item count in Samsung devices
- .gpg-id file generated by APS did not work with pass CLI
### Changed ### Changed
- Accessibility autofill has been removed completely due to being buggy, insecure and lacking in features. Upgrade to Android 8 or preferably later to gain access to our advanced Autofill implementation. - Accessibility autofill has been removed completely due to being buggy, insecure and lacking in features. Upgrade to Android 8 or preferably later to gain access to our advanced Autofill implementation.
- The settings UI has been completely re-done to dramatically improve discoverability and navigation for users - The settings UI has been completely re-done to dramatically improve discoverability and navigation for users
## [1.13.3] - 2021-03-06
### Fixed
- Autofill now works much more reliably in Chrome 89 and later, including support for saving passwords if no accessibility service is enabled.
- Editing a password allowed accidentally overwriting an existing one
## [1.13.2] - 2020-12-21 ## [1.13.2] - 2020-12-21
### Added ### Added
@@ -427,7 +433,9 @@ All notable changes to this project will be documented in this file.
- Fix elements overlapping. - Fix elements overlapping.
[Unreleased]: https://github.com/android-password-store/Android-Password-Store/compare/v1.13.2...HEAD [Unreleased]: https://github.com/android-password-store/Android-Password-Store/compare/v1.13.3...HEAD
[1.13.3]: https://github.com/android-password-store/Android-Password-Store/compare/v1.13.2...v1.13.3
[1.13.2]: https://github.com/android-password-store/Android-Password-Store/compare/v1.13.1...v1.13.2 [1.13.2]: https://github.com/android-password-store/Android-Password-Store/compare/v1.13.1...v1.13.2

2
app/src/main/java/dev/msfjarvis/aps/ui/crypto/PasswordCreationActivity.kt
View File

@@ -105,7 +105,7 @@ class PasswordCreationActivity : BasePgpActivity(), OpenPgpServiceConnection.OnB
lifecycleScope.launch { lifecycleScope.launch {
val gpgIdentifierFile = File(PasswordRepository.getRepositoryDirectory(), ".gpg-id") val gpgIdentifierFile = File(PasswordRepository.getRepositoryDirectory(), ".gpg-id")
withContext(Dispatchers.IO) { withContext(Dispatchers.IO) {
gpgIdentifierFile.writeText(keyIds.joinToString("\n")) gpgIdentifierFile.writeText((keyIds + "").joinToString("\n"))
} }
commitChange(getString( commitChange(getString(
R.string.git_commit_gpg_id, R.string.git_commit_gpg_id,

2
app/src/main/java/dev/msfjarvis/aps/ui/onboarding/fragments/KeySelectionFragment.kt
View File

@@ -39,7 +39,7 @@ class KeySelectionFragment : Fragment(R.layout.fragment_key_selection) {
lifecycleScope.launch { lifecycleScope.launch {
withContext(Dispatchers.IO) { withContext(Dispatchers.IO) {
val gpgIdentifierFile = File(PasswordRepository.getRepositoryDirectory(), ".gpg-id") val gpgIdentifierFile = File(PasswordRepository.getRepositoryDirectory(), ".gpg-id")
gpgIdentifierFile.writeText(keyIds.joinToString("\n")) gpgIdentifierFile.writeText((keyIds + "").joinToString("\n"))
} }
settings.edit { putBoolean(PreferenceKeys.REPOSITORY_INITIALIZED, true) } settings.edit { putBoolean(PreferenceKeys.REPOSITORY_INITIALIZED, true) }
requireActivity().commitChange(getString( requireActivity().commitChange(getString(