mir/Android-Password-Store
2
0
Fork 0
mirror of https://github.com/android-password-store/Android-Password-Store synced 2025-09-02 15:25:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use getAdapterPosition instead of position variable set in onBindViewHolder

Browse Source
This commit is contained in:
Matthew Wong
2015-08-09 13:53:31 -04:00
parent b37b9fed5d
commit 2adbeeeba7
1 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
app/src/main/java/com/zeapo/pwdstore/utils/PasswordRecyclerAdapter.java
View File

@@ -1,9 +1,7 @@
package com.zeapo.pwdstore.utils; package com.zeapo.pwdstore.utils;
import android.graphics.Color;
import android.support.v7.view.ActionMode; import android.support.v7.view.ActionMode;
import android.support.v7.widget.RecyclerView; import android.support.v7.widget.RecyclerView;
import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.Menu; import android.view.Menu;
import android.view.MenuItem; import android.view.MenuItem;
@@ -34,7 +32,6 @@ public class PasswordRecyclerAdapter extends RecyclerView.Adapter<PasswordRecycl
public View view; public View view;
public TextView name; public TextView name;
public TextView type; public TextView type;
public int position;
public ViewHolder(View v) { public ViewHolder(View v) {
super(v); super(v);
@@ -89,13 +86,11 @@ public class PasswordRecyclerAdapter extends RecyclerView.Adapter<PasswordRecycl
holder.type.setTextColor(activity.getResources().getColor(R.color.blue_grey_50)); holder.type.setTextColor(activity.getResources().getColor(R.color.blue_grey_50));
} }
holder.position = position;
holder.view.setOnClickListener(new View.OnClickListener() { holder.view.setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
if (mActionMode != null) { if (mActionMode != null) {
toggleSelection(holder.position); toggleSelection(holder.getAdapterPosition(), holder.view);
if (selectedItems.isEmpty()) { if (selectedItems.isEmpty()) {
mActionMode.finish(); mActionMode.finish();
} }
@@ -111,14 +106,13 @@ public class PasswordRecyclerAdapter extends RecyclerView.Adapter<PasswordRecycl
if (mActionMode != null) { if (mActionMode != null) {
return false; return false;
} }
toggleSelection(holder.position); toggleSelection(holder.getAdapterPosition(), holder.view);
// Start the CAB using the ActionMode.Callback // Start the CAB using the ActionMode.Callback
mActionMode = activity.startSupportActionMode(mActionModeCallback); mActionMode = activity.startSupportActionMode(mActionModeCallback);
return true; return true;
} }
}); });
holder.view.setSelected(selectedItems.contains(position));
} }
@@ -159,7 +153,6 @@ public class PasswordRecyclerAdapter extends RecyclerView.Adapter<PasswordRecycl
public void onDestroyActionMode(ActionMode mode) { public void onDestroyActionMode(ActionMode mode) {
selectedItems.clear(); selectedItems.clear();
mActionMode = null; mActionMode = null;
notifyDataSetChanged();
} }
}; };
@@ -191,19 +184,21 @@ public class PasswordRecyclerAdapter extends RecyclerView.Adapter<PasswordRecycl
public void remove(int position) { public void remove(int position) {
this.values.remove(position); this.values.remove(position);
this.notifyItemRemoved(position); this.notifyItemRemoved(position);
}
public void toggleSelection(int position) {
if (!selectedItems.remove(position)) {
selectedItems.add(position);
}
for (int selected : selectedItems) { for (int selected : selectedItems) {
if (selected > position) { if (selected > position) {
selectedItems.remove(selected); selectedItems.remove(selected);
selectedItems.add(selected - 1); selectedItems.add(selected - 1);
} }
} }
notifyItemChanged(position); }
public void toggleSelection(int position, View view) {
if (!selectedItems.remove(position)) {
selectedItems.add(position);
view.setSelected(true);
} else {
view.setSelected(false);
}
} }
} }