From 66dcfd7b73f5adb447555f0f15e743a2ecc466e2 Mon Sep 17 00:00:00 2001 From: zeapo Date: Fri, 11 Aug 2017 10:25:37 +0200 Subject: [PATCH] suprress inflateParams lint error in dialogs --- app/src/main/java/com/zeapo/pwdstore/SshKeyGen.java | 3 ++- .../com/zeapo/pwdstore/autofill/AutofillFragment.java | 8 +++++--- .../main/java/com/zeapo/pwdstore/pwgenDialogFragment.java | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/zeapo/pwdstore/SshKeyGen.java b/app/src/main/java/com/zeapo/pwdstore/SshKeyGen.java index b4daa5dbe..3b73541b8 100644 --- a/app/src/main/java/com/zeapo/pwdstore/SshKeyGen.java +++ b/app/src/main/java/com/zeapo/pwdstore/SshKeyGen.java @@ -1,5 +1,6 @@ package com.zeapo.pwdstore; +import android.annotation.SuppressLint; import android.app.Dialog; import android.app.DialogFragment; import android.app.Fragment; @@ -86,7 +87,7 @@ public class SshKeyGen extends AppCompatActivity { public Dialog onCreateDialog(Bundle savedInstanceState) { AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()); LayoutInflater inflater = getActivity().getLayoutInflater(); - final View v = inflater.inflate(R.layout.fragment_show_ssh_key, null); + @SuppressLint("InflateParams") final View v = inflater.inflate(R.layout.fragment_show_ssh_key, null); builder.setView(v); TextView textView = (TextView) v.findViewById(R.id.public_key); diff --git a/app/src/main/java/com/zeapo/pwdstore/autofill/AutofillFragment.java b/app/src/main/java/com/zeapo/pwdstore/autofill/AutofillFragment.java index 4edfc3e3f..b0eb8fddc 100644 --- a/app/src/main/java/com/zeapo/pwdstore/autofill/AutofillFragment.java +++ b/app/src/main/java/com/zeapo/pwdstore/autofill/AutofillFragment.java @@ -1,5 +1,6 @@ package com.zeapo.pwdstore.autofill; +import android.annotation.SuppressLint; import android.app.Activity; import android.app.Dialog; import android.app.DialogFragment; @@ -43,7 +44,7 @@ public class AutofillFragment extends DialogFragment { final AutofillPreferenceActivity callingActivity = (AutofillPreferenceActivity) getActivity(); LayoutInflater inflater = callingActivity.getLayoutInflater(); - final View view = inflater.inflate(R.layout.fragment_autofill, null); + @SuppressLint("InflateParams") final View view = inflater.inflate(R.layout.fragment_autofill, null); builder.setView(view); @@ -174,10 +175,11 @@ public class AutofillFragment extends DialogFragment { String packageName = getArguments().getString("packageName", ""); if (isWeb) { - packageName = ((EditText) dialog.findViewById(R.id.webURL)).getText().toString(); - // handle some errors and don't dismiss the dialog EditText webURL = (EditText) dialog.findViewById(R.id.webURL); + + packageName = webURL.getText().toString(); + if (packageName.equals("")) { webURL.setError("URL cannot be blank"); return; diff --git a/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java b/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java index 2a04be0e9..30b868f03 100644 --- a/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java +++ b/app/src/main/java/com/zeapo/pwdstore/pwgenDialogFragment.java @@ -37,7 +37,7 @@ public class pwgenDialogFragment extends DialogFragment { AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()); final Activity callingActivity = getActivity(); LayoutInflater inflater = callingActivity.getLayoutInflater(); - final View view = inflater.inflate(R.layout.fragment_pwgen, null); + @SuppressLint("InflateParams") final View view = inflater.inflate(R.layout.fragment_pwgen, null); Typeface monoTypeface = Typeface.createFromAsset(callingActivity.getAssets(), "fonts/sourcecodepro.ttf"); builder.setView(view);