mir/Android-Password-Store
2
0
Fork 0
mirror of https://github.com/android-password-store/Android-Password-Store synced 2025-08-30 22:05:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GitSettings: use runCatching to replace exception handling

Browse Source 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
This commit is contained in:
Harsh Shandilya
2020-09-05 20:31:28 +05:30
parent 83654896b6
commit 82c83a5bed
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt
View File

@@ -5,6 +5,8 @@
package com.zeapo.pwdstore.git.config package com.zeapo.pwdstore.git.config
import androidx.core.content.edit import androidx.core.content.edit
import com.github.michaelbull.result.getOrElse
import com.github.michaelbull.result.runCatching
import com.zeapo.pwdstore.Application import com.zeapo.pwdstore.Application
import com.zeapo.pwdstore.utils.PasswordRepository import com.zeapo.pwdstore.utils.PasswordRepository
import com.zeapo.pwdstore.utils.PreferenceKeys import com.zeapo.pwdstore.utils.PreferenceKeys
@@ -105,9 +107,9 @@ object GitSettings {
} }
fun updateConnectionSettingsIfValid(newAuthMode: AuthMode, newUrl: String, newBranch: String): UpdateConnectionSettingsResult { fun updateConnectionSettingsIfValid(newAuthMode: AuthMode, newUrl: String, newBranch: String): UpdateConnectionSettingsResult {
val parsedUrl = try { val parsedUrl = runCatching {
URIish(newUrl) URIish(newUrl)
} catch (_: Exception) { }.getOrElse {
return UpdateConnectionSettingsResult.FailedToParseUrl return UpdateConnectionSettingsResult.FailedToParseUrl
} }
val newProtocol = when (parsedUrl.scheme) { val newProtocol = when (parsedUrl.scheme) {