mir/Android-Password-Store
2
0
Fork 0
mirror of https://github.com/android-password-store/Android-Password-Store synced 2025-08-30 05:48:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Mark unfocused single password fields as fillable (#1258)

Browse Source 
Unfocused single password fields in forms with no other recognized
fields must be marked as fillable or the Autofill service will no
longer be invoked on that form.

This is compatible with the restrictions of single-origin mode as
filling only takes place after the password field has gained focus and
the user has tapped the fill UI.

For an example website where fill UI is not shown without this commit,
open https://amazon.lbb.de and tab the user name field ("Benutzername")
first before focusing the password field.
This commit is contained in:
Fabian Meumertzheim 2020-12-23 06:13:10 +01:00 committed by GitHub
parent a67c2a2f4a
commit c15594b045
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/AutofillStrategy.kt
View File

@ -187,6 +187,26 @@ internal val autofillStrategy = strategy {
}
}
// Fallback rule for the case of a login form with a password field and other fields that are
// not recognized by any other rule. If one of the other fields is focused and we return no
// response, the system will not invoke the service again if focus later changes to the password
// field. Hence, we must mark it as fillable now.
// This rule can apply in single origin mode since even though the password field may not be
// focused at the time the rule runs, the fill suggestion will only show if it ever receives
// focus.
rule(applyInSingleOriginMode = true) {
currentPassword {
takeSingle { hasAutocompleteHintCurrentPassword }
}
}
// See above.
rule(applyInSingleOriginMode = true) {
genericPassword {
takeSingle { true }
}
}
// Match any focused password field with optional username field on manual request.
rule(applyInSingleOriginMode = true, applyOnManualRequestOnly = true) {
genericPassword {