mir/NewPipeExtractor
2
0
Fork 0
mirror of https://github.com/TeamNewPipe/NewPipeExtractor synced 2025-08-30 22:05:18 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1086 from AudricV/yt_no-exception-channels-without-banner

Browse Source 
[YouTube] Don't throw an exception when there is no banner available on a channel
This commit is contained in:
Tobi
2023-08-02 18:56:26 +02:00
committed by GitHub
parent 39a911db9f bb1ab166bf
commit 9a59afbcf5
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeChannelExtractor.java
View File

@@ -282,7 +282,10 @@ public class YoutubeChannelExtractor extends ChannelExtractor {
))
.filter(url -> !url.contains("s.ytimg.com") && !url.contains("default_banner"))
.map(YoutubeParsingHelper::fixThumbnailUrl)
.orElseThrow(() -> new ParsingException("Could not get banner"));
// Channels may not have a banner, so no exception should be thrown if no banner is
// found
// Return null in this case
.orElse(null);
}
@Override

4
extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java
View File

@@ -2,6 +2,7 @@ package org.schabi.newpipe.extractor.services.youtube;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
@@ -720,7 +721,8 @@ public class YoutubeChannelExtractorTest {
@Test
public void testBannerUrl() throws Exception {
// CarouselHeaderRender does not contain a banner
// CarouselHeaderRenders do not contain a banner
assertNull(extractor.getBannerUrl());
}
@Test