[Analyzers][CPP]Turn on C26451 and fix code (#21230)

* Turn on rule as error and fixing code

* Add packages to external include paths

* Disable warrnings on external code.

Cpp.Build.props

@@ -34,7 +34,7 @@
   <PropertyGroup>
     <PreferredToolArchitecture>x64</PreferredToolArchitecture>
     <VcpkgEnabled>false</VcpkgEnabled>
-    <ExternalIncludePath>$(MSBuildThisFileFullPath)\..\deps\;$(ExternalIncludePath)</ExternalIncludePath>
+    <ExternalIncludePath>$(MSBuildThisFileFullPath)\..\deps\;$(MSBuildThisFileFullPath)\..\packages\;$(ExternalIncludePath)</ExternalIncludePath>
 	<RunCodeAnalysis>true</RunCodeAnalysis>
 	<CodeAnalysisRuleSet>$(MsbuildThisFileDirectory)\CppRuleSet.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>

CppRuleSet.ruleset

@@ -16,7 +16,7 @@
     <Rule Id="C26444" Action="Info" />
     <Rule Id="C26449" Action="Info" />
     <Rule Id="C26450" Action="Info" />
-    <Rule Id="C26451" Action="Info" />
+    <Rule Id="C26451" Action="Error" />
     <Rule Id="C26452" Action="Info" />
     <Rule Id="C26453" Action="Info" />
     <Rule Id="C26454" Action="Info" />

src/common/logger/call_tracer.cpp

@@ -24,7 +24,7 @@ namespace
         }
         else
         {
-            return std::string(2 * min(level, 64) - 1, ' ') + " - ";
+            return std::string(static_cast<int64_t>(2) * min(level, 64) - 1, ' ') + " - ";
         }
     }
 

src/modules/fancyzones/FancyZonesLib/LayoutConfigurator.cpp

@@ -139,9 +139,9 @@ ZonesMap CalculateGridZones(FancyZonesUtils::Rect workArea, FancyZonesDataTypes:
         columnInfo[col].Extent = columnInfo[col].End - columnInfo[col].Start;
     }
 
-    for (int row = 0; row < gridLayoutInfo.rows(); row++)
+    for (int64_t row = 0; row < gridLayoutInfo.rows(); row++)
     {
-        for (int col = 0; col < gridLayoutInfo.columns(); col++)
+        for (int64_t col = 0; col < gridLayoutInfo.columns(); col++)
         {
             int i = gridLayoutInfo.cellChildMap()[row][col];
             if (((row == 0) || (gridLayoutInfo.cellChildMap()[row - 1][col] != i)) &&
@@ -150,12 +150,12 @@ ZonesMap CalculateGridZones(FancyZonesUtils::Rect workArea, FancyZonesDataTypes:
                 long left = columnInfo[col].Start;
                 long top = rowInfo[row].Start;
 
-                int maxRow = row;
+                int64_t maxRow = row;
                 while (((maxRow + 1) < gridLayoutInfo.rows()) && (gridLayoutInfo.cellChildMap()[maxRow + 1][col] == i))
                 {
                     maxRow++;
                 }
-                int maxCol = col;
+                int64_t maxCol = col;
                 while (((maxCol + 1) < gridLayoutInfo.columns()) && (gridLayoutInfo.cellChildMap()[row][maxCol + 1] == i))
                 {
                     maxCol++;
@@ -165,9 +165,9 @@ ZonesMap CalculateGridZones(FancyZonesUtils::Rect workArea, FancyZonesDataTypes:
                 long bottom = rowInfo[maxRow].End;
 
                 top += row == 0 ? spacing : spacing / 2;
-                bottom -= maxRow == gridLayoutInfo.rows() - 1 ? spacing : spacing / 2;
+                bottom -= maxRow == static_cast<int64_t>(gridLayoutInfo.rows()) - 1 ? spacing : spacing / 2;
                 left += col == 0 ? spacing : spacing / 2;
-                right -= maxCol == gridLayoutInfo.columns() - 1 ? spacing : spacing / 2;
+                right -= maxCol == static_cast<int64_t>(gridLayoutInfo.columns()) - 1 ? spacing : spacing / 2;
 
                 auto zone = MakeZone(RECT{ left, top, right, bottom }, i);
                 if (zone)

src/modules/fancyzones/FancyZonesLib/ZoneSet.cpp

@@ -709,11 +709,11 @@ ZoneIndexSet ZoneSet::ZoneSelectSubregion(const ZoneIndexSet& capturedZones, POI
 
     if (verticalSplit)
     {
-        zoneIndex = (pt.y - overlap.top) * capturedZones.size() / height;
+        zoneIndex = (static_cast<int64_t>(pt.y) - overlap.top) * capturedZones.size() / height;
     }
     else
     {
-        zoneIndex = (pt.x - overlap.left) * capturedZones.size() / width;
+        zoneIndex = (static_cast<int64_t>(pt.x) - overlap.left) * capturedZones.size() / width;
     }
 
     zoneIndex = std::clamp(zoneIndex, ZoneIndex(0), static_cast<ZoneIndex>(capturedZones.size()) - 1);

src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.cpp

@@ -587,7 +587,7 @@ namespace KeyboardEventHandlers
                                 {
                                     DWORD to = std::get<0>(newRemapping.targetShortcut);
                                     bool isLastKeyStillPressed = ii.GetVirtualKeyState((WORD)from.actionKey);
-                                    key_count = from.Size() - 1 + 1 + (isLastKeyStillPressed ? 1 : 0);
+                                    key_count = static_cast<size_t>(from.Size()) - 1 + 1 + (isLastKeyStillPressed ? 1 : 0);
                                     keyEventList = new INPUT[key_count]();
                                     memset(keyEventList, 0, sizeof(keyEventList));
                                     int i = 0;
@@ -604,7 +604,10 @@ namespace KeyboardEventHandlers
                                     Shortcut to = std::get<Shortcut>(newRemapping.targetShortcut);
                                     bool isLastKeyStillPressed = ii.GetVirtualKeyState((WORD)from.actionKey);
 
-                                    key_count = from.Size() - 1 + to.Size() - 1 - 2* from.GetCommonModifiersCount(to) + 1 + (isLastKeyStillPressed ? 1 : 0);
+                                    size_t temp_key_count_calculation = static_cast<size_t>(from.Size()) - 1;
+                                    temp_key_count_calculation += static_cast<size_t>(to.Size()) - 1;
+                                    temp_key_count_calculation -= static_cast<size_t>(2) * from.GetCommonModifiersCount(to);
+                                    key_count = temp_key_count_calculation + 1 + (isLastKeyStillPressed ? 1 : 0);
                                     keyEventList = new INPUT[key_count]();
 
                                     int i = 0;

src/modules/powerrename/lib/PowerRenameLib.vcxproj

@@ -25,7 +25,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup>
     <ClCompile>
-      <WarningLevel>Level4</WarningLevel>
+      <WarningLevel>Level3</WarningLevel>
       <PreprocessorDefinitions>WIN32;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <AdditionalIncludeDirectories>$(ProjectDir)..\;$(ProjectDir)..\ui;$(ProjectDir)..\dll;$(ProjectDir)..\lib;$(ProjectDir)..\..\..\;$(ProjectDir)..\..\..\common\Telemetry;%(AdditionalIncludeDirectories);$(GeneratedFilesDir)</AdditionalIncludeDirectories>
     </ClCompile>

src/modules/videoconference/VideoConferenceShared/SerializedSharedMemory.cpp

@@ -83,7 +83,7 @@ std::optional<SerializedSharedMemory> SerializedSharedMemory::create(const std::
     }
 
     // We need an extra byte for locking if it's not readonly
-    const ULARGE_INTEGER UISize{ .QuadPart = size + !read_only };
+    const ULARGE_INTEGER UISize{ .QuadPart = static_cast<uint64_t>(size) + !read_only };
 
     wil::unique_handle hMapFile{ CreateFileMappingW(INVALID_HANDLE_VALUE,
                                                     maybe_attributes ? maybe_attributes : &sa,

src/runner/powertoy_module.cpp

@@ -34,7 +34,7 @@ json::JsonObject PowertoyModule::json_config() const
     int size = 0;
     pt_module->get_config(nullptr, &size);
     std::wstring result;
-    result.resize(size - 1);
+    result.resize(static_cast<size_t>(size) - 1);
     pt_module->get_config(result.data(), &size);
     return json::JsonObject::Parse(result);
 }

tools/BugReportTool/BugReportTool/BugReportTool.vcxproj

@@ -44,7 +44,8 @@
   </ItemDefinitionGroup>
   <ItemGroup>
     <ClCompile Include="..\..\..\deps\cziplib\src\zip.c">
-      <WarningLevel>TurnOffAllWarnings</WarningLevel>
+      <!-- Disabling warnings for external code -->
+	  <DisableSpecificWarnings>26451;4267;4244;%(DisableSpecificWarnings)</DisableSpecificWarnings>
     </ClCompile>
     <ClCompile Include="EventViewer.cpp" />
     <ClCompile Include="InstallationFolder.cpp" />