Migrate FancyZones data persisting from Registry to JSON file (#1194)

* Migrate FancyZones data persisting from Registry to JSON file

* Address PR comment: Remove redundant check

* Addres PR comment: Remove unused Dpi and add CmdArgs enum

* Address PR comment: Make methods const and inline

* Address PR comments: Expose GenerateUniqueId function and use const ref instead of passing wstring by value

* Address PR comment: Use lamdba as callback

* Address PR comment: Move GenerateUniqueId to ZoneWindowUtils namespace

* Address PR comment: Use regular comparison instead of std::wstring::compare

* Address PR comment: Use std::wstring_view for tmp file paths

* Address PR comment: Use scoped lock when accessing member data

* Address PR comment: Remove typedefs to increase code readability

* Address PR comment: removed nullptr checks with corresponding tests

* Address PR comment: Move ZoneSet object instead of copying

* Address PR comment: Make FancyZonesData instance const where possible

* Remove unnecessary gutter variable during calculating zone coordinates

* Remove uneeded subclass

* Avoid unnecessary copying and reserve space for vector if possible

* Save FancyZones data after exiting editor

* App zone history (#18)

* added window and zone set ids to app zone history

* Rename JSON file

* Remove AppZoneHistory migration

* Move parsing of ZoneWindow independent temp files outside of it

* Unit tests update (#19)

* check device existence in map
* updated ZoneSet tests
* updated JsonHelpers tests

* Use single zone count information

* Remove uneeded tests

* Remove one more test

* Remove uneeded line

* Address PR comments - Missing whitespace

* Update zoneset data for new virtual desktops (#21)

* update active zone set with actual data

* Introduce Blank zone set (used to indicate that no layout applied yet). Move parsing completely outside of ZoneWindow.

* Fix unit tests to match modifications in implementation

* Fix applying layouts on startup (second monitor)

Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: Seraphima <zykovas91@gmail.com>

src/modules/fancyzones/tests/UnitTests/Util.cpp

@@ -0,0 +1,149 @@
+#include "pch.h"
+#include "Util.h"
+
+static int s_classId = 0;
+
+namespace Mocks
+{
+    class HwndCreator
+    {
+    public:
+        HwndCreator(const std::wstring& title = L"");
+
+        ~HwndCreator();
+
+        HWND operator()(HINSTANCE hInst);
+
+        void setHwnd(HWND val);
+        void setCondition(bool cond);
+
+        inline HINSTANCE getHInstance() const { return m_hInst; }
+        inline const std::wstring& getTitle() const { return m_windowTitle; }
+        inline const std::wstring& getWindowClassName() const { return m_windowClassName; }
+
+    private:
+        std::wstring m_windowTitle;
+        std::wstring m_windowClassName;
+
+        std::mutex m_mutex;
+        std::condition_variable m_conditionVar;
+        bool m_conditionFlag;
+        HANDLE m_thread;
+
+        HINSTANCE m_hInst;
+        HWND m_hWnd;
+    };
+
+    HWND WindowCreate(HINSTANCE hInst)
+    {
+        return HwndCreator()(hInst);
+    }
+}
+
+LRESULT CALLBACK DLLWindowProc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
+{
+    if (message == WM_DESTROY)
+    {
+        PostQuitMessage(0);
+        return 0;
+    }
+
+    return DefWindowProc(hwnd, message, wParam, lParam);
+}
+
+BOOL RegisterDLLWindowClass(LPCWSTR szClassName, Mocks::HwndCreator* creator)
+{
+    if (!creator)
+        return false;
+
+    WNDCLASSEX wc;
+
+    wc.hInstance = creator->getHInstance();
+    wc.lpszClassName = szClassName;
+    wc.lpfnWndProc = DLLWindowProc;
+    wc.cbSize = sizeof(WNDCLASSEX);
+
+    wc.style = CS_DBLCLKS;
+    wc.hIcon = LoadIcon(NULL, IDI_APPLICATION);
+    wc.hIconSm = LoadIcon(NULL, IDI_APPLICATION);
+    wc.hCursor = LoadCursor(NULL, IDC_ARROW);
+    wc.lpszMenuName = NULL;
+    wc.cbClsExtra = 0;
+    wc.cbWndExtra = 0;
+    wc.hbrBackground = (HBRUSH)COLOR_BACKGROUND;
+
+    auto regRes = RegisterClassEx(&wc);
+    return regRes;
+}
+
+DWORD WINAPI ThreadProc(LPVOID lpParam)
+{
+    MSG messages;
+    Mocks::HwndCreator* creator = reinterpret_cast<Mocks::HwndCreator*>(lpParam);
+    if (!creator)
+        return -1;
+
+    if (RegisterDLLWindowClass((LPCWSTR)creator->getWindowClassName().c_str(), creator) != 0)
+    {
+        auto hWnd = CreateWindowEx(0, (LPCWSTR)creator->getWindowClassName().c_str(), (LPCWSTR)creator->getTitle().c_str(), WS_EX_APPWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, 10, 10, nullptr, nullptr, creator->getHInstance(), NULL);
+        creator->setHwnd(hWnd);
+        creator->setCondition(true);
+
+        while (GetMessage(&messages, NULL, 0, 0))
+        {
+            TranslateMessage(&messages);
+            DispatchMessage(&messages);
+        }
+
+        creator->setHwnd(hWnd);
+    }
+    else
+    {
+        creator->setCondition(true);
+    }
+
+    return 1;
+}
+
+namespace Mocks
+{
+    HwndCreator::HwndCreator(const std::wstring& title) :
+        m_windowTitle(title), m_windowClassName(std::to_wstring(++s_classId)), m_conditionFlag(false), m_thread(nullptr), m_hInst(HINSTANCE{}), m_hWnd(nullptr)
+    {
+    }
+
+    HwndCreator::~HwndCreator()
+    {
+        std::unique_lock<std::mutex> lock(m_mutex);
+        m_conditionVar.wait(lock, [this] { return m_conditionFlag; });
+
+        if (m_thread)
+        {
+            CloseHandle(m_thread);
+        }
+    }
+
+    HWND HwndCreator::operator()(HINSTANCE hInst)
+    {
+        m_hInst = hInst;
+        m_conditionFlag = false;
+        std::unique_lock<std::mutex> lock(m_mutex);
+
+        m_thread = CreateThread(0, NULL, ThreadProc, (LPVOID)this, NULL, NULL);
+        m_conditionVar.wait(lock, [this] { return m_conditionFlag; });
+
+        return m_hWnd;
+    }
+
+    void HwndCreator::setHwnd(HWND val)
+    {
+        m_hWnd = val;
+    }
+
+    void HwndCreator::setCondition(bool cond)
+    {
+        m_conditionFlag = cond;
+        m_conditionVar.notify_one();
+    }
+
+}