mir/PowerToys
2
0
Fork 0
mirror of https://github.com/microsoft/PowerToys synced 2025-09-01 15:05:12 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

[runner, color picker, run] remove os dection (#10648)

Browse Source
This commit is contained in:
Enrico Giordani
2021-04-08 07:10:05 -07:00
committed by GitHub
parent 97fdf10cea
commit aa5ff65b54
3 changed files with 72 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/runner/settings_window.cpp
View File

@@ -20,7 +20,6 @@
#include <common/version/helper.h>
#include <common/logger/logger.h>
#include <common/utils/elevation.h>
#include <common/utils/os-detect.h>
#include <common/utils/process_path.h>
#include <common/utils/timeutil.h>
#include <common/utils/winapi_error.h>
@@ -367,12 +366,12 @@ void run_settings_window(bool showOobeWindow)
BOOL process_created = false;
// Due to a bug in .NET, running the Settings process as non-elevated
// from an elevated process sometimes results in a crash.
// TODO: Revisit this after switching to .NET 5
if (is_process_elevated() && !UseNewSettings())
if (is_process_elevated())
{
process_created = run_settings_non_elevated(executable_path.c_str(), executable_args.data(), &process_info);
// TODO: Revisit this after switching to .NET 5
// Due to a bug in .NET, running the Settings process as non-elevated
// from an elevated process sometimes results in a crash.
// process_created = run_settings_non_elevated(executable_path.c_str(), executable_args.data(), &process_info);
}
if (FALSE == process_created)