diff --git a/.github/actions/spell-check/candidate.patterns b/.github/actions/spell-check/candidate.patterns index 13bcc3b29f..7aa9c89c91 100644 --- a/.github/actions/spell-check/candidate.patterns +++ b/.github/actions/spell-check/candidate.patterns @@ -1,6 +1,9 @@ # D2D #D?2D +# Repeated letters +\b([a-z])\g{-1}{2,}\b + # marker to ignore all code on line ^.*/\* #no-spell-check-line \*/.*$ # marker to ignore all code on line @@ -10,6 +13,9 @@ # cspell inline ^.*\b[Cc][Ss][Pp][Ee][Ll]{2}:\s*[Dd][Ii][Ss][Aa][Bb][Ll][Ee]-[Ll][Ii][Nn][Ee]\b +# copyright +Copyright (?:\([Cc]\)|)(?:[-\d, ]|and)+(?: [A-Z][a-z]+ [A-Z][a-z]+,?)+ + # patch hunk comments ^@@ -\d+(?:,\d+|) \+\d+(?:,\d+|) @@ .* # git index header @@ -18,6 +24,9 @@ index (?:[0-9a-z]{7,40},|)[0-9a-z]{7,40}\.\.[0-9a-z]{7,40} # file permissions ['"`\s][-bcdLlpsw](?:[-r][-w][-Ssx]){2}[-r][-w][-SsTtx]\+?['"`\s] +# css fonts +\bfont(?:-family|):[^;}]+ + # css url wrappings \burl\([^)]+\) @@ -29,7 +38,7 @@ index (?:[0-9a-z]{7,40},|)[0-9a-z]{7,40}\.\.[0-9a-z]{7,40} # data url in quotes ([`'"])data:(?:[^ `'"].*?|)(?:[A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,}).*\g{-1} # data url -\bdata:[-a-zA-Z=;:/0-9+]*,\S* +\bdata:[-a-zA-Z=;:/0-9+_]*,\S* # https/http/file urls #(?:\b(?:https?|ftp|file)://)[-A-Za-z0-9+&@#/*%?=~_|!:,.;]+[-A-Za-z0-9+&@#/*%=~_|] @@ -68,6 +77,8 @@ magnet:[?=:\w]+ # Amazon \bamazon\.com/[-\w]+/(?:dp/[0-9A-Z]+|) +# AWS ARN +arn:aws:[-/:\w]+ # AWS S3 \b\w*\.s3[^.]*\.amazonaws\.com/[-\w/&#%_?:=]* # AWS execute-api @@ -94,6 +105,8 @@ vpc-\w+ \bgoogle-analytics\.com/collect.[-0-9a-zA-Z?%=&_.~]* # Google APIs \bgoogleapis\.(?:com|dev)/[a-z]+/(?:v\d+/|)[a-z]+/[-@:./?=\w+|&]+ +# Google Artifact Registry +\.pkg\.dev(?:/[-\w]+)+(?::[-\w]+|) # Google Storage \b[-a-zA-Z0-9.]*\bstorage\d*\.googleapis\.com(?:/\S*|) # Google Calendar @@ -129,6 +142,8 @@ themes\.googleusercontent\.com/static/fonts/[^/\s"]+/v\d+/[^.]+. \bscholar\.google\.com/citations\?user=[A-Za-z0-9_]+ # Google Colab Research Drive \bcolab\.research\.google\.com/drive/[-0-9a-zA-Z_?=]* +# Google Cloud regions +(?:us|(?:north|south)america|europe|asia|australia|me|africa)-(?:north|south|east|west|central){1,2}\d+ # GitHub SHAs (api) \bapi.github\.com/repos(?:/[^/\s"]+){3}/[0-9a-f]+\b @@ -167,6 +182,12 @@ GHSA(?:-[0-9a-z]{4}){3} # GitLab commits \bgitlab\.[^/\s"]*/(?:[^/\s"]+/){2}commits?/[0-9a-f]+\b +# #includes +^\s*#include\s*(?:<.*?>|".*?") + +# #pragma lib +^\s*#pragma comment\(lib, ".*?"\) + # binance accounts\.binance\.com/[a-z/]*oauth/authorize\?[-0-9a-zA-Z&%]* @@ -219,7 +240,7 @@ accounts\.binance\.com/[a-z/]*oauth/authorize\?[-0-9a-zA-Z&%]* \bmedium\.com/@?[^/\s"]+/[-\w]+ # microsoft -\b(?:https?://|)(?:(?:download\.visualstudio|docs|msdn2?|research)\.microsoft|blogs\.msdn)\.com/[-_a-zA-Z0-9()=./%]* +\b(?:https?://|)(?:(?:(?:blogs|download\.visualstudio|docs|msdn2?|research)\.|)microsoft|blogs\.msdn)\.co(?:m|\.\w\w)/[-_a-zA-Z0-9()=./%]* # powerbi \bapp\.powerbi\.com/reportEmbed/[^"' ]* # vs devops @@ -393,7 +414,7 @@ ipfs://[0-9a-zA-Z]{3,} \bgetopts\s+(?:"[^"]+"|'[^']+') # ANSI color codes -(?:\\(?:u00|x)1[Bb]|\x1b|\\u\{1[Bb]\})\[\d+(?:;\d+|)m +(?:\\(?:u00|x)1[Bb]|\\03[1-7]|\x1b|\\u\{1[Bb]\})\[\d+(?:;\d+)*m # URL escaped characters %[0-9A-F][A-F](?=[A-Za-z]) @@ -429,10 +450,14 @@ sha\d+:[0-9a-f]*?[a-f]{3,}[0-9a-f]* # pki (base64) LS0tLS1CRUdJT.* +# C# includes +^\s*using [^;]+; + # uuid: \b[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}\b # hex digits including css/html color classes: -(?:[\\0][xX]|\\u|[uU]\+|#x?|%23)[0-9_a-fA-FgGrR]*?[a-fA-FgGrR]{2,}[0-9_a-fA-FgGrR]*(?:[uUlL]{0,3}|[iu]\d+)\b +(?:[\\0][xX]|\\u\{?|[uU]\+|#x?|%23|&H)[0-9_a-fA-FgGrR]*?[a-fA-FgGrR]{2,}[0-9_a-fA-FgGrR]*(?:[uUlL]{0,3}|[iu]\d+)\b + # integrity integrity=(['"])(?:\s*sha\d+-[-a-zA-Z=;:/0-9+]{40,})+\g{-1} @@ -450,7 +475,10 @@ integrity=(['"])(?:\s*sha\d+-[-a-zA-Z=;:/0-9+]{40,})+\g{-1} Name\[[^\]]+\]=.* # IServiceProvider / isAThing -(?:\b|_)(?:(?:ns|)I|isA)(?=(?:[A-Z][a-z]{2,})+(?:[A-Z\d]|\b)) +(?:(?:\b|_|(?<=[a-z]))I|(?:\b|_)(?:nsI|isA))(?=(?:[A-Z][a-z]{2,})+(?:[A-Z\d]|\b)) + +# python +#\b(?i)py(?!gments|gmy|lon|ramid|ro|th)(?=[a-z]{2,}) # crypt (['"])\$2[ayb]\$.{56}\g{-1} @@ -464,17 +492,14 @@ Name\[[^\]]+\]=.* # machine learning (?) #\b(?i)ml(?=[a-z]{2,}) -# python -#\b(?i)py(?!gments|gmy|lon|ramid|ro|th)(?=[a-z]{2,}) - # scrypt / argon \$(?:scrypt|argon\d+[di]*)\$\S+ # go.sum \bh1:\S+ -# scala imports -^import (?:[\w.]|\{\w*?(?:,\s*(?:\w*|\*))+\})+ +# imports +^import\s+(?:(?:static|type)\s+|)(?:[\w.]|\{\s*\w*?(?:,\s*(?:\w*|\*))+\s*\})+ # scala modules #("[^"]+"\s*%%?\s*){2,3}"[^"]+" @@ -483,13 +508,13 @@ Name\[[^\]]+\]=.* image: [-\w./:@]+ # Docker images -^\s*FROM\s+\S+:\S+(?:\s+AS\s+\S+|) +^\s*(?i)FROM\s+\S+:\S+(?:\s+AS\s+\S+|) # `docker images` REPOSITORY TAG IMAGE ID CREATED SIZE \s*\S+/\S+\s+\S+\s+[0-9a-f]{8,}\s+\d+\s+(?:hour|day|week)s ago\s+[\d.]+[KMGT]B # Intel intrinsics -_mm_(?!dd)\w+ +_mm\d*_(?!dd)\w+ # Input to GitHub JSON content: (['"])[-a-zA-Z=;:/0-9+]*=\g{-1} @@ -523,7 +548,7 @@ content: (['"])[-a-zA-Z=;:/0-9+]*=\g{-1} # javascript replace regex \.replace\(/[^/\s"]{3,}/[gim]*\s*, # assign regex -= /[^*].*?(?:[a-z]{3,}|[A-Z]{3,}|[A-Z][a-z]{2,}).*/[gi]?(?=\W|$) += /[^*].*?(?:[a-z]{3,}|[A-Z]{3,}|[A-Z][a-z]{2,}).*/[gim]*(?=\W|$) # perl regex test [!=]~ (?:/.*/|m\{.*?\}|m<.*?>|m([|!/@#,;']).*?\g{-1}) @@ -537,7 +562,7 @@ perl(?:\s+-[a-zA-Z]\w*)+ #(?:\d|\bh)to(?!ken)(?=[a-z])|to(?=[adhiklpun]\() # Go regular expressions -regexp?\.MustCompile\(`[^`]*`\) +regexp?\.MustCompile\((?:`[^`]*`|".*"|'.*')\) # regex choice \(\?:[^)]+\|[^)]+\) @@ -585,7 +610,7 @@ urn:shemas-jetbrains-com # xcode # xcodeproject scenes -(?:Controller|destination|ID|id)="\w{3}-\w{2}-\w{3}" +(?:Controller|destination|(?:first|second)Item|ID|id)="\w{3}-\w{2}-\w{3}" # xcode api botches customObjectInstantitationMethod @@ -600,27 +625,33 @@ PrependWithABINamepsace \.fa-[-a-z0-9]+ # bearer auth -(['"])[Bb]ear[e][r] .*?\g{-1} +(['"])[Bb]ear[e][r] .{3,}?\g{-1} # bearer auth -\b[Bb]ear[e][r]:? [-a-zA-Z=;:/0-9+.]+ +\b[Bb]ear[e][r]:? [-a-zA-Z=;:/0-9+.]{3,} # basic auth (['"])[Bb]asic [-a-zA-Z=;:/0-9+]{3,}\g{-1} +# basic auth +: [Bb]asic [-a-zA-Z=;:/0-9+.]{3,} + # base64 encoded content #([`'"])[-a-zA-Z=;:/0-9+]{3,}=\g{-1} # base64 encoded content in xml/sgml >[-a-zA-Z=;:/0-9+]{3,}=?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_]{40,} # DNS rr data -(?:\d+\s+){3}(?:[-+/=.\w]{2,}\s*){1,2} +#(?:\d+\s+){3}(?:[-+/=.\w]{2,}\s*){1,2} # encoded-word =\?[-a-zA-Z0-9"*%]+\?[BQ]\?[^?]{0,75}\?= @@ -629,7 +660,7 @@ PrependWithABINamepsace \bnumer\b(?=.*denom) # Time Zones -\b(?:Africa|Atlantic|America|Antarctica|Asia|Australia|Europe|Indian|Pacific)(?:/\w+)+ +\b(?:Africa|Atlantic|America|Antarctica|Arctic|Asia|Australia|Europe|Indian|Pacific)(?:/[-\w]+)+ # linux kernel info ^(?:bugs|flags|Features)\s+:.* @@ -669,13 +700,13 @@ systemd.*?running in system mode \([-+].*\)$ TeX/AMS # File extensions -\*\.[+\w]+, +#\*\.[+\w]+, # eslint "varsIgnorePattern": ".+" # nolint -nolint:\w+ +nolint:\s*[\w,]+ # Windows short paths [/\\][^/\\]{5,6}~\d{1,2}(?=[/\\]) @@ -683,6 +714,9 @@ nolint:\w+ # Windows Resources with accelerators \b[A-Z]&[a-z]+\b(?!;) +# signed off by +(?i)Signed-off-by: .* + # cygwin paths /cygdrive/[a-zA-Z]/(?:Program Files(?: \(.*?\)| ?)(?:/[-+.~\\/()\w ]+)*|[-+.~\\/()\w])+ @@ -715,29 +749,31 @@ W/"[^"]+" # Compiler flags (Unix, Java/Scala) # Use if you have things like `-Pdocker` and want to treat them as `docker` -#(?:^|[\t ,>"'`=(])-(?:(?:J-|)[DPWXY]|[Llf])(?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) +#(?:^|[\t ,>"'`=(#])-(?:(?:J-|)[DPWXY]|[Llf])(?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) # Compiler flags (Windows / PowerShell) # This is a subset of the more general compiler flags pattern. # It avoids matching `-Path` to prevent it from being treated as `ath` -#(?:^|[\t ,"'`=(])-(?:[DPL](?=[A-Z]{2,})|[WXYlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,})) +#(?:^|[\t ,"'`=(#])-(?:[DPL](?=[A-Z]{2,})|[WXYlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,})) # Compiler flags (linker) ,-B -# libraries -(?:\b|_)lib(?:re(?=office)|)(?!era[lt]|ero|erty|rar(?:i(?:an|es)|y))(?=[a-z]) - -# WWNN/WWPN (NAA identifiers) -\b(?:0x)?10[0-9a-f]{14}\b|\b(?:0x|3)?[25][0-9a-f]{15}\b|\b(?:0x|3)?6[0-9a-f]{31}\b +# Library prefix +# e.g., `lib`+`archive`, `lib`+`raw`, `lib`+`unwind` +# (ignores some words that happen to start with `lib`) +(?:\b|_)[Ll]ib(?:re(?=office)|)(?!era[lt]|ero|erty|rar(?:i(?:an|es)|y))(?=[a-z]) # iSCSI iqn (approximate regex) \biqn\.[0-9]{4}-[0-9]{2}(?:[\.-][a-z][a-z0-9]*)*\b +# WWNN/WWPN (NAA identifiers) +\b(?:0x)?10[0-9a-f]{14}\b|\b(?:0x|3)?[25][0-9a-f]{15}\b|\b(?:0x|3)?6[0-9a-f]{31}\b + # curl arguments \b(?:\\n|)curl(?:\.exe|)(?:\s+-[a-zA-Z]{1,2}\b)*(?:\s+-[a-zA-Z]{3,})(?:\s+-[a-zA-Z]+)* # set arguments -\b(?:bash|sh|set)(?:\s+-[abefimouxE]{1,2})*\s+-[abefimouxE]{3,}(?:\s+-[abefimouxE]+)* +\b(?:bash|sh|set)(?:\s+[-+][abefimouxE]{1,2})*\s+[-+][abefimouxE]{3,}(?:\s+[-+][abefimouxE]+)* # tar arguments \b(?:\\n|)g?tar(?:\.exe|)(?:(?:\s+--[-a-zA-Z]+|\s+-[a-zA-Z]+|\s[ABGJMOPRSUWZacdfh-pr-xz]+\b)(?:=[^ ]*|))+ # tput arguments -- https://man7.org/linux/man-pages/man5/terminfo.5.html -- technically they can be more than 5 chars long... diff --git a/.github/actions/spell-check/excludes.txt b/.github/actions/spell-check/excludes.txt index eb6600aced..6870b3e86e 100644 --- a/.github/actions/spell-check/excludes.txt +++ b/.github/actions/spell-check/excludes.txt @@ -73,7 +73,9 @@ \.qm$ \.s$ \.sig$ +\.snk$ \.so$ +\.stl$ \.svgz?$ \.sys$ \.tar$ @@ -90,40 +92,40 @@ \.xz$ \.zip$ ^\.github/actions/spell-check/ +^\.github/workflows/spelling\d*\.yml$ ^\.gitmodules$ -^\Q.github/workflows/spelling2.yml\E$ -^\Q.pipelines/272MSSharedLibSN2048.snk\E$ ^\Q.pipelines/ESRPSigning_core.json\E$ ^\Qdoc/devdocs/localization.md\E$ -^\Qsrc/common/ManagedCommon/ColorFormatHelper.cs\E$ -^\Qsrc/common/notifications/BackgroundActivatorDLL/cpp.hint\E$ -^\Qsrc/modules/cmdpal/doc/initial-sdk-spec/list-elements-mock-002.pdn\E$ -^\Qsrc/modules/colorPicker/ColorPickerUI/Assets/ColorPicker/colorPicker.cur\E$ -^\Qsrc/modules/colorPicker/ColorPickerUI/Shaders/GridShader.cso\E$ ^\Qsrc/modules/MouseUtils/MouseJump.Common/NativeMethods/User32/UI/WindowsAndMessaging/User32.SYSTEM_METRICS_INDEX.cs\E$ -^\Qsrc/modules/MouseUtils/MouseJumpUI/MainForm.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmAbout.cs\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmInputCallback.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmLogon.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmMatrix.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmMessage.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmMouseCursor.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/App/Form/frmScreen.resx\E$ -^\Qsrc/modules/MouseWithoutBorders/ModuleInterface/generateSecurityDescriptor.h\E$ -^\Qsrc/modules/peek/Peek.Common/NativeMethods.txt\E$ -^\Qsrc/modules/previewpane/SvgPreviewHandler/SvgHTMLPreviewGenerator.cs\E$ -^\Qsrc/modules/previewpane/UnitTests-StlThumbnailProvider/HelperFiles/sample.stl\E$ -^\Qtools/project_template/ModuleTemplate/resource.h\E$ ^doc/devdocs/akaLinks\.md$ +^NOTICE\.md$ +^src/common/CalculatorEngineCommon/exprtk\.hpp$ +^src/common/ManagedCommon/ColorFormatHelper\.cs$ +^src/common/notifications/BackgroundActivatorDLL/cpp\.hint$ +^src/common/sysinternals/Eula/ +^src/modules/cmdpal/doc/initial-sdk-spec/list-elements-mock-002\.pdn$ +^src/modules/colorPicker/ColorPickerUI/Shaders/GridShader\.cso$ ^src/modules/launcher/Plugins/Microsoft\.PowerToys\.Run\.Plugin\.TimeDate/Properties/ +^src/modules/MouseUtils/MouseJumpUI/MainForm\.resx$ ^src/modules/MouseWithoutBorders/App/.*/NativeMethods\.cs$ ^src/modules/MouseWithoutBorders/App/Form/.*\.Designer\.cs$ ^src/modules/MouseWithoutBorders/App/Form/.*\.resx$ +^src/modules/MouseWithoutBorders/App/Form/frmAbout\.cs$ +^src/modules/MouseWithoutBorders/App/Form/frmInputCallback\.resx$ +^src/modules/MouseWithoutBorders/App/Form/frmLogon\.resx$ +^src/modules/MouseWithoutBorders/App/Form/frmMatrix\.resx$ +^src/modules/MouseWithoutBorders/App/Form/frmMessage\.resx$ +^src/modules/MouseWithoutBorders/App/Form/frmMouseCursor\.resx$ +^src/modules/MouseWithoutBorders/App/Form/frmScreen\.resx$ ^src/modules/MouseWithoutBorders/App/Helper/.*\.resx$ +^src/modules/MouseWithoutBorders/ModuleInterface/generateSecurityDescriptor\.h$ +^src/modules/peek/Peek.Common/NativeMethods\.txt$ +^src/modules/previewpane/SvgPreviewHandler/SvgHTMLPreviewGenerator\.cs$ ^src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HelperFiles/MarkdownWithHTMLImageTag\.txt$ +^src/modules/registrypreview/RegistryPreviewUILib/Controls/HexBox/.*$ ^src/modules/ZoomIt/ZoomIt/ZoomIt\.idc$ ^src/Monaco/ -^src/common/sysinternals/Eula/ +^tools/project_template/ModuleTemplate/resource\.h$ ^tools/Verification scripts/Check preview handler registration\.ps1$ ignore$ ^src/modules/registrypreview/RegistryPreviewUILib/Controls/HexBox/.*$ diff --git a/.github/actions/spell-check/expect.txt b/.github/actions/spell-check/expect.txt index 7c8345eda6..3a52c954a5 100644 --- a/.github/actions/spell-check/expect.txt +++ b/.github/actions/spell-check/expect.txt @@ -1,4 +1,4 @@ -aaaa +AAAAs abcdefghjkmnpqrstuvxyz abgr ABlocked @@ -9,23 +9,24 @@ ACCEPTFILES ACCESSDENIED ACCESSTOKEN acfs +ACIE AClient AColumn acrt ACTIVATEAPP -activationaction ACTIVATEOPTIONS -ACVS +activationaction adaptivecards ADate ADDSTRING ADDUNDORECORD ADifferent +ADMINS adml admx +advancedpaste advfirewall AFeature -AFFINETRANSFORM affordances AFX AGGREGATABLE @@ -43,12 +44,11 @@ ALPHATYPE AModifier amr ANDSCANS -animatedvisuals Animnate -ansicolor ANull AOC aocfnapldcnfbofgmbbllojgocaelgdd +AOklab APARTMENTTHREADED APeriod apicontract @@ -66,10 +66,10 @@ appref appsettings appwindow appwiz +appxpackage APSTUDIO AQS ARandom -Arash ARCHITEW ARemapped ARPINSTALLLOCATION @@ -77,6 +77,7 @@ ARPPRODUCTICON ARRAYSIZE ARROWKEYS asf +Ashcraft AShortcut ASingle ASSOCCHANGED @@ -85,7 +86,6 @@ ASSOCSTR ASYNCWINDOWPLACEMENT ASYNCWINDOWPOS atl -atleast ATRIOX aumid Authenticode @@ -99,12 +99,11 @@ Autorun AUTOTICKS AUTOUPDATE AValid -awakeness AWAYMODE azcliversion azman -backtracer bbwe +BCIE bck BESTEFFORT bezelled @@ -130,12 +129,10 @@ Blt BLURBEHIND BLURREGION bmi -bms -BNDBk BNumber BODGY +BOklab BOOTSTRAPPERINSTALLFOLDER -bostrot BOTTOMALIGN boxmodel BPBF @@ -164,7 +161,6 @@ callbackptr calpwstr Cangjie CANRENAME -Cantarell CAPTUREBLT CAPTURECHANGED CARETBLINKING @@ -175,6 +171,7 @@ CCHFORMNAME CCom CContext CDeclaration +CDPX CElems CENTERALIGN cer @@ -187,6 +184,7 @@ CHILDACTIVATE CHILDWINDOW CHOOSEFONT cidl +CIELCh cim CImage cla @@ -216,6 +214,7 @@ CMONITORS cmph CNF coclass +CODENAME codereview Codespaces COINIT @@ -229,6 +228,7 @@ comctl comdlg comexp cominterop +commandnotfound commandpalette compmgmt COMPOSITIONFULL @@ -236,15 +236,18 @@ CONFIGW CONFLICTINGMODIFIERKEY CONFLICTINGMODIFIERSHORTCUT CONOUT +constexpr +contentdialog contentfiles CONTEXTHELP CONTEXTMENUHANDLER contractversion -CONTROLL CONTROLPARENT copiedcolorrepresentation +copyable COPYPEN COREWINDOW +Corpor cotaskmem COULDNOT countof @@ -261,6 +264,7 @@ CREATEWINDOWFAILED CRECT CRH critsec +cropandlock Crossdevice CSearch CSettings @@ -270,9 +274,7 @@ CStyle cswin CTest CTEXT -Ctl CTLCOLORSTATIC -currentculture CURRENTDIR CURSORINFO cursorpos @@ -284,17 +286,17 @@ CVal cvd CVirtual CVS -cxfksword CXSCREEN CXSMICON CXVIRTUALSCREEN -cyberrex CYSCREEN CYSMICON CYVIRTUALSCREEN cziplib Dac dacl +DAffine +DAFFINETRANSFORM datareader datatracker dataversion @@ -305,18 +307,13 @@ DBLEPSILON DBPROP DBPROPIDSET DBPROPSET -DCapture DCBA DCOM DComposition DCR -ddd DDEIf -DDevice -DDxgi Deact debugbreak -declatory decryptor Dedup Deeplink @@ -332,10 +329,8 @@ DEFAULTTOPRIMARY DEFERERASE DEFPUSHBUTTON deinitialization -DELA DELETEDKEYIMAGE DELETESCANS -deletethis DEMOTYPE DENORMAL depersist @@ -356,7 +351,6 @@ devpal DFX DIALOGEX digicert -dimm DINORMAL DISABLEASACTIONKEY DISABLENOSCROLL @@ -380,7 +374,6 @@ DONTVALIDATEPATH dotnet DPICHANGED DPIs -DPolicy DPSAPI DQTAT DQTYPE @@ -389,13 +382,12 @@ DRAWFRAME drawingcolor dreamsofameaningfullife drivedetectionwarning -Droid DROPFILES DSTINVERT -DSurface -DTexture +DString +DSVG +DTo DUMMYUNIONNAME -Dutil DVASPECT DVASPECTINFO DVD @@ -438,6 +430,7 @@ ENDSESSION ENSUREVISIBLE ENTERSIZEMOVE ENU +environmentvariables EOAC EPO epu @@ -446,7 +439,6 @@ EREOF EResize ERRORIMAGE ERRORTITLE -erwrite ESettings esrp ETDT @@ -454,7 +446,6 @@ etl etw eula eurochange -eventlog eventvwr evt EWXFORCE @@ -489,11 +480,13 @@ eyetracker FANCYZONESDRAWLAYOUTTEST FANCYZONESEDITOR FARPROC -fff FFFF FILEEXPLORER +fileexploreraddons +fileexplorerpreview FILEFLAGS FILEFLAGSMASK +filelocksmith FILELOCKSMITHCONTEXTMENU FILELOCKSMITHEXT FILELOCKSMITHLIBINTEROP @@ -506,10 +499,9 @@ FILESUBTYPE FILESYSPATH Filetime FILEVERSION -Filterkeyboard FILTERMODE findfast -Fira +findmymouse FIXEDFILEINFO FIXEDSYS flac @@ -526,13 +518,12 @@ FORCEMINIMIZE FORMATDLGORD formatetc FORPARSING -Fqc FRAMECHANGED frm -Froml FROMTOUCH fsanitize fsmgmt +fuzzingtesting FZE gacutil Gaeilge @@ -544,7 +535,6 @@ gdi gdiplus GDIPVER GDISCALED -GEmoji GETCLIENTAREAANIMATION GETCURSEL GETDESKWALLPAPER @@ -569,7 +559,6 @@ GPOCA gpp gpu gradians -gsl GSM gtm guiddata @@ -617,7 +606,6 @@ hicon HIDEREADONLY HIDEWINDOW Hif -hightlight HIMAGELIST himl hinst @@ -641,12 +629,14 @@ homljgmgpmcbpjbnjpfijnhipfkiclkd HORZRES HORZSIZE Hostbackdropbrush +hostsfileeditor +Hostx +hotfixes hotkeycontrol HOTKEYF hotkeys hotlight hotspot -Hostx HPAINTBUFFER HRAWINPUT HREDRAW @@ -675,7 +665,6 @@ HWNDPARENT HWNDPREV hyjiacan IAI -IBeam icf ICONERROR ICONLOCATION @@ -685,13 +674,13 @@ idk idl idlist IDOK +IDOn IDR IDXGI ietf IEXPLORE IFACEMETHOD IFACEMETHODIMP -IFile IGNOREUNKNOWN IGo iid @@ -717,7 +706,7 @@ INITDIALOG INITGUID INITTOLOGFONTSTRUCT INLINEPREFIX -inorder +Inlines INPC inproc INPUTHARDWARE @@ -742,27 +731,26 @@ Interlop INTRESOURCE INVALIDARG invalidoperatioexception +invokecommand ipcmanager IPREVIEW +ipreviewhandlervisualssetfont +irow irprops isbi -ISearch -ISettings -isocpp +isfinite iss issecret ISSEPARATOR +issuecomment istep ith ITHUMBNAIL IUI -IUnknown -IUse IWIC jfif jgeosdfsdsgmkedfgdfgdfgbkmhcgcflmi jjw -JLO jobject jpe jpnime @@ -783,16 +771,19 @@ KEYEVENTF KEYIMAGE keynum keyremaps +keyring keyvault KILLFOCUS killrunner kmph Kybd lastcodeanalysissucceeded -Lastdevice LASTEXITCODE LAYOUTRTL +LCh +lcid LCIDTo +lcl Lclean Ldone Ldr @@ -803,6 +794,7 @@ LError LEVELID LExit lhwnd +LIBFUZZER LIBID LIMITSIZE LIMITTEXT @@ -816,10 +808,8 @@ LLKH llkhf LMEM LMENU -lnks LOADFROMFILE LOBYTE -LOCALDISPLAY localpackage LOCALSYSTEM LOCATIONCHANGE @@ -829,6 +819,7 @@ LOGFONTW logon LOGPIXELSX LOGPIXELSY +LOn longdate LONGNAMES lowlevel @@ -873,11 +864,9 @@ lstrcmpi lstrcpyn lstrlen LTEXT -LTk LTRREADING luid LUMA -LUQ lusrmgr LVal lvm @@ -891,6 +880,7 @@ MAKEINTRESOURCEW MAKELANGID MAKELONG MAKELPARAM +makepri MAKEWPARAM manifestdependency MAPPEDTOSAMEKEY @@ -922,12 +912,13 @@ Microwaved middleclickaction midl mii +MIIM +mikeclayton mindaro Minimizable MINIMIZEBOX MINIMIZEEND MINIMIZESTART -miniz MINMAXINFO minwindef Mip @@ -951,13 +942,14 @@ monitorinfof MOUSEACTIVATE MOUSEDATA MOUSEEVENTF +mousehighlighter MOUSEHWHEEL MOUSEINPUT +mousejump +mousepointer +mouseutils MOVESIZEEND MOVESIZESTART -MOZILLAPL -MOZPL -mpmc MRM MRT mru @@ -980,15 +972,14 @@ msixbundle MSIXCA MSLLHOOKSTRUCT Mso -msp msrc msstore -mst msvcp MTND MULTIPLEUSE multizone muxc +MVPs mvvm MVVMTK MWBEx @@ -1010,7 +1001,6 @@ NCMBUTTONDOWN NCMBUTTONUP NCMOUSELEAVE NCMOUSEMOVE -nconsectetur ncpa NCPAINT NCRENDERING @@ -1031,8 +1021,6 @@ newplus NEWPLUSCONTEXTMENU NEWPLUSSHELLEXTENSIONWIN newrow -newsgroups -NGQt nicksnettravels NIF NLog @@ -1052,6 +1040,7 @@ NOCOPYBITS NOCOPYSECURITYATTRIBS NOCRLF nodeca +nodiscard NODRAWCAPTION NODRAWICON NOINHERITLAYOUT @@ -1067,7 +1056,6 @@ NONANTIALIASED nonclient NONCLIENTMETRICSW NONELEVATED -NONINFRINGEMENT nonspace nonstd NOOWNERZORDER @@ -1095,18 +1083,17 @@ NOTOPMOST NOTRACK NOTSRCCOPY NOTSRCERASE -NOTXORPEN notwindows +NOTXORPEN NOZORDER NPH npmjs NResize -nsunt NTAPI ntdll +ntfs NTSTATUS NTSYSAPI -NTZm NULLCURSOR nullonfailure numberbox @@ -1124,6 +1111,7 @@ oldpath oldtheme oleaut OLECHAR +onebranch openas opencode OPENFILENAME @@ -1133,7 +1121,6 @@ OPTIMIZEFORINVOKE ORPHANEDDIALOGTITLE ORSCANS oss -ostr OSVERSIONINFO OSVERSIONINFOEX OSVERSIONINFOEXW @@ -1141,14 +1128,13 @@ OSVERSIONINFOW osvi OUTOFCONTEXT Outptr +outputtype outsettings OVERLAPPEDWINDOW Oversampling OVERWRITEPROMPT -OWMt OWNDC OWNERDRAWFIXED -OWRj Packagemanager PACL PAINTSTRUCT @@ -1162,7 +1148,6 @@ PARTIALCONFIRMATIONDIALOGTITLE PATCOPY PATHMUSTEXIST PATINVERT -partow PATPAINT pbc pbi @@ -1175,7 +1160,7 @@ pchast PCIDLIST PCTSTR PCWSTR -pdbs +PDBs PDEVMODE pdisp PDLL @@ -1208,13 +1193,13 @@ pinfo pinvoke pipename PKBDLLHOOKSTRUCT -Playbadge plib ploc ploca plocm pluginsmodel PMAGTRANSFORM +PMs PMSIHANDLE pnid PNMLINK @@ -1247,6 +1232,7 @@ ppstm ppsz pptal ppv +ppwsz prc Prefixer prependpath @@ -1268,6 +1254,7 @@ prm proactively PROCESSENTRY PROCESSKEY +processthreadsapi PROCESSTRACE procmon PRODEXT @@ -1286,6 +1273,7 @@ PSECURITY psfgao psfi PSMODULEPATH +Psr psrm psrree pstatstg @@ -1303,14 +1291,12 @@ PTOKEN PToy ptstr pui -Puser PWAs pwcs PWSTR pwsz pwtd QDC -qianlifeng qit QITAB QITABENT @@ -1319,11 +1305,10 @@ Quarternary QUERYENDSESSION QUERYOPEN QUEUESYNC +quickaccent QUNS -QXZ RAII RAlt -Rappl randi Rasterization Rasterize @@ -1350,11 +1335,11 @@ REGCLS regfile REGISTERCLASSFAILED REGISTRYHEADER -registrypath REGISTRYPREVIEWEXT registryroot regkey regroot +regsvr REINSTALLMODE reloadable Relogger @@ -1379,7 +1364,6 @@ RESIZETOFIT resmimetype RESOURCEID RESTORETOMAXIMIZED -resultlist RETURNONLYFSDIRS RGBQUAD rgbs @@ -1388,10 +1372,10 @@ rgf rgh rgn rgs +rguid RIDEV RIGHTSCROLLBAR riid -ringbuffer RKey RNumber rop @@ -1399,7 +1383,6 @@ ROUNDSMALL ROWSETEXT rpcrt RRF -rrr rsop Rsp rstringalnum @@ -1407,6 +1390,7 @@ rstringalpha rstringdigit RTB RTLREADING +rtm runas rundll rungameid @@ -1425,10 +1409,9 @@ SAVEFAILED scanled schedtasks SCID -Scip -scipbe Scode SCREENFONTS +screenruler screensaver screenshots scrollviewer @@ -1474,7 +1457,7 @@ SFGAOF SHACF SHANDLE sharepoint -sharpkeys +sharpfuzz SHCNE SHCNF SHCONTF @@ -1500,7 +1483,6 @@ SHORTCUTMAXONEACTIONKEY SHORTCUTNOREPEATEDMODIFIER SHORTCUTONEACTIONKEY SHORTCUTSTARTWITHMODIFIER -Shortcuttool shortdate SHORTPATH shortsplit @@ -1546,6 +1528,7 @@ snk snwprintf softline SOURCECLIENTAREAONLY +sourced sourcedoc SOURCEHEADER sourcesdirectory @@ -1609,11 +1592,13 @@ strret stscanf sttngs Stubless +stuttery STYLECHANGED STYLECHANGING subkeys sublang SUBMODULEUPDATE +subresource Superbar sut svchost @@ -1643,21 +1628,19 @@ SYSMENU SYSTEMAPPS SYSTEMMODAL SYSTEMTIME -TApplication -TApplied -targ +TARG TARGETAPPHEADER TARGETDIR targetentrypoint TARGETHEADER targetver +taskbar taskkill taskschd TCHAR TCIF TCITEM TCN -Tcollab tcs tcscat tcschr @@ -1666,16 +1649,14 @@ tcscpy tcsdup tcslen tcsrchr -TCustom tdbuild -TDefault -TDevice telephon templatenamespace TESTONLY testprocess TEXCOORD TEXTBOXNEWLINE +textextractor TEXTINCLUDE tfopen tgz @@ -1683,9 +1664,7 @@ themeresources THH THICKFRAME THISCOMPONENT -THotkey throughs -TIcon TILEDWINDOW TILLSON timedate @@ -1696,7 +1675,6 @@ TITLEBARINFO Titlecase tkcontrols tkconverters -TLayout tlb tlbimp tlc @@ -1714,20 +1692,14 @@ tracelogging tracerpt trackbar trafficmanager -traies transicc TRAYMOUSEMESSAGE -TResult triaging trl trx tsa -TSender -TServer tskill tstoi -TStr -tweakme TWF tymed TYPEKEYBOARD @@ -1741,7 +1713,6 @@ UBR UCallback ucrt ucrtd -udit uefi uesc UFlags @@ -1753,7 +1724,6 @@ ums uncompilable UNCPRIORITY UNDNAME -unhiding UNICODETEXT uninstalls Uniquifies @@ -1767,7 +1737,6 @@ unwide unzoom UOffset UOI -Updatelayout UPDATENOW UPDATEREGISTRY updown @@ -1789,6 +1758,7 @@ vabdq validmodulename valuegenerator variantassignment +VARTYPE vcamp VCENTER vcgtq @@ -1808,12 +1778,11 @@ VERTSIZE VFT vget vgetq -viewmodel +viewmodels VIRTKEY VIRTUALDESK VISEGRADRELAY visiblecolorformats -Visibletrue visualeffects vkey vmovl @@ -1865,13 +1834,12 @@ wekyb wft wgpocpl WHEREID -Wholegrain wic wifi -wil +wikipedia +WIL winapi winappsdk -wincolor windir WINDOWCREATED WINDOWEDGE @@ -1887,6 +1855,8 @@ WINDOWSTYLES WINDOWSTYLESICON winerror WINEVENT +winexe +winforms winget wingetcreate Winhook @@ -1942,7 +1912,6 @@ WRITEOBJECTS Wrk wrl wscui -wsf wsh wstr wsz @@ -1963,6 +1932,7 @@ XElement xfd XFile XIncrement +XLoc XNamespace Xoshiro XPels @@ -1976,16 +1946,15 @@ XVIRTUALSCREEN xxxxxx YAxis ycombinator -Yeet YIncrement yinle yinyue YPels YResolution YStr -YTM YVIRTUALSCREEN ZEROINIT +zonability zonable zoneset Zoneszonabletester @@ -1993,58 +1962,3 @@ Zoomin zoomit ZOOMITX Zorder -ZXk -ZXNs -zzz -ACIE -AOklab -BCIE -BOklab -culori -Evercoder -LCh -CIELCh -irow -lcid -ppwsz -rguid -VARTYPE -advancedpaste -appxpackage -Ashcraft -CDPX -commandnotfound -copyable -Corpor -cropandlock -environmentvariables -fileexploreraddons -filelocksmith -findmymouse -fucntion -fuzzingtesting -hostsfileeditor -hotfixes -IDOn -lcl -LIBFUZZER -makepri -mikeclayton -mousehighlighter -mousejump -mousepointer -mouseutils -MVPs -onebranch -PMs -Psr -quickaccent -regsvr -screenruler -sharpfuzz -sourced -stuttery -textextractor -Windowss -XLoc -zonability diff --git a/.github/actions/spell-check/line_forbidden.patterns b/.github/actions/spell-check/line_forbidden.patterns index 24483dd6f5..d66198c855 100644 --- a/.github/actions/spell-check/line_forbidden.patterns +++ b/.github/actions/spell-check/line_forbidden.patterns @@ -8,6 +8,31 @@ # you might not want to check in code where you skip all the other tests. #\bfit\( +# English does not use a hyphen between adverbs and nouns +# https://twitter.com/nyttypos/status/1894815686192685239 +(?:^|\s)[A-Z]?[a-z]+ly-(?=[a-z]{3,})(?:[.,?!]?\s|$) + +# Smart quotes should match +\s’[^.?!‘’]+’[^.?!‘’]+‘[^.?!‘’]+’|\s‘[^.?!‘’]+’[^.?!‘’]+’[^.?!‘’]+’|\s”[^.?!“”]+”[^.?!“”]+“[^.?!“”]+”|\s“[^.?!“”]+”[^.?!“”]+”[^.?!“”]+” + +# Don't use `requires that` + `to be` +# https://twitter.com/nyttypos/status/1894816551435641027 +\brequires that \w+\b[^.]+to be\b + +# A fully parenthetical sentence’s period goes inside the parentheses, not outside. +# https://twitter.com/nyttypos/status/1898844061873639490 +\([A-Z][a-z]{2,}(?: [a-z]+){3,}\)\.\s + +# Complete sentences shouldn't be in the middle of another sentence as a parenthetical. +(? In formal writing and where contractions are frowned upon, use `cannot`. # > It is possible to write `can not`, but you generally find it only as part of some other construction, such as `not only . . . but also.` # - if you encounter such a case, add a pattern for that case to patterns.txt. -\b[Cc]an not\b +\b[Cc]an not\b(?! only\b) + +# Should be `chart` +(?i)\bhelm\b.*\bchard\b # Do not use `(click) here` links # For more information, see: @@ -56,19 +140,49 @@ # * https://heyoka.medium.com/dont-use-click-here-f32f445d1021 (?i)(?:>|\[)(?:(?:click |)here|this(?=\]\([^\)]+:/)|link|(?:read |)more(?!> /etc/apt/sources.list.d/something-distro.list +# ```` +\bapt-key add\b + +# Should be `nearby` +\bnear by\b + # Should probably be a person named `Nick` or the abbreviation `NIC` \bNic\b # Should be `not supposed` \bsupposed not\b +# Should be `Once this` or `On this` or even `One that`. Rarely `One, this` +[?!.] One this\b + # Should probably be `much more` \bmore much\b @@ -153,7 +307,10 @@ \bperform it's\b # Should be `opt-in` -(? below for the` +(?i)\bfind below the\b + +# Should be `then any` unless there's a comparison before the `,` +, than any\b + # Should be `did not exist` \bwere not existent\b @@ -197,9 +419,18 @@ # Should be `nonexistent` \b[Nn]o[nt][- ]existent\b +# Should be `our` +\bspending out time\b + # Should be `@brief` / `@details` / `@param` / `@return` / `@retval` (?:^\s*|(?:\*|//|/*)\s+`)[\\@](?:breif|(?:detail|detials)|(?:params(?!\.)|prama?)|ret(?:uns?)|retvl)\b +# Should be `more than` or `more, then` +\bmore then\b + +# Should be `Pipeline`/`pipeline` +(?:(?<=\b|[A-Z])p|P)ipeLine(?:\b|(?=[A-Z])) + # Should be `preexisting` [Pp]re[- ]existing @@ -215,6 +446,9 @@ # Should be `prerequisite` [Pp]re[- ]requisite +# Should be `QuickTime` +\bQuicktime\b + # Should be `recently changed` or `recent changes` [Rr]ecent changed @@ -224,14 +458,30 @@ # Should be `reentrant` [Rr]e[- ]entrant +# Should be `room for` +\brooms for (?!lease|rent|sale) + +# Should be `socioeconomic` +# https://dictionary.cambridge.org/us/dictionary/english/socioeconomic +socio-economic + # Should be `strong suit` \b(?:my|his|her|their) strong suite\b +# Should probably be `temperatures` unless actually talking about thermal drafts (things birds may fly on) +\bthermals\b + +# Should be `there are` or `they are` (or `they're`) +(?i)\btheir are\b + # Should be `understand` \bunder stand\b -# Should be `URI` or `uri` unless it refers to a person named `Uri` -#(?|".*?") +# Gaelic +Gàidhlig -# #pragma lib -^\s*#pragma comment\(lib, ".*?"\) +Ov_erwrite # languageHashTable "\w+(?:-\w+|)"\s+=\s+@\(".*"\) -# wikipedia -\b\w\w\.wikipedia\.org/wiki/[-\w%.#]+ +# Regular expression with `\b` +\\b(?=[a-z]\S*\{) -# css fonts -\bfont-family:[^;}]+ - -# .github/policies/resourceManagement.yml -pattern: '.*' +# long lorem +L"Lorem.*" # tabs in c# \$"\\t # Hexadecimal character pattern in code -\\x[0-9a-fA-F][0-9a-fA-F] +\\x[0-9a-fA-F]{4} + +fontFamily": ".*" + +D[23]D(?=[A-Z][a-z]) +(?<=[a-z])3D(?=[A-Z]) + +\.monitorId = \{ .*\} + +json::value\(L"\S+" # windows line breaks in strings -\\r\\n +\\r\\n(?=[A-Za-z]) # power shell gallery website \bpowershellgallery.com/[-_a-zA-Z0-9()=./%]* @@ -35,9 +40,22 @@ L?(["']|[-<({>]|\b)[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{10,12}(?:\g{ (?:L"[abAB]+", ){3}L"[abAB]+" -# hit-count: 1 file-count: 1 -# marker to ignore all code on line -^.*/\* #no-spell-check-line \*/.*$ +\. (?: @[-A-Za-z\d]+\b(?!\.[A-Z]),?)+ + +auto deviceId = L".*" +deviceId(?:\.id|) = L".*" + +StringComparer.OrdinalIgnoreCase\) \{.*\} + +# namespaces +\b[a-z]+:: + +"Author": ".+" + +(?:Include|Link)=".*?" + +# You could ignore `xmlns`, but it's probably better to enforce rules about them... +#\s(?:xmlns:[a-z]+(?:[A-Z][a-z]+|)=|[a-z]+(?:[A-Z][a-z]+):(?=[a-z]+=)) # UnitTests \[DataRow\(.*\)\] @@ -50,142 +68,135 @@ L?(["']|[-<({>]|\b)[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{10,12}(?:\g{ # Automatically suggested patterns -# hit-count: 3715 file-count: 992 +# hit-count: 5402 file-count: 1339 # IServiceProvider / isAThing -(?:\b|_)(?:(?:ns|)I|isA)(?=(?:[A-Z][a-z]{2,})+(?:[A-Z\d]|\b)) +(?:(?:\b|_|(?<=[a-z]))[IT]|(?:\b|_)(?:nsI|isA))(?=(?:[A-Z][a-z]{2,})+(?:[A-Z\d]|\b)) -# hit-count: 404 file-count: 42 -# base64 encoded content, possibly wrapped in mime -(?:^|[\s=;:?])[-a-zA-Z=;:/0-9+]{50,}(?:[\s=;:?]|$) +# hit-count: 2073 file-count: 842 +# #includes +^\s*#include\s*(?:<.*?>|".*?") -# hit-count: 402 file-count: 160 +# hit-count: 1639 file-count: 855 +# C# includes +^\s*using [^;]+; + +# hit-count: 1491 file-count: 693 +# microsoft +\b(?:https?://|)(?:(?:(?:blogs|download\.visualstudio|docs|msdn2?|research)\.|)microsoft|blogs\.msdn)\.co(?:m|\.\w\w)/[-_a-zA-Z0-9()=./%]* + +# hit-count: 398 file-count: 133 +# hex digits including css/html color classes: +(?:[\\0][xX]|\\u\{?|[uU]\+|#x?|%23|&H)[0-9_a-fA-FgGrR]*?[a-fA-FgGrR]{2,}[0-9_a-fA-FgGrR]*(?:[uUlL]{0,3}|[iu]\d+)\b + +# hit-count: 339 file-count: 146 # hex runs \b[0-9a-fA-F]{16,}\b -# hit-count: 337 file-count: 110 -# hex digits including css/html color classes: -(?:[\\0][xX]|\\u|[uU]\+|#x?|%23)[0-9_a-fA-FgGrR]*?[a-fA-FgGrR]{2,}[0-9_a-fA-FgGrR]*(?:[uUlL]{0,3}|[iu]\d+)\b - -# hit-count: 311 file-count: 43 -# D2D -D?2D(?!efault) - -# hit-count: 272 file-count: 75 +# hit-count: 253 file-count: 100 # GitHub SHAs (markdown) (?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|) -# hit-count: 146 file-count: 27 +# hit-count: 241 file-count: 37 # version suffix v# (?:(?<=[A-Z]{2})V|(?<=[a-z]{2}|[A-Z]{2})v)\d+(?:\b|(?=[a-zA-Z_])) -# hit-count: 105 file-count: 103 +# hit-count: 141 file-count: 6 +# Contributor / Project +\[[^\]\s]+\]\(https://github\.com/[^)]+\)(?: -(?: [A-Z]\S+)+|)|\[[^\]]+\]\(https://github\.com/(?:[^/\s"]+/?){1,2}\) + +https://github.com/(?:[-\w]+/?){1,2} + +# hit-count: 131 file-count: 125 +# Repeated letters +\b([a-z])\g{-1}{2,}\b + +# hit-count: 99 file-count: 97 # w3 \bw3\.org/[-0-9a-zA-Z/#.]+ -# hit-count: 94 file-count: 6 -# Contributor -\[[^\]]+\]\(https://github\.com/[^/\s"]+/?\) - -RegExp\(([`'"]).*?\g{-1}\)|(?:escapes|regEx):\s*(?:/.*/|([`'"]).*?\g{-1})|return/.*?/ - -# hit-count: 65 file-count: 38 -# regex choice -\(\?:[^)]+\|[^)]+\) - -# hit-count: 37 file-count: 14 +# hit-count: 59 file-count: 11 # Markdown anchor links \(#\S*?[a-zA-Z]\S*?\) -# hit-count: 33 file-count: 5 -# base64 encoded pkcs -\bMII[-a-zA-Z=;:/0-9+]+ - -# hit-count: 28 file-count: 22 +# hit-count: 29 file-count: 23 # stackexchange -- https://stackexchange.com/feeds/sites \b(?:askubuntu|serverfault|stack(?:exchange|overflow)|superuser).com/(?:questions/\w+/[-\w]+|a/) -# hit-count: 14 file-count: 3 -# node packages -(["'])@[^/'" ]+/[^/'" ]+\g{-1} +# hit-count: 24 file-count: 11 +# Library prefix +# e.g., `lib`+`archive`, `lib`+`raw`, `lib`+`unwind` +# (ignores some words that happen to start with `lib`) +(?:\b|_)[Ll]ib(?:re(?=office)|)(?!era[lt]|ero|erty|rar(?:i(?:an|es)|y))(?=[a-z]) -# hit-count: 13 file-count: 1 +# hit-count: 20 file-count: 2 # Intel intrinsics -_mm_(?!dd)\w+ +_mm\d*_(?!dd)\w+ -# hit-count: 11 file-count: 5 -# URL escaped characters -%[0-9A-F][A-F](?=[A-Za-z]) - -# hit-count: 9 file-count: 5 +# hit-count: 15 file-count: 8 # Wikipedia \ben\.wikipedia\.org/wiki/[-\w%.#]+ -# hit-count: 5 file-count: 4 +# hit-count: 14 file-count: 10 # vs devops \bvisualstudio.com(?::443|)/[-\w/?=%&.]* -# hit-count: 5 file-count: 4 -# Alternatively, if you're using check-spelling v0.0.25+, and you would like to _check_ the Non-English content for spelling errors, you can. For information on how to do so, see: -# https://docs.check-spelling.dev/Feature:-Configurable-word-characters.html#unicode -[a-zA-Z]*[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3}[a-zA-ZÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]*|[a-zA-Z]{3,}[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]|[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3,} +# hit-count: 8 file-count: 2 +# copyright +Copyright (?:\([Cc]\)|)(?:[-\d, ]|and)+(?: [A-Z][a-z]+ [A-Z][a-z]+,?)+ -# hit-count: 4 file-count: 4 -# microsoft -\b(?:https?://|)(?:(?:(?:blogs|download\.visualstudio|developer|docs|learn|msdn2?|research)\.|)microsoft|blogs\.msdn)\.co(?:m|\.\w\w)/[-_a-zA-Z0-9()=./%#]* +# hit-count: 8 file-count: 1 +# css fonts +\bfont(?:-family|):[^;}]+ aka\.ms/[a-zA-Z0-9]+ +# hit-count: 8 file-count: 1 +# kubernetes crd patterns +^\s*pattern: .*$ + +# hit-count: 5 file-count: 3 +# URL escaped characters +%[0-9A-F][A-F](?=[A-Za-z]) + # hit-count: 3 file-count: 3 # githubusercontent /[-a-z0-9]+\.githubusercontent\.com/[-a-zA-Z0-9?&=_\/.]* -# hit-count: 3 file-count: 2 -# css url wrappings -\burl\([^)]+\) - -# hit-count: 3 file-count: 1 -# kubernetes crd patterns -^\s*pattern: .*$ - -# hit-count: 3 file-count: 1 -# Lorem -# Update Lorem based on your content (requires `ge` and `w` from https://github.com/jsoref/spelling; and `review` from https://github.com/check-spelling/check-spelling/wiki/Looking-for-items-locally ) -# grep '^[^#].*lorem' .github/actions/spelling/patterns.txt|perl -pne 's/.*i..\?://;s/\).*//' |tr '|' "\n"|sort -f |xargs -n1 ge|perl -pne 's/^[^:]*://'|sort -u|w|sed -e 's/ .*//'|w|review - -# Warning, while `(?i)` is very neat and fancy, if you have some binary files that aren't proper unicode, you might run into: -# ... Operation "substitution (s///)" returns its argument for non-Unicode code point 0x1C19AE (the code point will vary). -# ... You could manually change `(?i)X...` to use `[Xx]...` -# ... or you could add the files to your `excludes` file (a version after 0.0.19 should identify the file path) -(?:(?:\w|\s|[,.])*\b(?i)(?:amet|consectetur|cursus|dolor|eros|ipsum|lacus|libero|ligula|lorem|magna|neque|nulla|suscipit|tempus)\b(?:\w|\s|[,.])*) - -# hit-count: 3 file-count: 1 -# libraries -(?:\b|_)lib(?:re(?=office)|)(?!era[lt]|ero|erty|rar(?:i(?:an|es)|y))(?=[a-z]) +# hit-count: 2 file-count: 2 +# medium +\bmedium\.com/@?[^/\s"]+/[-\w:/*.]+ # hit-count: 2 file-count: 1 # While you could try to match `http://` and `https://` by using `s?` in `https?://`, sometimes there # YouTube url \b(?:(?:www\.|)youtube\.com|youtu.be)/(?:channel/|embed/|user/|playlist\?list=|watch\?v=|v/|)[-a-zA-Z0-9?&=_%]* -# hit-count: 1 file-count: 1 -# GHSA -GHSA(?:-[0-9a-z]{4}){3} - -# hit-count: 1 file-count: 1 +# hit-count: 2 file-count: 1 # GitHub actions \buses:\s+[-\w.]+/[-\w./]+@[-\w.]+ # hit-count: 1 file-count: 1 -# medium -\bmedium\.com/@?[^/\s"]+/[-\w]+ - -# hit-count: 1 file-count: 1 -# sha-... -- uses a fancy capture -(\\?['"]|")[0-9a-f]{40,}\g{-1} +# curl arguments +\b(?:\\n|)curl(?:\.exe|)(?:\s+-[a-zA-Z]{1,2}\b)*(?:\s+-[a-zA-Z]{3,})(?:\s+-[a-zA-Z]+)* # hit-count: 1 file-count: 1 # tar arguments \b(?:\\n|)g?tar(?:\.exe|)(?:(?:\s+--[-a-zA-Z]+|\s+-[a-zA-Z]+|\s[ABGJMOPRSUWZacdfh-pr-xz]+\b)(?:=[^ ]*|))+ +# #pragma lib +^\s*#pragma comment\(lib, ".*?"\) + +# UnitTests +\[DataRow\(.*\)\] + +# AdditionalDependencies +.*< + +# the last line of mimetype="application/x-microsoft.net.object.bytearray.base64" things in .resx files +^\s*[-a-zA-Z=;:/0-9+]*[-a-zA-Z;:/0-9+][-a-zA-Z=;:/0-9+]*=$ + +RegExp\(@?([`'"]).*?\g{-1}\)|(?:escapes|regEx):\s*(?:/.*/|([`'"]).*?\g{-1})|return/.*?/ + # Questionably acceptable forms of `in to` # Personally, I prefer `log into`, but people object # https://www.tprteaching.com/log-into-log-in-to-login/ @@ -194,13 +205,16 @@ GHSA(?:-[0-9a-z]{4}){3} # to opt in \bto opt in\b +# pass(ed|ing) in +\bpass(?:ed|ing) in\b + # acceptable duplicates # ls directory listings [-bcdlpsw](?:[-r][-w][-SsTtx]){3}[\.+*]?\s+\d+\s+\S+\s+\S+\s+[.\d]+(?:[KMGT]|)\s+ # mount \bmount\s+-t\s+(\w+)\s+\g{-1}\b # C types and repeated CSS values -\s(auto|buffalo|center|div|inherit|long|LONG|none|normal|solid|thin|transparent|very)(?: \g{-1})+\s +\s(auto|buffalo|center|div|inherit|long|LONG|none|normal|solid|thin|transparent|very)(?:\s\g{-1})+\s # C enum and struct \b(?:enum|struct)\s+(\w+)\s+\g{-1}\b # go templates @@ -232,9 +246,11 @@ _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING # ignore long runs of a single character: \b([A-Za-z])\g{-1}{3,}\b +# hit-count: 1 file-count: 1 # Amazon -\bamazon\.com/[-\w]+/(?:dp/[0-9A-Z]+|) +\bamazon\.com/[-\w]+/(?:dp/[0-9A-Z]+|)[^"'\s]+ +# hit-count: 3 file-count: 3 # imgur \bimgur\.com/[^.]+ diff --git a/.github/actions/spell-check/reject.txt b/.github/actions/spell-check/reject.txt index 5cc86ef80c..48a5833d12 100644 --- a/.github/actions/spell-check/reject.txt +++ b/.github/actions/spell-check/reject.txt @@ -1,8 +1,17 @@ ^attache$ -^bellow$ +^bellows?$ benefitting occurences? ^dependan.* +^develope$ +^developement$ +^developpe +^Devers?$ +^devex +^devide +^Devinn?[ae] +^devisal +^devisor ^diables?$ ^oer$ Sorce @@ -10,4 +19,5 @@ Sorce ^Teh$ ^untill$ ^untilling$ +^venders?$ ^wether.* diff --git a/.github/workflows/spelling2.yml b/.github/workflows/spelling2.yml index cd2b6d5b0f..a88d620f24 100644 --- a/.github/workflows/spelling2.yml +++ b/.github/workflows/spelling2.yml @@ -105,7 +105,7 @@ jobs: report-timing: 1 warnings: bad-regex,binary-file,deprecated-feature,ignored-expect-variant,large-file,limited-references,no-newline-at-eof,noisy-file,non-alpha-in-dictionary,token-is-substring,unexpected-line-ending,whitespace-in-dictionary,minified-file,unsupported-configuration,no-files-to-check,unclosed-block-ignore-begin,unclosed-block-ignore-end experimental_apply_changes_via_bot: 1 - use_sarif: ${{ (!github.event.pull_request || (github.event.pull_request.head.repo.full_name == github.repository)) && 1 }} + use_sarif: 1 check_extra_dictionaries: "" dictionary_source_prefixes: > { @@ -113,37 +113,28 @@ jobs: } extra_dictionaries: | cspell:software-terms/softwareTerms.txt + cspell:cpp/stdlib-c.txt cspell:cpp/stdlib-cpp.txt cspell:filetypes/filetypes.txt - cspell:cpp/stdlib-c.txt - cspell:lorem-ipsum/dictionary.txt - cspell:python/python/python-lib.txt cspell:php/php.txt - cspell:fullstack/fullstack.txt - cspell:dotnet/dotnet.txt - cspell:swift/swift.txt - cspell:node/node.txt cspell:dart/dart.txt - cspell:django/django.txt - cspell:python/python/python.txt + cspell:dotnet/dotnet.txt cspell:powershell/powershell.txt - cspell:npm/npm.txt - cspell:golang/go.txt - cspell:cpp/compiler-msvc.txt cspell:csharp/csharp.txt - cspell:html/html.txt + cspell:python/python/python-lib.txt + cspell:node/node.txt + cspell:golang/go.txt + cspell:npm/npm.txt + cspell:fullstack/fullstack.txt + cspell:css/css.txt cspell:java/java.txt - cspell:aws/aws.txt cspell:typescript/typescript.txt - cspell:cpp/lang-keywords.txt + cspell:html/html.txt + cspell:r/r.txt + cspell:aws/aws.txt + cspell:cpp/compiler-msvc.txt cspell:python/common/extra.txt cspell:scala/scala.txt - cspell:shell/shell-all-words.txt - cspell:css/css.txt - cspell:r/r.txt - cspell:java/java-terms.txt - cspell:cpp/stdlib-cerrno.txt - cspell:k8s/k8s.txt comment-push: name: Report (Push) diff --git a/.pipelines/v2/templates/job-build-project.yml b/.pipelines/v2/templates/job-build-project.yml index 8d7afc8900..4b8ebe762e 100644 --- a/.pipelines/v2/templates/job-build-project.yml +++ b/.pipelines/v2/templates/job-build-project.yml @@ -472,7 +472,7 @@ jobs: # This saves ~1GiB per architecture. We won't need these later. # Removes: - # - All .pdbs from any static libs .libs (which were only used during linking) + # - All .pdb files from any static libs .libs (which were only used during linking) - pwsh: |- $binDir = '$(Build.SourcesDirectory)' $ImportLibs = Get-ChildItem $binDir -Recurse -File -Filter '*.exp' | ForEach-Object { $_.FullName -Replace "exp$","lib" } diff --git a/COMMUNITY.md b/COMMUNITY.md index 5f9a0a57ea..d145cafd57 100644 --- a/COMMUNITY.md +++ b/COMMUNITY.md @@ -183,9 +183,9 @@ ZoomIt source code was originally implemented by [Sysinternals](https://sysinter - [@cinnamon-msft](https://github.com/cinnamon-msft) - Kayla Cinnamon - Lead - [@craigloewen-msft](https://github.com/craigloewen-msft) - Craig Loewen - Product Manager - [@niels9001](https://github.com/niels9001/) - Niels Laute - Product Manager -- [@dhowett](https://github.com/dhowett) - Dustin Howett - Dev lead -- [@yeelam-gordon](https://github.com/yeelam-gordon) - Gordon Lam - Dev lead -- [@jamrobot](https://github.com/jamrobot) - Jerry Xu - Dev lead +- [@dhowett](https://github.com/dhowett) - Dustin Howett - Dev Lead +- [@yeelam-gordon](https://github.com/yeelam-gordon) - Gordon Lam - Dev Lead +- [@jamrobot](https://github.com/jamrobot) - Jerry Xu - Dev Lead - [@lei9444](https://github.com/lei9444) - Leilei Zhang - Dev - [@shuaiyuanxx](https://github.com/shuaiyuanxx) - Shawn Yuan - Dev - [@moooyo](https://github.com/moooyo) - Yu Leng - Dev @@ -225,4 +225,4 @@ ZoomIt source code was originally implemented by [Sysinternals](https://sysinter - [@donlaci](https://github.com/donlaci) - Laszlo Nemeth - Dev - [@SeraphimaZykova](https://github.com/SeraphimaZykova) - Seraphima Zykova - Dev - [@stefansjfw](https://github.com/stefansjfw) - Stefan Markovic - Dev -- [@jaimecbernardo](https://github.com/jaimecbernardo) - Jaime Bernardo - Dev lead +- [@jaimecbernardo](https://github.com/jaimecbernardo) - Jaime Bernardo - Dev Lead diff --git a/Directory.Build.props b/Directory.Build.props index 02a848c87e..4184a8f2a3 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -47,7 +47,7 @@ - + @@ -70,7 +70,7 @@ - + @@ -137,7 +137,7 @@ ItemsSource="{x:Bind CurrentPageViewModel.StatusMessages, Mode=OneWay}" Layout="{StaticResource VerticalStackLayout}"> - + diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/SearchBar.xaml.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/SearchBar.xaml.cs index c868e3dd5e..262401710d 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/SearchBar.xaml.cs +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/SearchBar.xaml.cs @@ -244,7 +244,7 @@ public sealed partial class SearchBar : UserControl, _debounceTimer.Debounce( () => { - // Actually plumb Filtering to the viewmodel + // Actually plumb Filtering to the view model if (CurrentPageViewModel != null) { CurrentPageViewModel.Filter = FilterBox.Text; @@ -282,7 +282,7 @@ public sealed partial class SearchBar : UserControl, { // GH #38712: // The ListPage will notify us of the `InitialSearchText` when - // we first load the viewmodel. We can use that as an + // we first load the view model. We can use that as an // opportunity to immediately select the search text. That lets // the user start typing a new search without manually // selecting the old one. diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/Tag.xaml b/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/Tag.xaml index c006688bc1..aec0bb380e 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/Tag.xaml +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/Tag.xaml @@ -1,4 +1,4 @@ - + @@ -35,13 +35,13 @@ MarkdownTemplate="{StaticResource NestedMarkdownContentTemplate}" TreeTemplate="{StaticResource TreeContentTemplate}" /> - + - + - + - + - + @@ -27,7 +27,7 @@ EmptyValue="Collapsed" NotEmptyValue="Visible" /> - + - + + + @@ -65,7 +65,7 @@ - + @@ -28,7 +28,7 @@ - + diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Button.xaml b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Button.xaml index 3c091b7ff3..0cca33265e 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Button.xaml +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Button.xaml @@ -1,4 +1,4 @@ - + diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Colors.xaml b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Colors.xaml index 880e9f4eb0..edca3f479c 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Colors.xaml +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Colors.xaml @@ -1,4 +1,4 @@ - + diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Settings.xaml b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Settings.xaml index f145be5483..0413bbe5cb 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Settings.xaml +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/Settings.xaml @@ -1,4 +1,4 @@ - + diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/TextBox.xaml b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/TextBox.xaml index 26e61dda4e..55b43a0c37 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/TextBox.xaml +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Styles/TextBox.xaml @@ -1,4 +1,4 @@ - + + diff --git a/src/modules/cmdpal/doc/command-pal-anatomy/command-palette-anatomy.md b/src/modules/cmdpal/doc/command-pal-anatomy/command-palette-anatomy.md index 878daaa69a..d46c5c8f8e 100644 --- a/src/modules/cmdpal/doc/command-pal-anatomy/command-palette-anatomy.md +++ b/src/modules/cmdpal/doc/command-pal-anatomy/command-palette-anatomy.md @@ -204,7 +204,7 @@ Let's see what this currently looks like in the Command Palette. First, deploy y ![alt text](image-3.png) -Then, open the Command Palette by pressing `Win+Ctl+.` and search for "Search SSH Keys". You should see the command displayed in the root view of the Command Palette like this: +Then, open the Command Palette by pressing `Win+Ctrl+.` and search for "Search SSH Keys". You should see the command displayed in the root view of the Command Palette like this: ![alt text](image-4.png) diff --git a/src/modules/cmdpal/doc/initial-sdk-spec/initial-sdk-spec.md b/src/modules/cmdpal/doc/initial-sdk-spec/initial-sdk-spec.md index 37c0bc1a24..421ba6b50f 100644 --- a/src/modules/cmdpal/doc/initial-sdk-spec/initial-sdk-spec.md +++ b/src/modules/cmdpal/doc/initial-sdk-spec/initial-sdk-spec.md @@ -266,7 +266,7 @@ As some examples: that once, we don't need to `CreateProcess` just to find that command title. This is a **frozen** extension. * Similarly for something like the GitHub extension - it's got multiple - top-level commands (My issues, Issue search, Repo search, etc), but these + top-level commands (My issues, Issue search, Repo search, etc.), but these top-level commands never change. This is a **frozen** extension. * The "Quick Links" extension has a dynamic list of top-level commands. This is a **fresh** extension.[^3] @@ -392,7 +392,7 @@ command), we need to quickly load that app and get the command for it. 1. If the cached command had an `id`, try to look up the command with `ICommandProvider.GetCommand(id)`, passing the `id`. If that returns an item, we can move on to the next stem - 2. Otherwise (the command wasn't assigned an ID, or `GetCommand` returned + 2. Otherwise, (the command wasn't assigned an ID, or `GetCommand` returned null): all `TopLevelItems` on that `CommandProvider`. * Search through all the returned commands with the same `id` or `icon/title/subtitle/name`, and return that one. @@ -457,7 +457,7 @@ it be cheap from an engineering standpoint. ### From winget -Winget on the other hand, does allow packages to specify arbitrary tags, and let +WinGet on the other hand, does allow packages to specify arbitrary tags, and let apps query them easily. We can use that as a system to load a list of packages available via winget directly in DevPal. We'll specify a well-known tag that developers can use in their winget package manifest to specify that their @@ -611,7 +611,7 @@ This will create a single command in DevPal that, when selected, will open Hacker News in the user's default web browser. Commands can also be `Page`s, which represent additional "nested" pages within -DevPal. When the user selects an command that implements `IPage`, DevPal will +DevPal. When the user selects a command that implements `IPage`, DevPal will navigate to a page for that command, rather than calling `Invoke` on it. Skip ahead to [Pages](#Pages) for more information on the different types of pages. @@ -628,7 +628,7 @@ different types depending on where the command is being used: * `IListPage.GetItems` * Sender is the `IListItem` for the list item selected for that command * `ICommandItem.MoreCommands` (context menus) - * Sender is the `IListItem` which the command was attached to for a list page, or + * Sender is the `IListItem` which the command was attached to a list page, or * the `ICommandItem` of the top-level command (if this is a context item on a top level command) * `IContentPage.Commands` * Sender is the `IContentPage` itself @@ -656,7 +656,7 @@ Use cases for each `CommandResultKind`: * `Dismiss` - Close DevPal after the action is executed. All current state is dismissed as well. On the next launch, DevPal will start from the main page with a blank query. - * Ex: An action that opens an application. The Puser doesn't need DevPal + * Ex: An action that opens an application. The user doesn't need DevPal open after the application is opened, nor do they need the query they used to find the action. * `GoHome` - Navigate back to the main page of DevPal, but keep it open. @@ -752,7 +752,7 @@ which the user can quickly filter and search through. Lists can be either "static" or "dynamic": * A **static** list leaves devpal in charge of filtering the list of items, - based on the query the user typed. + based on the query that the user typed. * These are implementations of the default `IListPage`. * In this case, DevPal will use a fuzzy string match over the `Name` of the action, the `Subtitle`, and any `Text` on the `Tag`s. @@ -959,7 +959,7 @@ as the user navigates the list. Consider the Windows Registry command. When the page is initially loaded, it displays only the top-level registry keys (`HKEY_CURRENT_USER`, -`HKEY_LOCAL_MACHINE`, etc). If the user types `HKC`, the command will filter the +`HKEY_LOCAL_MACHINE`, etc.). If the user types `HKC`, the command will filter the results down to just `HKEY_CURRENT_USER`, `HKEY_CLASSES_ROOT` and `HKEY_CURRENT_CONFIG`. However, if the user at this point taps the right-arrow key, DevPall will use the `TextToSuggest` from the `HKEY_CURRENT_USER` @@ -1375,7 +1375,7 @@ app's icon. ![](https://miro.medium.com/v2/resize:fit:720/format:webp/1*Nd5fvJM8LUQ1w3DAWN-pvA.gif) -(However, the buttons in the gif for "Open", "Uninstall", etc, are not part of +(However, the buttons in the gif for "Open", "Uninstall", etc., are not part of the `Details`, they are part of the "more commands" dropdown. **It's a mockup**) + diff --git a/src/modules/colorPicker/UnitTest-ColorPickerUI/Helpers/ColorConverterTest.cs b/src/modules/colorPicker/UnitTest-ColorPickerUI/Helpers/ColorConverterTest.cs index 288ed0f599..fe061862d0 100644 --- a/src/modules/colorPicker/UnitTest-ColorPickerUI/Helpers/ColorConverterTest.cs +++ b/src/modules/colorPicker/UnitTest-ColorPickerUI/Helpers/ColorConverterTest.cs @@ -520,7 +520,7 @@ namespace Microsoft.ColorPicker.UnitTests // echo 0xFF 0xFF 0xFF | transicc -i "*sRGB" -o "*XYZ" -t 3 -d 0 // where "0xFF 0xFF 0xFF" are filled in with the hexadecimal red/green/blue values; // "-t 3" means using absolute colorimetric intent, in other words, disabling white point scaling; - // "-d 0" means disabling chromatic adaptation, otherwise it will output CIEXYZ-D50 instead of D65. + // "-d 0" means disabling chromatic adaptation; otherwise, it will output CIEXYZ-D50 instead of D65. // // If we have the same results as the reference output listed below, it means our algorithm is accurate. [TestMethod] diff --git a/src/modules/fancyzones/FancyZonesLib/WindowKeyboardSnap.cpp b/src/modules/fancyzones/FancyZonesLib/WindowKeyboardSnap.cpp index 1ebab80f98..f982d5deea 100644 --- a/src/modules/fancyzones/FancyZonesLib/WindowKeyboardSnap.cpp +++ b/src/modules/fancyzones/FancyZonesLib/WindowKeyboardSnap.cpp @@ -474,7 +474,7 @@ bool WindowKeyboardSnap::Extend(HWND window, RECT windowRect, DWORD vkCode, Work } else { - auto deletethis = m_extendData.windowInitialIndexSet; + auto deleteThis = m_extendData.windowInitialIndexSet; m_extendData.windowFinalIndex = targetZone; resultIndexSet = layout->GetCombinedZoneRange(m_extendData.windowInitialIndexSet, { targetZone }); } diff --git a/src/modules/fancyzones/FancyZonesTests/UnitTests/AppZoneHistoryTests.Spec.cpp b/src/modules/fancyzones/FancyZonesTests/UnitTests/AppZoneHistoryTests.Spec.cpp index c3eea23236..9b2b2b0503 100644 --- a/src/modules/fancyzones/FancyZonesTests/UnitTests/AppZoneHistoryTests.Spec.cpp +++ b/src/modules/fancyzones/FancyZonesTests/UnitTests/AppZoneHistoryTests.Spec.cpp @@ -233,7 +233,7 @@ namespace FancyZonesUnitTests Assert::IsFalse(AppZoneHistory::instance().SetAppLastZones(window, workAreaId, layoutId, { expectedZoneIndex })); } - TEST_METHOD (AppLastdeviceIdTest) + TEST_METHOD (AppLastDeviceIdTest) { const auto layoutId = FancyZonesUtils::GuidFromString(L"{2FEC41DA-3A0B-4E31-9CE1-9473C65D99F2}").value(); const FancyZonesDataTypes::WorkAreaId workAreaId1{ diff --git a/src/modules/fancyzones/editor/FancyZonesEditor/Properties/Resources.resx b/src/modules/fancyzones/editor/FancyZonesEditor/Properties/Resources.resx index c93e4ca459..079382baa9 100644 --- a/src/modules/fancyzones/editor/FancyZonesEditor/Properties/Resources.resx +++ b/src/modules/fancyzones/editor/FancyZonesEditor/Properties/Resources.resx @@ -359,7 +359,7 @@ Merge/Delete: - Title for concept behind Merging two zones together or removing an zone + Title for concept behind Merging two zones together or removing a zone Keyboard navigation: diff --git a/src/modules/interface/powertoy_module_interface.h b/src/modules/interface/powertoy_module_interface.h index aa7560b144..b569552659 100644 --- a/src/modules/interface/powertoy_module_interface.h +++ b/src/modules/interface/powertoy_module_interface.h @@ -16,7 +16,7 @@ On the received object, the runner will call: - get_key() to get the non localized ID of the PowerToy, - enable() to initialize the PowerToy. - - get_hotkeys() to register the hotkeys the PowerToy uses. + - get_hotkeys() to register the hotkeys that the PowerToy uses. While running, the runner might call the following methods between create_powertoy() and destroy(): diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.cpp b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.cpp index 1874899c1b..a3ddf5c022 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.cpp +++ b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.cpp @@ -49,7 +49,7 @@ namespace EditorHelpers return numberOfSameType > 1; } - // Function to return true if the shortcut is valid. A valid shortcut has atleast one modifier, as well as an action key + // Function to return true if the shortcut is valid. A valid shortcut has at least one modifier, as well as an action key bool IsValidShortcut(Shortcut shortcut) { if (shortcut.operationType == Shortcut::OperationType::RunProgram && shortcut.runProgramFilePath.length() > 0) diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.h b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.h index 5d6647e88c..f2731d1b37 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.h +++ b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/EditorHelpers.h @@ -11,7 +11,7 @@ namespace EditorHelpers // Function to check if a modifier has been repeated in the previous drop downs bool CheckRepeatedModifier(const std::vector& currentKeys, int selectedKeyCodes); - // Function to return true if the shortcut is valid. A valid shortcut has atleast one modifier, as well as an action key + // Function to return true if the shortcut is valid. A valid shortcut has at least one modifier, as well as an action key bool IsValidShortcut(Shortcut shortcut); // Function to check if the two shortcuts are equal or cover the same set of keys. Return value depends on type of overlap diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDropDownControl.cpp b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDropDownControl.cpp index 5eb65e3266..13dbc7999c 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDropDownControl.cpp +++ b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/KeyDropDownControl.cpp @@ -314,7 +314,7 @@ void KeyDropDownControl::SetSelectionHandler(StackPanel& table, StackPanel row, } } - // If the user searches for a key the selection handler gets invoked however if they click away it reverts back to the previous state. This can result in dangling references to added drop downs which were then reset. + // If the user searches for a key, the selection handler gets invoked; however if they click away it reverts back to the previous state. This can result in dangling references to added drop downs which were then reset. // We handle this by removing the drop down if it no longer a child of the parent for (long long i = keyDropDownControlObjects.size() - 1; i >= 0; i--) { diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp index 41e23f36d8..58960a52ed 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp +++ b/src/modules/keyboardmanager/KeyboardManagerEditorLibrary/ShortcutControl.cpp @@ -472,9 +472,9 @@ ShortcutControl& ShortcutControl::AddNewShortcutControlRow(StackPanel& parent, s deleteShortcut.SetValue(Automation::AutomationProperties::NameProperty(), box_value(GET_RESOURCE_STRING(IDS_DELETE_REMAPPING_BUTTON))); // Add tooltip for delete button which would appear on hover - ToolTip deleteShortcuttoolTip; - deleteShortcuttoolTip.Content(box_value(GET_RESOURCE_STRING(IDS_DELETE_REMAPPING_BUTTON))); - ToolTipService::SetToolTip(deleteShortcut, deleteShortcuttoolTip); + ToolTip deleteShortcutToolTip; + deleteShortcutToolTip.Content(box_value(GET_RESOURCE_STRING(IDS_DELETE_REMAPPING_BUTTON))); + ToolTipService::SetToolTip(deleteShortcut, deleteShortcutToolTip); StackPanel deleteShortcutContainer = StackPanel(); deleteShortcutContainer.Name(L"deleteShortcutContainer"); diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorTest/BufferValidationTests.cpp b/src/modules/keyboardmanager/KeyboardManagerEditorTest/BufferValidationTests.cpp index fb7265e32b..9a2d36a5ac 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorTest/BufferValidationTests.cpp +++ b/src/modules/keyboardmanager/KeyboardManagerEditorTest/BufferValidationTests.cpp @@ -392,7 +392,7 @@ namespace RemappingUITests }); } - // Test if the ValidateShortcutBufferElement method returns no error and no drop down action is required on setting last drop down to an action key on a column with atleast two drop downs + // Test if the ValidateShortcutBufferElement method returns no error and no drop down action is required on setting last drop down to an action key on a column with at least two drop downs TEST_METHOD (ValidateShortcutBufferElement_ShouldReturnNoErrorAndNoAction_OnSettingLastDropDownToActionKeyOnAColumnWithAtleastTwoDropDowns) { std::vector testCases; diff --git a/src/modules/keyboardmanager/KeyboardManagerEditorUI/MainWindow.xaml b/src/modules/keyboardmanager/KeyboardManagerEditorUI/MainWindow.xaml index 44de8cc962..43311b4618 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEditorUI/MainWindow.xaml +++ b/src/modules/keyboardmanager/KeyboardManagerEditorUI/MainWindow.xaml @@ -1,4 +1,4 @@ - + & activatedApp) noexcept { auto resetChordsResults = ResetChordsIfNeeded(data, state, activatedApp); @@ -1684,7 +1684,7 @@ namespace KeyboardEventHandlers return false; } - // Function to a handle an os-level shortcut remap + // Function to handle an os-level shortcut remap intptr_t HandleOSLevelShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept { // Check if the key event was generated by KeyboardManager to avoid remapping events generated by us. @@ -1697,7 +1697,7 @@ namespace KeyboardEventHandlers return 0; } - // Function to a handle an app-specific shortcut remap + // Function to handle an app-specific shortcut remap intptr_t HandleAppSpecificShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept { // Check if the key event was generated by KeyboardManager to avoid remapping events generated by us. diff --git a/src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h b/src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h index 67eeed6977..8797aac311 100644 --- a/src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h +++ b/src/modules/keyboardmanager/KeyboardManagerEngineLibrary/KeyboardEventHandlers.h @@ -17,15 +17,15 @@ namespace KeyboardEventHandlers bool AnyChordStarted; }; - // Function to a handle a single key remap + // Function to handle a single key remap intptr_t HandleSingleKeyRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept; /* This feature has not been enabled (code from proof of concept stage) - // Function to a change a key's behavior from toggle to modifier + // Function to change a key's behavior from toggle to modifier __declspec(dllexport) intptr_t HandleSingleKeyToggleToModEvent(InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept; */ - // Function to a handle a shortcut remap + // Function to handle a shortcut remap intptr_t HandleShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state, const std::optional& activatedApp = std::nullopt) noexcept; // Function to reset chord matching @@ -68,15 +68,15 @@ namespace KeyboardEventHandlers // Function to get just the file name from a fill path std::wstring GetFileNameFromPath(const std::wstring& fullPath); - // Function to a find and show a running program + // Function to find and show a running program bool ShowProgram(DWORD pid, std::wstring programName, bool isNewProcess, bool minimizeIfVisible, int retryCount); bool HideProgram(DWORD pid, std::wstring programName, int retryCount); - // Function to a handle an os-level shortcut remap + // Function to handle an os-level shortcut remap intptr_t HandleOSLevelShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept; - // Function to a handle an app-specific shortcut remap + // Function to handle an app-specific shortcut remap intptr_t HandleAppSpecificShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept; // Function to generate a unicode string in response to a single keypress diff --git a/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/InputInterpreter.cs b/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/InputInterpreter.cs index dbe718e6e7..cbd1d36f4a 100644 --- a/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/InputInterpreter.cs +++ b/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/InputInterpreter.cs @@ -44,7 +44,7 @@ namespace Community.PowerToys.Run.Plugin.UnitConverter } /// - /// Replaces a split input array with shorthand feet/inch notation (1', 1'2" etc) to 'x foot in cm'. + /// Replaces a split input array with shorthand feet/inch notation (1', 1'2", etc.) to 'x foot in cm'. /// public static void ShorthandFeetInchHandler(ref string[] split, CultureInfo culture) { diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Folder/Sources/QueryInternalDirectory.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Folder/Sources/QueryInternalDirectory.cs index f1dc64340f..844c3521dd 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Folder/Sources/QueryInternalDirectory.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Folder/Sources/QueryInternalDirectory.cs @@ -101,7 +101,7 @@ namespace Microsoft.Plugin.Folder.Sources if (isRecursive) { - // match everything before and after search term using supported wildcard '*', ie. *searchterm* + // match everything before and after search term using supported wildcard '*', i.e. *searchterm* if (string.IsNullOrEmpty(incompleteName)) { incompleteName = "*"; diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/DriveDetection/RegistryWrapper.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/DriveDetection/RegistryWrapper.cs index a4f4fbcc32..ca194f8a06 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/DriveDetection/RegistryWrapper.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Indexer/DriveDetection/RegistryWrapper.cs @@ -8,7 +8,7 @@ namespace Microsoft.Plugin.Indexer.DriveDetection { public class RegistryWrapper : IRegistryWrapper { - // Given the registrypath and the name of the value, to retrieve the data corresponding to that registry key + // Given the registry path and the name of the value, to retrieve the data corresponding to that registry key public int GetHKLMRegistryValue(string registryLocation, string valueName) { using (RegistryKey regKey = Registry.LocalMachine.OpenSubKey(registryLocation)) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Logger/ProgramLogger.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Logger/ProgramLogger.cs index 75b2ad8941..e3dd484c3a 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Logger/ProgramLogger.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Logger/ProgramLogger.cs @@ -19,7 +19,7 @@ namespace Microsoft.Plugin.Program.Logger internal static class ProgramLogger { /// - /// Logs an warning + /// Logs a warning /// [MethodImpl(MethodImplOptions.Synchronized)] internal static void Warn(string message, Exception ex, Type fullClassName, string loadingProgramPath, [CallerMemberName] string methodName = "", [CallerFilePath] string sourceFilePath = "", [CallerLineNumber] int sourceLineNumber = 0) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs index b5611b793b..b8721d3677 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWPApplication.cs @@ -115,7 +115,7 @@ namespace Microsoft.Plugin.Program.Programs }, }; - // To set the title to always be the displayname of the packaged application + // To set the title to always be the display name of the packaged application result.Title = DisplayName; result.TitleHighlightData = StringMatcher.FuzzySearch(query, Name).MatchData; @@ -596,7 +596,7 @@ namespace Microsoft.Plugin.Program.Programs } else { - // for C:\Windows\MiracastView etc + // for C:\Windows\MiracastView, etc. path = Path.Combine(Package.Location, "Assets", uri); } diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs index 4169a5769b..d16d0e32ca 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs @@ -991,7 +991,7 @@ namespace Microsoft.Plugin.Program.Programs var paths = new HashSet(defaultHashsetSize); var runCommandPaths = new HashSet(defaultHashsetSize); - // Parallelize multiple sources, and priority based on paths which most likely contain .lnks which are formatted + // Parallelize multiple sources, and priority based on paths which most likely contain .lnk files which are formatted var sources = new (bool IsEnabled, Func> GetPaths)[] { (true, () => CustomProgramPaths(settings.ProgramSources, settings.ProgramSuffixes)), diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs index d42e4b991f..5aa3a78e3d 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/PackageRepository.cs @@ -83,7 +83,7 @@ namespace Microsoft.Plugin.Program.Storage // InitializeAppInfo will throw if there is no AppxManifest.xml for the package. // Note there are sometimes multiple packages per product and this doesn't necessarily mean that we haven't found the app. - // eg. "Could not find file 'C:\\Program Files\\WindowsApps\\Microsoft.WindowsTerminalPreview_2020.616.45.0_neutral_~_8wekyb3d8bbwe\\AppxManifest.xml'." + // e.g. "Could not find file 'C:\\Program Files\\WindowsApps\\Microsoft.WindowsTerminalPreview_2020.616.45.0_neutral_~_8wekyb3d8bbwe\\AppxManifest.xml'." catch (System.IO.FileNotFoundException e) { ProgramLogger.Exception(e.Message, e, GetType(), package.InstalledLocation.ToString()); diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs index e43f85bcfd..7fcae9bc95 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Program/Storage/Win32ProgramRepository.cs @@ -100,7 +100,7 @@ namespace Microsoft.Plugin.Program.Storage // fix for https://github.com/microsoft/PowerToys/issues/34391 // the msi installer creates a shortcut, which is detected by the PT Run and ends up in calling this OnAppRenamed method - // the thread needs to be halted for a short time to avoid locking the new shortcut file as we read it, otherwise the lock causes + // the thread needs to be halted for a short time to avoid locking the new shortcut file as we read it; otherwise, the lock causes // in the issue scenario that a warning is popping up during the msi install process. await Task.Delay(OnRenamedEventWaitTime).ConfigureAwait(false); @@ -203,12 +203,12 @@ namespace Microsoft.Plugin.Program.Storage } // When a URL application is deleted, we can no longer get the HashCode directly from the path because the FullPath a Url app is the URL obtained from reading the file - [System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1309:Use ordinal string comparison", Justification = "Using CurrentCultureIgnoreCase since application names could be dependent on currentculture See: https://github.com/microsoft/PowerToys/pull/5847/files#r468245190")] + [System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1309:Use ordinal string comparison", Justification = "Using CurrentCultureIgnoreCase since application names could be dependent on current culture See: https://github.com/microsoft/PowerToys/pull/5847/files#r468245190")] private Win32Program GetAppWithSameNameAndExecutable(string name, string executableName) { foreach (Win32Program app in Items) { - // Using CurrentCultureIgnoreCase since application names could be dependent on currentculture See: https://github.com/microsoft/PowerToys/pull/5847/files#r468245190 + // Using CurrentCultureIgnoreCase since application names could be dependent on current culture See: https://github.com/microsoft/PowerToys/pull/5847/files#r468245190 if (name.Equals(app.Name, StringComparison.CurrentCultureIgnoreCase) && executableName.Equals(app.ExecutableName, StringComparison.CurrentCultureIgnoreCase)) { return app; diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs index 20c05858eb..ba8c245528 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs @@ -97,7 +97,7 @@ namespace Microsoft.Plugin.Shell string cmd = query.Search; if (string.IsNullOrEmpty(cmd)) { - return ResultsFromlHistory(); + return ResultsFromHistory(); } else { @@ -169,7 +169,7 @@ namespace Microsoft.Plugin.Shell return result; } - private List ResultsFromlHistory() + private List ResultsFromHistory() { IEnumerable history = _settings.Count.OrderByDescending(o => o.Value) .Select(m => new Result @@ -446,7 +446,7 @@ namespace Microsoft.Plugin.Shell public List LoadContextMenus(Result selectedResult) { - var resultlist = new List + var resultList = new List { new ContextMenuResult { @@ -478,7 +478,7 @@ namespace Microsoft.Plugin.Shell }, }; - return resultlist; + return resultList; } public void UpdateSettings(PowerLauncherPluginSettings settings) diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ContextMenuHelper.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ContextMenuHelper.cs index ecbe4bfb07..8fc7513da8 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ContextMenuHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ContextMenuHelper.cs @@ -73,7 +73,7 @@ namespace Microsoft.Plugin.WindowWalker.Components /// Method to initiate killing the process of a window /// /// Window data - /// True if the PT Run window should close, otherwise false. + /// True if the PT Run window should close; otherwise, false. private static bool KillProcessCommand(Window window) { // Validate process diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/FuzzyMatching.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/FuzzyMatching.cs index 35d8981262..c761f4986e 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/FuzzyMatching.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/FuzzyMatching.cs @@ -35,7 +35,7 @@ namespace Microsoft.Plugin.WindowWalker.Components text = text.ToLower(CultureInfo.CurrentCulture); // Create a grid to march matches like - // eg. + // e.g. // a b c a d e c f g // a x x // c x x diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/SearchString.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/SearchString.cs index fb54278ff0..2f971a3333 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/SearchString.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/SearchString.cs @@ -8,7 +8,7 @@ namespace Microsoft.Plugin.WindowWalker.Components /// /// A class to represent a search string /// - /// Class was added inorder to be able to attach various context data to + /// Class was added in order to be able to attach various context data to /// a search string internal class SearchString { diff --git a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/Window.cs b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/Window.cs index f660cc3057..cb01d9f59c 100644 --- a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/Window.cs +++ b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/Window.cs @@ -228,7 +228,7 @@ namespace Microsoft.Plugin.WindowWalker.Components { if (!NativeMethods.ShowWindow(Hwnd, ShowWindowCommand.Restore)) { - // ShowWindow doesn't work if the process is running elevated: fallback to SendMessage + // ShowWindow doesn't work if the process is running elevated: fall back to SendMessage _ = NativeMethods.SendMessage(Hwnd, Win32Constants.WM_SYSCOMMAND, Win32Constants.SC_RESTORE); } } diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/CalculateHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/CalculateHelper.cs index e35d706a26..73a1435eed 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/CalculateHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/CalculateHelper.cs @@ -76,7 +76,7 @@ namespace Microsoft.PowerToys.Run.Plugin.Calculator private static string CheckScientificNotation(string input) { /** - * NOTE: By the time the expression gets to us, it's already in English format. + * NOTE: By the time that the expression gets to us, it's already in English format. * * Regex explanation: * (-?(\d+({0}\d*)?)|-?({0}\d+)): Used to capture one of two types: diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.OneNote/Main.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.OneNote/Main.cs index 129350f51c..1237f08cc3 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.OneNote/Main.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.OneNote/Main.cs @@ -103,7 +103,7 @@ namespace Microsoft.PowerToys.Run.Plugin.OneNote return new List(0); } - // If there's cached results for this query, return immediately, otherwise wait for delayedExecution. + // If there's cached results for this query, return immediately; otherwise, wait for delayedExecution. var results = _cache.Get>(query.Search); return results ?? Query(query, false); } @@ -121,7 +121,7 @@ namespace Microsoft.PowerToys.Run.Plugin.OneNote return new List(0); } - // Get results from cache if they already exist for this query, otherwise query OneNote. Results will be cached for 1 day. + // Get results from cache if they already exist for this query; otherwise, query OneNote. Results will be cached for 1 day. var results = _cache.GetOrAdd(query.Search, () => { var pages = OneNoteProvider.FindPages(query.Search); diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry.UnitTest/Helper/RegistryHelperTest.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry.UnitTest/Helper/RegistryHelperTest.cs index 14a8abd37b..359bff8807 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry.UnitTest/Helper/RegistryHelperTest.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry.UnitTest/Helper/RegistryHelperTest.cs @@ -31,7 +31,7 @@ namespace Microsoft.PowerToys.Run.Plugin.Registry.UnitTest.Helper [TestMethod] public void GetRegistryBaseKeyTestMoreThanOneBaseKey() { - var (baseKeyList, _) = RegistryHelper.GetRegistryBaseKey("HKC\\Control Panel\\Accessibility"); /* #no-spell-check-line */ + var (baseKeyList, _) = RegistryHelper.GetRegistryBaseKey("HKC\\Control Panel\\Accessibility"); Assert.IsNotNull(baseKeyList); Assert.IsTrue(baseKeyList.Count() > 1); diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/ContextMenuHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/ContextMenuHelper.cs index aec718d4fd..f6997f26b2 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/ContextMenuHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/ContextMenuHelper.cs @@ -91,7 +91,7 @@ namespace Microsoft.PowerToys.Run.Plugin.Registry.Helper /// Open the Windows registry editor and jump to registry key inside the given key (inside the /// /// The to jump in - /// if the registry editor was successful open, otherwise + /// if the registry editor was successful open; otherwise, internal static bool TryToOpenInRegistryEditor(in RegistryEntry entry) { try @@ -119,7 +119,7 @@ namespace Microsoft.PowerToys.Run.Plugin.Registry.Helper /// Copy the given text to the clipboard /// /// The text to copy to the clipboard - /// The text successful copy to the clipboard, otherwise + /// The text successful copy to the clipboard; otherwise, private static bool TryToCopyToClipBoard(in string text) { try diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/QueryHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/QueryHelper.cs index 1af57a4112..ee59f96fde 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/QueryHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Registry/Helper/QueryHelper.cs @@ -52,7 +52,7 @@ namespace Microsoft.PowerToys.Run.Plugin.Registry.Helper /// The query that could contain parts /// The key part of the query /// The value name part of the query - /// when the query search for a key and a value name, otherwise + /// when the query search for a key and a value name; otherwise, internal static bool GetQueryParts(in string query, out string queryKey, out string queryValueName) { var sanitizedQuery = SanitizeQuery(query); diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/ResultHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/ResultHelper.cs index 594a70a024..055131e2a8 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/ResultHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/ResultHelper.cs @@ -44,7 +44,7 @@ namespace Microsoft.PowerToys.Run.Plugin.TimeDate.Components /// Copy the given text to the clipboard /// /// The text to copy to the clipboard - /// The text successful copy to the clipboard, otherwise + /// The text successful copy to the clipboard; otherwise, /// Code copied from TimeZone plugin internal static bool CopyToClipBoard(in string text) { diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/TimeAndDateHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/TimeAndDateHelper.cs index cb3616b33a..75ffed1958 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/TimeAndDateHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Components/TimeAndDateHelper.cs @@ -159,7 +159,7 @@ namespace Microsoft.PowerToys.Run.Plugin.TimeDate.Components /// String with date/time /// The new object /// Error message shown to the user - /// True on success, otherwise false + /// True on success; otherwise, false internal static bool ParseStringAsDateTime(in string input, out DateTime timestamp, out string inputParsingErrorMsg) { inputParsingErrorMsg = string.Empty; @@ -294,7 +294,7 @@ namespace Microsoft.PowerToys.Run.Plugin.TimeDate.Components /// Test if input is special parsing for Unix time, Unix time in milliseconds, file time, ... /// /// String with date/time - /// True if yes, otherwise false + /// True if yes; otherwise, false internal static bool IsSpecialInputParsing(string input) { return _regexSpecialInputFormats.IsMatch(input); diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Properties/Resources.Designer.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Properties/Resources.Designer.cs index 9ccd4860b7..b3016d9821 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Properties/Resources.Designer.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Properties/Resources.Designer.cs @@ -466,7 +466,7 @@ namespace Microsoft.PowerToys.Run.Plugin.TimeDate.Properties { } /// - /// Looks up a localized string similar to for; and; nor; but; or; so. + /// Looks up a localized string similar to "for; and; nor; but; or; so". /// internal static string Microsoft_plugin_timedate_Search_ConjunctionList { get { diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ContextMenuHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ContextMenuHelper.cs index 447f78d7fa..b9ee4b9cc3 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ContextMenuHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ContextMenuHelper.cs @@ -53,7 +53,7 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings.Helper /// Copy the given text to the clipboard /// /// The text to copy to the clipboard - /// The text successful copy to the clipboard, otherwise + /// The text successful copy to the clipboard; otherwise, private static bool TryToCopyToClipBoard(in string text) { try diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ResultHelper.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ResultHelper.cs index d4774fbd9a..1852a7f1b8 100644 --- a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ResultHelper.cs +++ b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.WindowsSettings/Helper/ResultHelper.cs @@ -104,7 +104,7 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings.Helper /// Open the settings page of the given . /// /// The that contain the information to open the setting on command level. - /// if the settings could be opened, otherwise . + /// if the settings could be opened; otherwise, . private static bool DoOpenSettingsAction(WindowsSetting entry) { ProcessStartInfo processStartInfo; diff --git a/src/modules/launcher/PowerLauncher/Helper/EnvironmentHelper.cs b/src/modules/launcher/PowerLauncher/Helper/EnvironmentHelper.cs index 378027040c..1d8f983283 100644 --- a/src/modules/launcher/PowerLauncher/Helper/EnvironmentHelper.cs +++ b/src/modules/launcher/PowerLauncher/Helper/EnvironmentHelper.cs @@ -15,7 +15,7 @@ using Stopwatch = Wox.Infrastructure.Stopwatch; namespace PowerLauncher.Helper { /// - /// On Windows operating system the name of environment variables is case-insensitive. This means if we have a user and machine variable with differences in their name casing (eg. test vs Test), the name casing from machine level is used and won't be overwritten by the user var. + /// On Windows operating system the name of environment variables is case-insensitive. This means if we have a user and machine variable with differences in their name casing (e.g. test vs Test), the name casing from machine level is used and won't be overwritten by the user var. /// Example for Window's behavior: test=ValueMachine (Machine level) + TEST=ValueUser (User level) => test=ValueUser (merged) /// To get the same behavior we use "StringComparer.OrdinalIgnoreCase" as compare property for the HashSet and Dictionaries where we merge machine and user variable names. /// diff --git a/src/modules/launcher/PowerLauncher/MainWindow.xaml.cs b/src/modules/launcher/PowerLauncher/MainWindow.xaml.cs index eaade8972f..b0a125a949 100644 --- a/src/modules/launcher/PowerLauncher/MainWindow.xaml.cs +++ b/src/modules/launcher/PowerLauncher/MainWindow.xaml.cs @@ -329,7 +329,7 @@ namespace PowerLauncher var result = ((FrameworkElement)e.OriginalSource).DataContext; if (result != null) { - // This may be null if the tapped item was one of the context buttons (run as admin etc). + // This may be null if the tapped item was one of the context buttons (run as admin, etc.). if (result is ResultViewModel resultVM) { _viewModel.Results.SelectedItem = resultVM; diff --git a/src/modules/launcher/PowerLauncher/ResultList.xaml b/src/modules/launcher/PowerLauncher/ResultList.xaml index 91523185d9..f2629bb2d7 100644 --- a/src/modules/launcher/PowerLauncher/ResultList.xaml +++ b/src/modules/launcher/PowerLauncher/ResultList.xaml @@ -8,7 +8,7 @@ xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:p="clr-namespace:PowerLauncher.Properties" xmlns:ui="http://schemas.lepo.co/wpfui/2022/xaml" - xmlns:viewmodel="clr-namespace:PowerLauncher.ViewModel" + xmlns:viewModel="clr-namespace:PowerLauncher.ViewModel" d:DesignHeight="300" d:DesignWidth="720" mc:Ignorable="d"> @@ -119,13 +119,13 @@ FontSize="{DynamicResource TitleFontSize}" IsHitTestVisible="False" TextTrimming="CharacterEllipsis"> - + - + /// Triggers the action on the selected context button /// - /// False if there is nothing selected, otherwise true + /// False if there is nothing selected; otherwise, true public bool ExecuteSelectedContextButton() { if (HasSelectedContextButton()) diff --git a/src/modules/launcher/Wox.Infrastructure/Image/WindowsThumbnailProvider.cs b/src/modules/launcher/Wox.Infrastructure/Image/WindowsThumbnailProvider.cs index e5cc42cc7c..ef36af04bc 100644 --- a/src/modules/launcher/Wox.Infrastructure/Image/WindowsThumbnailProvider.cs +++ b/src/modules/launcher/Wox.Infrastructure/Image/WindowsThumbnailProvider.cs @@ -255,7 +255,7 @@ namespace Wox.Infrastructure.Image Log.Exception("Got an exception while trying to detect Adobe Reader / Adobe Acrobat Pro as PDF thumbnail provider. To prevent PT Run from a Dispatcher crash, we report that Adobe Reader / Adobe Acrobat Pro is used and show only the PDF icon in the results.", ex, MethodBase.GetCurrentMethod().DeclaringType); } - // If we fail to detect it, we return that Adobe is used. Otherwise we could run into the Dispatcher crash. + // If we fail to detect it, we return that Adobe is used. Otherwise, we could run into the Dispatcher crash. // (This only results in showing the icon instead of a thumbnail. It has no other functional impact.) return true; } diff --git a/src/modules/launcher/Wox.Infrastructure/Storage/ListRepository`1.cs b/src/modules/launcher/Wox.Infrastructure/Storage/ListRepository`1.cs index 5003fd8b63..1867f3b01e 100644 --- a/src/modules/launcher/Wox.Infrastructure/Storage/ListRepository`1.cs +++ b/src/modules/launcher/Wox.Infrastructure/Storage/ListRepository`1.cs @@ -14,7 +14,7 @@ namespace Wox.Infrastructure.Storage { /// /// The intent of this class is to provide a basic subset of 'list' like operations, without exposing callers to the internal representation - /// of the data structure. Currently this is implemented as a list for it's simplicity. + /// of the data structure. Currently this is implemented as a list for its simplicity. /// /// typeof public class ListRepository : IRepository, IEnumerable diff --git a/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs b/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs index 986ce8528f..04608be23a 100644 --- a/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs +++ b/src/modules/launcher/Wox.Infrastructure/StringMatcher.cs @@ -272,7 +272,7 @@ namespace Wox.Infrastructure // while the score is lower if they are more spread out // The length of the match is assigned a larger weight factor. - // I.e. the length is more important than where in the string a match is found. + // I.e. the length is more important than the location where a match is found. const int matchLenWeightFactor = 2; var score = 100 * (query.Length + 1) * matchLenWeightFactor / ((1 + firstIndex) + (matchLenWeightFactor * (matchLen + 1))); diff --git a/src/modules/launcher/Wox.Plugin/Common/VirtualDesktop/VirtualDesktopHelper.cs b/src/modules/launcher/Wox.Plugin/Common/VirtualDesktop/VirtualDesktopHelper.cs index 7770488551..50add849da 100644 --- a/src/modules/launcher/Wox.Plugin/Common/VirtualDesktop/VirtualDesktopHelper.cs +++ b/src/modules/launcher/Wox.Plugin/Common/VirtualDesktop/VirtualDesktopHelper.cs @@ -104,7 +104,7 @@ namespace Wox.Plugin.Common.VirtualDesktop.Helper byte[] allDeskValue = (byte[])virtualDesktopKey.GetValue("VirtualDesktopIDs", null); if (allDeskValue != null) { - // We clear only, if we can read from registry. Otherwise we keep the existing values. + // We clear only, if we can read from registry. Otherwise, we keep the existing values. _availableDesktops.Clear(); // Each guid has a length of 16 elements @@ -135,7 +135,7 @@ namespace Wox.Plugin.Common.VirtualDesktop.Helper else { // The registry value is missing when the user hasn't switched the desktop at least one time before reading the registry. In this case we can set it to desktop one. - // We can only set it to desktop one, if we have at least one desktop in the desktops list. Otherwise we keep the existing value. + // We can only set it to desktop one, if we have at least one desktop in the desktops list. Otherwise, we keep the existing value. Log.Debug("VirtualDesktopHelper.UpdateDesktopList() failed to read the id for the current desktop form registry.", typeof(VirtualDesktopHelper)); _currentDesktop = _availableDesktops.Count >= 1 ? _availableDesktops[0] : _currentDesktop; } @@ -237,7 +237,7 @@ namespace Wox.Plugin.Common.VirtualDesktop.Helper /// Returns the number (position) of a desktop. /// /// The guid of the desktop. - /// Number of the desktop, if found. Otherwise a value of zero. + /// Number of the desktop, if found. Otherwise, a value of zero. public int GetDesktopNumber(Guid desktop) { if (_desktopListAutoUpdate) diff --git a/src/modules/launcher/Wox.Plugin/Common/Win32/NativeMethods.cs b/src/modules/launcher/Wox.Plugin/Common/Win32/NativeMethods.cs index e3442ae025..28873d67f0 100644 --- a/src/modules/launcher/Wox.Plugin/Common/Win32/NativeMethods.cs +++ b/src/modules/launcher/Wox.Plugin/Common/Win32/NativeMethods.cs @@ -1048,7 +1048,7 @@ namespace Wox.Plugin.Common.Win32 /// /// The window has generic "right-aligned" properties. This depends on the window class. This style has - /// an effect only if the shell language supports reading-order alignment, otherwise is ignored. + /// an effect only if the shell language supports reading-order alignment; otherwise, is ignored. /// WS_EX_RIGHT = 0x1000, diff --git a/src/modules/launcher/Wox.Plugin/Query.cs b/src/modules/launcher/Wox.Plugin/Query.cs index c8bc934508..450e83faa0 100644 --- a/src/modules/launcher/Wox.Plugin/Query.cs +++ b/src/modules/launcher/Wox.Plugin/Query.cs @@ -60,7 +60,7 @@ namespace Wox.Plugin /// /// Gets search part of a query. - /// This will not include action keyword if exclusive plugin gets it, otherwise it should be same as RawQuery. + /// This will not include action keyword if exclusive plugin gets it; otherwise, it should be same as RawQuery. /// Since we allow user to switch a exclusive plugin to generic plugin, /// so this property will always give you the "real" query part of the query /// diff --git a/src/modules/peek/Peek.FilePreviewer/Controls/DriveControl.xaml b/src/modules/peek/Peek.FilePreviewer/Controls/DriveControl.xaml index 979e4780e7..ee53887f7c 100644 --- a/src/modules/peek/Peek.FilePreviewer/Controls/DriveControl.xaml +++ b/src/modules/peek/Peek.FilePreviewer/Controls/DriveControl.xaml @@ -1,4 +1,4 @@ - + + + + - /// Represent if an text box info bar is added for showing message. + /// Represent if a text box info bar is added for showing message. /// private bool _infoBarAdded; diff --git a/src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs b/src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs index c1c72d61aa..1cb007c98a 100644 --- a/src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs +++ b/src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs @@ -29,7 +29,7 @@ namespace Microsoft.PowerToys.PreviewHandler.Monaco private RichTextBox _textBox; /// - /// Represent if an text box info bar is added for showing message. + /// Represent if a text box info bar is added for showing message. /// private bool _infoBarAdded; @@ -364,7 +364,7 @@ namespace Microsoft.PowerToys.PreviewHandler.Monaco DetectionResult result = CharsetDetector.DetectFromFile(filePath); Encoding.RegisterProvider(CodePagesEncodingProvider.Instance); - // Check if the detected encoding is not null, otherwise default to UTF-8 + // Check if the detected encoding is not null; otherwise, default to UTF-8 Encoding encodingToUse = result.Detected?.Encoding ?? Encoding.UTF8; using (StreamReader fileReader = new StreamReader(new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite), encodingToUse)) diff --git a/src/modules/previewpane/QoiPreviewHandler/QoiPreviewHandlerControl.cs b/src/modules/previewpane/QoiPreviewHandler/QoiPreviewHandlerControl.cs index 047a3e614f..2482b501bb 100644 --- a/src/modules/previewpane/QoiPreviewHandler/QoiPreviewHandlerControl.cs +++ b/src/modules/previewpane/QoiPreviewHandler/QoiPreviewHandlerControl.cs @@ -25,7 +25,7 @@ namespace Microsoft.PowerToys.PreviewHandler.Qoi private RichTextBox _textBox; /// - /// Represent if an text box info bar is added for showing message. + /// Represent if a text box info bar is added for showing message. /// private bool _infoBarAdded; diff --git a/src/modules/previewpane/SvgPreviewHandler/SvgPreviewControl.cs b/src/modules/previewpane/SvgPreviewHandler/SvgPreviewControl.cs index 095c985896..26810a19dc 100644 --- a/src/modules/previewpane/SvgPreviewHandler/SvgPreviewControl.cs +++ b/src/modules/previewpane/SvgPreviewHandler/SvgPreviewControl.cs @@ -74,7 +74,7 @@ namespace Microsoft.PowerToys.PreviewHandler.Svg private RichTextBox _textBox; /// - /// Represent if an text box info bar is added for showing message. + /// Represent if a text box info bar is added for showing message. /// private bool _infoBarAdded; diff --git a/src/modules/previewpane/UnitTests-PreviewHandlerCommon/FormHandlerControlTests.cs b/src/modules/previewpane/UnitTests-PreviewHandlerCommon/FormHandlerControlTests.cs index adcf12034f..8bf6e67063 100644 --- a/src/modules/previewpane/UnitTests-PreviewHandlerCommon/FormHandlerControlTests.cs +++ b/src/modules/previewpane/UnitTests-PreviewHandlerCommon/FormHandlerControlTests.cs @@ -146,7 +146,7 @@ namespace PreviewHandlerCommonUnitTests } [TestMethod] - public void FormHandlerControlShouldSetVisibletrueWhenDoPreviewCalled() + public void FormHandlerControlShouldSetVisibleTrueWhenDoPreviewCalled() { // Arrange using (var testFormHandlerControl = new TestFormControl()) diff --git a/src/modules/previewpane/common/Utilities/SvgPreviewHandlerHelper.cs b/src/modules/previewpane/common/Utilities/SvgPreviewHandlerHelper.cs index 180158152c..44fd940b7c 100644 --- a/src/modules/previewpane/common/Utilities/SvgPreviewHandlerHelper.cs +++ b/src/modules/previewpane/common/Utilities/SvgPreviewHandlerHelper.cs @@ -58,7 +58,7 @@ namespace Common.Utilities { foundBlockedElement = true; - // No need to iterate further since we are displaying info bar with condition of atleast one occurrence of blocked element is present. + // No need to iterate further since we are displaying info bar with condition of at least one occurrence of blocked element is present. break; } } diff --git a/src/modules/previewpane/common/cominterop/IPreviewHandlerFrame.cs b/src/modules/previewpane/common/cominterop/IPreviewHandlerFrame.cs index dd80a4edf5..f01f11dd21 100644 --- a/src/modules/previewpane/common/cominterop/IPreviewHandlerFrame.cs +++ b/src/modules/previewpane/common/cominterop/IPreviewHandlerFrame.cs @@ -23,7 +23,7 @@ namespace Common.ComInterlop void GetWindowContext(IntPtr pinfo); /// - /// Directs the host to handle an keyboard shortcut passed from the preview handler. + /// Directs the host to handle a keyboard shortcut passed from the preview handler. /// /// A reference to that corresponds to a keyboard shortcut. /// If the keyboard shortcut is one that the host intends to handle, the host will process it and return S_OK(0); otherwise, it returns S_FALSE(1). diff --git a/src/modules/previewpane/common/controls/FormHandlerControl.cs b/src/modules/previewpane/common/controls/FormHandlerControl.cs index 82779e59a2..ce16d8f1fd 100644 --- a/src/modules/previewpane/common/controls/FormHandlerControl.cs +++ b/src/modules/previewpane/common/controls/FormHandlerControl.cs @@ -17,7 +17,7 @@ namespace Common public abstract class FormHandlerControl : Form, IPreviewHandlerControl { /// - /// Needed to make the form a child window. + /// Needed to make the form into a child window. /// private static int gwlStyle = -16; private static int wsChild = 0x40000000; diff --git a/src/modules/previewpane/powerpreview/powerpreview.base.rc b/src/modules/previewpane/powerpreview/powerpreview.base.rc index 0de3cc578b..e061322154 100644 --- a/src/modules/previewpane/powerpreview/powerpreview.base.rc +++ b/src/modules/previewpane/powerpreview/powerpreview.base.rc @@ -52,9 +52,9 @@ STRINGTABLE BEGIN IDS_EXPLR_ICONS_PREV_STTNGS_GROUP_HEADER_ID L"EXPLR_ICONS_PREV_STTNGS_GROUP_HEADER_ID" IDS_PRVPANE_FILE_PREV_STTNGS_GROUP_HEADER_ID L"PRVPANE_FILE_PREV_STTNGS_GROUP_HEADER_ID" - IDS_PREVPANE_MD_BOOL_TOGGLE_CONTROL L"PREVPANE_MD_BOOL_TOGGLE_CONTROLL_ID" + IDS_PREVPANE_MD_BOOL_TOGGLE_CONTROL L"PREVPANE_MD_BOOL_TOGGLE_CONTROL_ID" IDS_PREVPANE_SVG_BOOL_TOGGLE_CONTROL L"IDS_PREVPANE_SVG_BOOL_TOGGLE_CONTROL" - IDS_EXPLR_SVG_BOOL_TOGGLE_CONTROL L"EXPLR_SVG_BOOL_TOGGLE_CONTROLL" + IDS_EXPLR_SVG_BOOL_TOGGLE_CONTROL L"EXPLR_SVG_BOOL_TOGGLE_CONTROL" END // Non-localizable diff --git a/src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml b/src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml index 95ab0e4331..afe66038a0 100644 --- a/src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml +++ b/src/modules/registrypreview/RegistryPreview/RegistryPreviewXAML/MainWindow.xaml @@ -1,4 +1,4 @@ - - /// Method that re-opens and processes the filename the app already knows about; expected to not be a first time open + /// Method that re-opens and processes the filename that the app already knows about; expected to not be a first time open /// private void RefreshRegistryFile() { @@ -986,7 +986,7 @@ namespace RegistryPreviewUILib /// Ask the user for the file path if it is unknown because of an unsaved file /// /// If not empty always ask for a file path and use the value as name. - /// Returns true if user selected a path, otherwise false + /// Returns true if user selected a path; otherwise, false public bool AskFileName(string fileName) { if (string.IsNullOrEmpty(_appFileName) || !string.IsNullOrEmpty(fileName) ) diff --git a/src/modules/registrypreview/RegistryPreviewUILib/Themes/Generic.xaml b/src/modules/registrypreview/RegistryPreviewUILib/Themes/Generic.xaml index 35011f155b..879cdc9bd6 100644 --- a/src/modules/registrypreview/RegistryPreviewUILib/Themes/Generic.xaml +++ b/src/modules/registrypreview/RegistryPreviewUILib/Themes/Generic.xaml @@ -1,4 +1,4 @@ - + - /// Method GetSettingsBackupAndRestoreDir returns the path the backup and restore location. + /// Method GetSettingsBackupAndRestoreDir returns the path of the backup and restore location. /// /// /// This will return a default location based on user documents if non is set. @@ -959,7 +959,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library if (item.Value.Contains("PowerToys_settings_", StringComparison.OrdinalIgnoreCase)) { - // this is a temp backup and we want to clean based on the time it was created in the temp place, not the time the backup was made. + // this is a temp backup and we want to clean based on the time it was created in the temp place, not the time that the backup was made. var folderCreatedTime = new DirectoryInfo(item.Value).CreationTimeUtc; if (folderCreatedTime > backupTime) diff --git a/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs b/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs index 936c08689e..26d82dbbfe 100644 --- a/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs +++ b/src/settings-ui/Settings.UI.Library/ZoomItProperties.cs @@ -78,7 +78,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library public BoolProperty ShowTrayIcon { get; set; } - public BoolProperty AnimnateZoom { get; set; } + public BoolProperty AnimateZoom { get; set; } public IntProperty ZoominSliderLevel { get; set; } diff --git a/src/settings-ui/Settings.UI.UnitTests/Mocks/IIOProviderMocks.cs b/src/settings-ui/Settings.UI.UnitTests/Mocks/IIOProviderMocks.cs index b5e531d742..f259d3a7f3 100644 --- a/src/settings-ui/Settings.UI.UnitTests/Mocks/IIOProviderMocks.cs +++ b/src/settings-ui/Settings.UI.UnitTests/Mocks/IIOProviderMocks.cs @@ -52,7 +52,7 @@ namespace Microsoft.PowerToys.Settings.UI.UnitTests.Mocks /// This mock is specific to a given module, and is verifiable that the stub file was read. /// /// The path to the stub settings file - /// The substring in the path that identifies the module eg. Microsoft\\PowerToys\\ColorPicker + /// The substring in the path that identifies the module e.g. Microsoft\\PowerToys\\ColorPicker /// Mocked IFile internal static Mock GetMockIOReadWithStubFile(string savePath, Expression> filterExpression) { diff --git a/src/settings-ui/Settings.UI.UnitTests/Mocks/ISettingsUtilsMocks.cs b/src/settings-ui/Settings.UI.UnitTests/Mocks/ISettingsUtilsMocks.cs index c51902f13f..d39aa03353 100644 --- a/src/settings-ui/Settings.UI.UnitTests/Mocks/ISettingsUtilsMocks.cs +++ b/src/settings-ui/Settings.UI.UnitTests/Mocks/ISettingsUtilsMocks.cs @@ -10,7 +10,7 @@ namespace Microsoft.PowerToys.Settings.UI.UnitTests.Mocks { internal static class ISettingsUtilsMocks { - // Stubs out empty values for imageresizersettings and general settings as needed by the imageresizer viewmodel + // Stubs out empty values for imageresizersettings and general settings as needed by the imageresizer view model internal static Mock GetStubSettingsUtils() where T : ISettingsConfig, new() { diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Controls/FlyoutMenuButton/FlyoutMenuButton.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Controls/FlyoutMenuButton/FlyoutMenuButton.xaml index 7cf88ac0f6..50c0e4007c 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Controls/FlyoutMenuButton/FlyoutMenuButton.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Controls/FlyoutMenuButton/FlyoutMenuButton.xaml @@ -1,4 +1,4 @@ - + @@ -60,7 +60,7 @@ - + diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml index fb2cfd8e85..f4a190ab46 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml @@ -8,8 +8,8 @@ xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:tkcontrols="using:CommunityToolkit.WinUI.Controls" xmlns:ui="using:CommunityToolkit.WinUI" - xmlns:viewmodels="using:Microsoft.PowerToys.Settings.UI.ViewModels" - d:DataContext="{d:DesignInstance Type=viewmodels:AwakeViewModel}" + xmlns:viewModels="using:Microsoft.PowerToys.Settings.UI.ViewModels" + d:DataContext="{d:DesignInstance Type=viewModels:AwakeViewModel}" AutomationProperties.LandmarkType="Main" mc:Ignorable="d"> diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/ColorPickerPage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/ColorPickerPage.xaml index 3d95a5c724..5295cf2df4 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/ColorPickerPage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/ColorPickerPage.xaml @@ -9,9 +9,9 @@ xmlns:tkcontrols="using:CommunityToolkit.WinUI.Controls" xmlns:tkconverters="using:CommunityToolkit.WinUI.Converters" xmlns:ui="using:CommunityToolkit.WinUI" - xmlns:viewmodels="using:Microsoft.PowerToys.Settings.UI.ViewModels" + xmlns:viewModels="using:Microsoft.PowerToys.Settings.UI.ViewModels" x:Name="RootPage" - d:DataContext="{d:DesignInstance Type=viewmodels:ColorPickerViewModel}" + d:DataContext="{d:DesignInstance Type=viewModels:ColorPickerViewModel}" AutomationProperties.LandmarkType="Main" mc:Ignorable="d"> diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/DashboardPage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/DashboardPage.xaml index b48ddf66c8..347ea02b0e 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/DashboardPage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/DashboardPage.xaml @@ -9,7 +9,7 @@ xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:tkcontrols="using:CommunityToolkit.WinUI.Controls" xmlns:tkconverters="using:CommunityToolkit.WinUI.Converters" - xmlns:viewmodels="using:Microsoft.PowerToys.Settings.UI.ViewModels" + xmlns:viewModels="using:Microsoft.PowerToys.Settings.UI.ViewModels" AutomationProperties.LandmarkType="Main" DataContext="DashboardViewModel" mc:Ignorable="d"> @@ -60,7 +60,7 @@ - + - +