mir/PowerToys
2
0
Fork 0
mirror of https://github.com/microsoft/PowerToys synced 2025-08-22 01:58:04 +00:00
Code Issues Actions 17 Packages Projects Releases Wiki Activity

[Analyzers][CPP]Turn on warning 4389 (#22082)

Browse Source
This commit is contained in:
sosssego 2022-11-23 16:18:17 +00:00 committed by GitHub
parent b2c8900bae
commit c3ffd17e43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Cpp.Build.props
View File

@ -42,7 +42,7 @@
<ClCompile> <ClCompile>
<PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile> <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
<WarningLevel>Level4</WarningLevel> <WarningLevel>Level4</WarningLevel>
<DisableSpecificWarnings>26800;28251;4389;6387;4458;4505;4515;4459;4702;6031;6248;26451;28182;%(DisableSpecificWarnings)</DisableSpecificWarnings> <DisableSpecificWarnings>26800;28251;6387;4458;4505;4515;4459;4702;6031;6248;26451;28182;%(DisableSpecificWarnings)</DisableSpecificWarnings>
<DisableAnalyzeExternal >true</DisableAnalyzeExternal> <DisableAnalyzeExternal >true</DisableAnalyzeExternal>
<ExternalWarningLevel>TurnOffAllWarnings</ExternalWarningLevel> <ExternalWarningLevel>TurnOffAllWarnings</ExternalWarningLevel>
<ConformanceMode>false</ConformanceMode> <ConformanceMode>false</ConformanceMode>

4
src/modules/fancyzones/FancyZonesLib/FancyZonesData/CustomLayouts.cpp
View File

@ -70,7 +70,7 @@ namespace JsonUtils
json::JsonArray columnsPercentage = infoJson.GetNamedArray(NonLocalizable::CustomLayoutsIds::ColumnsPercentageID); json::JsonArray columnsPercentage = infoJson.GetNamedArray(NonLocalizable::CustomLayoutsIds::ColumnsPercentageID);
json::JsonArray cellChildMap = infoJson.GetNamedArray(NonLocalizable::CustomLayoutsIds::CellChildMapID); json::JsonArray cellChildMap = infoJson.GetNamedArray(NonLocalizable::CustomLayoutsIds::CellChildMapID);
if (rowsPercentage.Size() != info.m_rows || columnsPercentage.Size() != info.m_columns || cellChildMap.Size() != info.m_rows) if (static_cast<int>(rowsPercentage.Size()) != info.m_rows || static_cast<int>(columnsPercentage.Size()) != info.m_columns || static_cast<int>(cellChildMap.Size()) != info.m_rows)
{ {
return std::nullopt; return std::nullopt;
} }
@ -80,7 +80,7 @@ namespace JsonUtils
for (const auto& cellsRow : cellChildMap) for (const auto& cellsRow : cellChildMap)
{ {
const auto cellsArray = cellsRow.GetArray(); const auto cellsArray = cellsRow.GetArray();
if (cellsArray.Size() != info.m_columns) if (static_cast<int>(cellsArray.Size()) != info.m_columns)
{ {
return std::nullopt; return std::nullopt;
} }

4
src/modules/fancyzones/FancyZonesLib/JsonHelpers.cpp
View File

@ -383,7 +383,7 @@ namespace JSONHelpers
json::JsonArray columnsPercentage = infoJson.GetNamedArray(NonLocalizable::ColumnsPercentageStr); json::JsonArray columnsPercentage = infoJson.GetNamedArray(NonLocalizable::ColumnsPercentageStr);
json::JsonArray cellChildMap = infoJson.GetNamedArray(NonLocalizable::CellChildMapStr); json::JsonArray cellChildMap = infoJson.GetNamedArray(NonLocalizable::CellChildMapStr);
if (rowsPercentage.Size() != info.m_rows || columnsPercentage.Size() != info.m_columns || cellChildMap.Size() != info.m_rows) if (static_cast<int>(rowsPercentage.Size()) != info.m_rows || static_cast<int>(columnsPercentage.Size()) != info.m_columns || static_cast<int>(cellChildMap.Size()) != info.m_rows)
{ {
return std::nullopt; return std::nullopt;
} }
@ -393,7 +393,7 @@ namespace JSONHelpers
for (const auto& cellsRow : cellChildMap) for (const auto& cellsRow : cellChildMap)
{ {
const auto cellsArray = cellsRow.GetArray(); const auto cellsArray = cellsRow.GetArray();
if (cellsArray.Size() != info.m_columns) if (static_cast<int>(cellsArray.Size()) != info.m_columns)
{ {
return std::nullopt; return std::nullopt;
} }

2
src/modules/fancyzones/FancyZonesLib/WorkArea.cpp
View File

@ -243,7 +243,7 @@ bool WorkArea::MoveWindowIntoZoneByDirectionAndIndex(HWND window, DWORD vkCode,
ZoneIndex oldId = zoneIndexes[0]; ZoneIndex oldId = zoneIndexes[0];
// We reached the edge // We reached the edge
if ((vkCode == VK_LEFT && oldId == 0) || (vkCode == VK_RIGHT && oldId == numZones - 1)) if ((vkCode == VK_LEFT && oldId == 0) || (vkCode == VK_RIGHT && oldId == static_cast<int64_t>(numZones) - 1))
{ {
if (!cycle) if (!cycle)
{ {

2
src/modules/keyboardmanager/common/Shortcut.cpp
View File

@ -783,7 +783,7 @@ bool Shortcut::IsKeyboardStateClearExceptShortcut(KeyboardManagerInput::InputInt
} }
} }
// If any other key is pressed check if it is the action key // If any other key is pressed check if it is the action key
else if (keyVal != actionKey) else if (keyVal != static_cast<int>(actionKey))
{ {
return false; return false;
} }