From e0a0bbffe527f46e7fd9f3b815c686c66e03325d Mon Sep 17 00:00:00 2001
From: Mike Griese <migrie@microsoft.com>
Date: Thu, 21 Aug 2025 05:06:14 -0500
Subject: [PATCH] CmdPal: Prevent some SearchText bouncing. (#41165)

This stops us from raising a PropChanged(SearchText) in DynamicListPage
when we're the ones to set it.

When we'd raise the PropChanged in response to a `set`, it could cause a
race between CmdPal and the extension. It was totally possible that
CmdPal could call

```
SearchText="foo";
SearchText="fool";
```

and in the extension, we'd raise the PropChanged for each of those, but
then have CmdPal handle those events out-of-order.

This seems to entirely remove all the "jiggling" that I'd notice in the
evil samples from #41158

Closes #38190
---
 .../DynamicListPage.cs                                       | 2 +-
 .../Microsoft.CommandPalette.Extensions.Toolkit/ListPage.cs  | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/DynamicListPage.cs b/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/DynamicListPage.cs
index 2bb5ffa576..ec2602fb56 100644
--- a/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/DynamicListPage.cs
+++ b/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/DynamicListPage.cs
@@ -12,7 +12,7 @@ public abstract class DynamicListPage : ListPage, IDynamicListPage
         set
         {
             var oldSearch = base.SearchText;
-            base.SearchText = value;
+            SetSearchNoUpdate(value);
             UpdateSearchText(oldSearch, value);
         }
     }
diff --git a/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/ListPage.cs b/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/ListPage.cs
index 0eef7b44ee..16992613d8 100644
--- a/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/ListPage.cs
+++ b/src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/ListPage.cs
@@ -105,4 +105,9 @@ public partial class ListPage : Page, IListPage
         {
         }
     }
+
+    protected void SetSearchNoUpdate(string newSearchText)
+    {
+        _searchText = newSearchText;
+    }
 }