From faebd21a2de4deb80442b64bcbafc7a8a0a5f72b Mon Sep 17 00:00:00 2001 From: Niels Laute Date: Thu, 3 Jul 2025 16:20:22 +0200 Subject: [PATCH] [Settings] String updates and minor UX tweaks (#40249) ## Summary of the Pull Request - I asked Copilot nicely to rewrite some of our strings to be inline with the Windows writing style guide and to be less verbose or provide a better explaination. - Since the Sound expander on the Always on Top page had a single setting, turning that into a card. Before: ![image](https://github.com/user-attachments/assets/04ec18f1-06a4-4185-ac50-655070dcf3fc) After: ![image](https://github.com/user-attachments/assets/e5d62e00-5d0a-4a2d-9011-493232689f41) Simplified UI + less XAML for diagnostics data: Before: ![image](https://github.com/user-attachments/assets/c0b0468b-7587-4684-8fbf-bad856e4d30c) After: ![image](https://github.com/user-attachments/assets/185f2ff8-a3b1-49bd-8617-24b2c5a454a2) ## PR Checklist - [ ] **Closes:** #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --------- Co-authored-by: Kai Tao --- .../SettingsXAML/Views/AlwaysOnTopPage.xaml | 13 +- .../SettingsXAML/Views/GeneralPage.xaml | 135 +++++++------ .../Settings.UI/Strings/en-us/Resources.resw | 182 ++++++++---------- 3 files changed, 157 insertions(+), 173 deletions(-) diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml index 66cf570af0..1424b256a3 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml @@ -88,16 +88,9 @@ - - - - - - - + + + diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml index a80094e5a2..51118fea10 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/GeneralPage.xaml @@ -294,7 +294,7 @@ - + - - - - - - - - - - - - - - - - - - - - - -