mirror of
https://github.com/microsoft/PowerToys
synced 2025-08-22 01:58:04 +00:00
6acb793184
What the title says. 😄
Rather than relying on the potentially overloaded `!=` or `==` operators
when checking for null, now we'll use the `is` expression (possibly
combined with the `not` operator) to ensure correct checking. Probably
overkill for many of these classes, but decided to err on the side of
consistency. Would matter more on classes that may be inherited or
extended.
Using `is` and `is not` will provide us a guarantee that no
user-overloaded equality operators (`==`/`!=`) is invoked when a
`expression is null` is evaluated.
In code form, changed all instances of:
```c#
something != null
something == null
```
to:
```c#
something is not null
something is null
```
The one exception was checking null on a `KeyChord`. `KeyChord` is a
struct which is never null so VS will raise an error when trying this
versus just providing a warning when using `keyChord != null`. In
reality, we shouldn't do this check because it can't ever be null. In
the case of a `KeyChord` it **would** be a `KeyChord` equivalent to:
```c#
KeyChord keyChord = new ()
{
Modifiers = 0,
Vkey = 0,
ScanCode = 0
};
```
62 lines
1.8 KiB
C#
62 lines
1.8 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using ManagedCommon;
|
|
using Microsoft.CmdPal.Core.ViewModels;
|
|
using Microsoft.CmdPal.Core.ViewModels.Models;
|
|
using Microsoft.CommandPalette.Extensions;
|
|
|
|
namespace Microsoft.CmdPal.UI.ViewModels;
|
|
|
|
public partial class CommandSettingsViewModel(ICommandSettings? _unsafeSettings, CommandProviderWrapper provider, TaskScheduler mainThread)
|
|
{
|
|
private readonly ExtensionObject<ICommandSettings> _model = new(_unsafeSettings);
|
|
|
|
public ContentPageViewModel? SettingsPage { get; private set; }
|
|
|
|
public bool Initialized { get; private set; }
|
|
|
|
public bool HasSettings =>
|
|
_model.Unsafe is not null && // We have a settings model AND
|
|
(!Initialized || SettingsPage is not null); // we weren't initialized, OR we were, and we do have a settings page
|
|
|
|
private void UnsafeInitializeProperties()
|
|
{
|
|
var model = _model.Unsafe;
|
|
if (model is null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (model.SettingsPage is not null)
|
|
{
|
|
SettingsPage = new CommandPaletteContentPageViewModel(model.SettingsPage, mainThread, provider.ExtensionHost);
|
|
SettingsPage.InitializeProperties();
|
|
}
|
|
}
|
|
|
|
public void SafeInitializeProperties()
|
|
{
|
|
try
|
|
{
|
|
UnsafeInitializeProperties();
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Logger.LogError($"Failed to load settings page", ex: ex);
|
|
}
|
|
|
|
Initialized = true;
|
|
}
|
|
|
|
public void DoOnUiThread(Action action)
|
|
{
|
|
Task.Factory.StartNew(
|
|
action,
|
|
CancellationToken.None,
|
|
TaskCreationOptions.None,
|
|
mainThread);
|
|
}
|
|
}
|