mirror of
https://github.com/microsoft/PowerToys
synced 2025-08-22 01:58:04 +00:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request ## Root Cause WiX-based registration creates persistent Shell Extension entries that: 1. Load DLLs even when the module is disabled 2. Cause cross-OS version conflicts (Win11 loading Win10 extensions) ## Changes Made 1. Removed static Shell Extension registration from PowerToys installer 2. Modified modules to register Shell Extensions during Runner startup ### Modified Modules: - **PowerRename** (`src/modules/powerrename/dll/dllmain.cpp`) - **NewPlus** (`src/modules/NewPlus/NewShellExtensionContextMenu/powertoys_module.cpp`) - **ImageResizer** (`src/modules/imageresizer/dll/dllmain.cpp`) - **FileLocksmith** (`src/modules/FileLocksmith/FileLocksmithExt/PowerToysModule.cpp`) ## Known Migration Issue **Machine-level installer registry residue**: win10 with machine-level installers may have residual Shell Extension registry entries that persist with this change. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #40036 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed ## AI Summary This pull request refactors how shell extension registry keys are managed during installation and uninstallation for several PowerToys modules. The main change is moving registry key cleanup logic for context menu shell extensions (ImageResizer, FileLocksmith, PowerRename, NewPlus) from static installer definitions to new custom uninstall actions, ensuring more reliable removal and future extensibility. **Installer and Uninstall Refactoring** * Added new custom actions (`CleanImageResizerRuntimeRegistryCA`, `CleanFileLocksmithRuntimeRegistryCA`, `CleanPowerRenameRuntimeRegistryCA`, `CleanNewPlusRuntimeRegistryCA`) to programmatically clean up registry keys for each shell extension during uninstall, implemented in `CustomAction.cpp` and exported in `CustomAction.def`. [[1]](diffhunk://#diff-c502a81cdf8afa7a38f0f462709abcdbdfcc44beaa6227a1e64a26566c7e8876R1156-R1262) [[2]](diffhunk://#diff-f941d599be5fe41667eda00338af694c0f2e65709d497a66487402f13e408200R31-R34) * Registered these custom actions in `Product.wxs` and ensured they run before file removal during uninstall. [[1]](diffhunk://#diff-668b4388b55bb934d7ceccbfdd172f69257c9c607ca19cb9752d4a4940b69886R179-R190) [[2]](diffhunk://#diff-668b4388b55bb934d7ceccbfdd172f69257c9c607ca19cb9752d4a4940b69886R454-R482) **Removal of Static Registry Key Definitions** * Removed static registry key and component definitions for context menu shell extensions from their respective installer `.wxs` files (`FileLocksmith.wxs`, `ImageResizer.wxs`, `PowerRename.wxs`, `NewPlus.wxs`), relying on custom actions for cleanup instead. [[1]](diffhunk://#diff-7cf9797f8cb6609049763b3b830f6c4a7a02ba5705eb090f7e06fb9c270ca74fL17-L31) [[2]](diffhunk://#diff-7cf9797f8cb6609049763b3b830f6c4a7a02ba5705eb090f7e06fb9c270ca74fL41) [[3]](diffhunk://#diff-c6d00805ce9de0eb3f4d42874dccac17be62f36c35d57e8f863b928b5f955d3aL19-L83) [[4]](diffhunk://#diff-c6d00805ce9de0eb3f4d42874dccac17be62f36c35d57e8f863b928b5f955d3aL93) [[5]](diffhunk://#diff-d0d69eff3f2d7982679465972b7d3c46dd8006314fb28f0e3a2371e2d5ccedb0L21-L33) [[6]](diffhunk://#diff-d0d69eff3f2d7982679465972b7d3c46dd8006314fb28f0e3a2371e2d5ccedb0L43) [[7]](diffhunk://#diff-4fd109f66b896577cad2860a829617ca902b33551afaaa8840372035ade2d3f3L17-L32) [[8]](diffhunk://#diff-4fd109f66b896577cad2860a829617ca902b33551afaaa8840372035ade2d3f3L42) **Project File Update** * Added `shell_ext_registration.h` to the solution file, possibly for future shell extension registration logic. These changes improve uninstall reliability and centralize registry cleanup logic, making future maintenance and extension of shell extension registration much simpler. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
173 lines
4.7 KiB
C++
173 lines
4.7 KiB
C++
#include "pch.h"
|
|
|
|
#include <filesystem>
|
|
#include <string>
|
|
|
|
#include <winrt/Windows.Data.Json.h>
|
|
|
|
#include <common/SettingsAPI/settings_objects.h>
|
|
#include <common/utils/gpo.h>
|
|
#include <common/utils/process_path.h>
|
|
#include <common/utils/resources.h>
|
|
#include <interface/powertoy_module_interface.h>
|
|
|
|
#include "constants.h"
|
|
#include "settings.h"
|
|
#include "trace.h"
|
|
#include "new_utilities.h"
|
|
#include "Generated Files/resource.h"
|
|
#include "RuntimeRegistration.h"
|
|
|
|
// Note: Settings are managed via Settings and UI Settings
|
|
class NewModule : public PowertoyModuleIface
|
|
{
|
|
public:
|
|
NewModule()
|
|
{
|
|
init_settings();
|
|
}
|
|
|
|
virtual const wchar_t* get_name() override
|
|
{
|
|
static const std::wstring localized_context_menu_item =
|
|
GET_RESOURCE_STRING_FALLBACK(IDS_CONTEXT_MENU_ITEM_NEW, L"New+");
|
|
|
|
return localized_context_menu_item.c_str();
|
|
}
|
|
|
|
virtual const wchar_t* get_key() override
|
|
{
|
|
// This setting key must match EnabledModules.cs [JsonPropertyName("NewPlus")]
|
|
return newplus::constants::non_localizable::powertoy_key;
|
|
}
|
|
|
|
virtual powertoys_gpo::gpo_rule_configured_t gpo_policy_enabled_configuration() override
|
|
{
|
|
return powertoys_gpo::getConfiguredNewPlusEnabledValue();
|
|
}
|
|
|
|
virtual bool get_config(_Out_ PWSTR buffer, _Out_ int* buffer_size) override
|
|
{
|
|
// Not implemented as Settings are propagating via json
|
|
return true;
|
|
}
|
|
|
|
virtual void set_config(const wchar_t* config) override
|
|
{
|
|
// The following just checks to see if the Template Location was changed for metrics purposes
|
|
// Note: We are not saving the settings here and instead relying on read/write of json in Settings App .cs code paths
|
|
try
|
|
{
|
|
// Parse the input JSON string.
|
|
PowerToysSettings::PowerToyValues values =
|
|
PowerToysSettings::PowerToyValues::from_json_string(config, get_key());
|
|
|
|
values.save_to_settings_file();
|
|
NewSettingsInstance().Load();
|
|
|
|
auto templateValue = values.get_string_value(newplus::constants::non_localizable::settings_json_key_template_location);
|
|
if (templateValue.has_value())
|
|
{
|
|
const auto latest_location_value = templateValue.value();
|
|
const auto existing_location_value = NewSettingsInstance().GetTemplateLocation();
|
|
if (!newplus::utilities::wstring_same_when_comparing_ignore_case(latest_location_value, existing_location_value))
|
|
{
|
|
Trace::EventChangedTemplateLocation();
|
|
}
|
|
}
|
|
|
|
}
|
|
catch (std::exception& e)
|
|
{
|
|
Logger::error("Configuration parsing failed: {}", std::string{ e.what() });
|
|
}
|
|
}
|
|
|
|
virtual bool is_enabled_by_default() const override
|
|
{
|
|
return false;
|
|
}
|
|
|
|
virtual void enable() override
|
|
{
|
|
Logger::info("New+ enabled via Settings UI");
|
|
|
|
// Log telemetry
|
|
Trace::EventToggleOnOff(true);
|
|
if (package::IsWin11OrGreater())
|
|
{
|
|
newplus::utilities::register_msix_package();
|
|
}
|
|
else
|
|
{
|
|
#if defined(ENABLE_REGISTRATION) || defined(NDEBUG)
|
|
NewPlusRuntimeRegistration::EnsureRegisteredWin10();
|
|
#endif
|
|
}
|
|
|
|
powertoy_new_enabled = true;
|
|
}
|
|
|
|
virtual void disable() override
|
|
{
|
|
Logger::info("New+ disabled via Settings UI");
|
|
Disable(true);
|
|
}
|
|
|
|
virtual bool is_enabled() override
|
|
{
|
|
return powertoy_new_enabled;
|
|
}
|
|
|
|
virtual void hide_file_extension(bool hide_file_extension)
|
|
{
|
|
Logger::info("New+ hide file extension {}", hide_file_extension);
|
|
}
|
|
|
|
virtual void hide_starting_digits(bool hide_starting_digits)
|
|
{
|
|
Logger::info("New+ hide starting digits {}", hide_starting_digits);
|
|
}
|
|
|
|
virtual void template_location(std::wstring path_location)
|
|
{
|
|
Logger::info("New+ template location");
|
|
}
|
|
|
|
virtual void destroy() override
|
|
{
|
|
Disable(false);
|
|
delete this;
|
|
}
|
|
|
|
private:
|
|
bool powertoy_new_enabled = false;
|
|
|
|
void Disable(bool const traceEvent)
|
|
{
|
|
// Log telemetry
|
|
if (traceEvent)
|
|
{
|
|
Trace::EventToggleOnOff(false);
|
|
}
|
|
if (!package::IsWin11OrGreater())
|
|
{
|
|
#if defined(ENABLE_REGISTRATION) || defined(NDEBUG)
|
|
NewPlusRuntimeRegistration::Unregister();
|
|
Logger::info(L"New+ context menu unregistered (Win10)");
|
|
#endif
|
|
}
|
|
powertoy_new_enabled = false;
|
|
}
|
|
|
|
void init_settings()
|
|
{
|
|
powertoy_new_enabled = NewSettingsInstance().GetEnabled();
|
|
}
|
|
};
|
|
|
|
extern "C" __declspec(dllexport) PowertoyModuleIface* __cdecl powertoy_create()
|
|
{
|
|
return new NewModule();
|
|
}
|