mir/apparmor
2
0
Fork 0
mirror of https://gitlab.com/apparmor/apparmor synced 2025-09-01 14:55:10 +00:00
Code Issues Releases Wiki Activity

Merge Set (instead of compare) exresult

Browse Source 
Interestingly this accidentally worked because `if exresult` is true for
both a non-empty string ("PASS") as well as a real `True` value.

Found by Mark Grassi as part of
https://gitlab.com/apparmor/apparmor/-/merge_requests/906

I propose this patch for all branches.

MR: https://gitlab.com/apparmor/apparmor/-/merge_requests/907
Approved-by: Jon Tourville <jon.tourville@canonical.com>
Merged-by: Christian Boltz <apparmor@cboltz.de>


(cherry picked from commit c06ea77445)

5a2fb856 Set (instead of compare) exresult
This commit is contained in:
Christian Boltz
2022-08-16 19:25:49 +00:00
parent ae03462f25
commit 1cccb93faa
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
utils/test/test-parser-simple-tests.py
View File

@@ -427,7 +427,7 @@ def parse_test_profiles(file_with_path):
if line.startswith('#=EXRESULT '): if line.startswith('#=EXRESULT '):
exresult = line.split()[1] exresult = line.split()[1]
if exresult == 'PASS': if exresult == 'PASS':
exresult == True exresult = True
exresult_found = True exresult_found = True
elif exresult == 'FAIL': elif exresult == 'FAIL':
exresult = False exresult = False