2
0
mirror of https://gitlab.com/apparmor/apparmor synced 2025-09-04 00:05:14 +00:00

Make BaseRule a proper abstract base class

This commit is contained in:
Mark Grassi
2022-09-27 22:14:31 -04:00
parent 9107a0d891
commit 852169948f
15 changed files with 167 additions and 128 deletions

View File

@@ -18,7 +18,6 @@ from collections import namedtuple
from apparmor.common import AppArmorBug, AppArmorException
from apparmor.logparser import ReadLog
from apparmor.rule import BaseRule
from apparmor.rule.dbus import DbusRule, DbusRuleset
from apparmor.translations import init_translation
from common_test import AATest, setup_all_loops
@@ -767,18 +766,22 @@ class DbusCoveredTest_Invalid(AATest):
self.obj.is_covered(self.testobj)
def test_invalid_is_covered(self):
obj = DbusRule.create_instance('dbus send,')
testobj = BaseRule() # different type
raw_rule = 'dbus send,'
class SomeOtherClass(DbusRule):
pass
obj = DbusRule.create_instance(raw_rule)
testobj = SomeOtherClass.create_instance(raw_rule) # different type
with self.assertRaises(AppArmorBug):
obj.is_covered(testobj)
def test_invalid_is_equal(self):
obj = DbusRule.create_instance('dbus send,')
testobj = BaseRule() # different type
raw_rule = 'dbus send,'
class SomeOtherClass(DbusRule):
pass
obj = DbusRule.create_instance(raw_rule)
testobj = SomeOtherClass.create_instance(raw_rule) # different type
with self.assertRaises(AppArmorBug):
obj.is_equal(testobj)