mir/apparmor
2
0
Fork 0
mirror of https://gitlab.com/apparmor/apparmor synced 2025-09-05 00:35:13 +00:00
Code Issues Releases Wiki Activity

Make BaseRule a proper abstract base class

Browse Source
This commit is contained in:
Mark Grassi
2022-09-27 22:14:31 -04:00
parent 9107a0d891
commit 852169948f
15 changed files with 167 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
utils/test/test-include.py
View File

@@ -19,8 +19,6 @@ import unittest
from collections import namedtuple
from apparmor.common import AppArmorBug, AppArmorException
# from apparmor.logparser import ReadLog
from apparmor.rule import BaseRule
from apparmor.rule.include import IncludeRule, IncludeRuleset
from apparmor.translations import init_translation
from common_test import AATest, setup_all_loops, write_file
@@ -298,18 +296,22 @@ class IncludeCoveredTest_Invalid(AATest):
# obj.is_covered(testobj)
def test_invalid_is_covered(self):
obj = IncludeRule.create_instance('include <abstractions/base>')
testobj = BaseRule() # different type
raw_rule = 'include <abstractions/base>'
class SomeOtherClass(IncludeRule):
pass
obj = IncludeRule.create_instance(raw_rule)
testobj = SomeOtherClass.create_instance(raw_rule) # different type
with self.assertRaises(AppArmorBug):
obj.is_covered(testobj)
def test_invalid_is_equal(self):
obj = IncludeRule.create_instance('include <abstractions/base>')
testobj = BaseRule() # different type
raw_rule = 'include <abstractions/base>'
class SomeOtherClass(IncludeRule):
pass
obj = IncludeRule.create_instance(raw_rule)
testobj = SomeOtherClass.create_instance(raw_rule) # different type
with self.assertRaises(AppArmorBug):
obj.is_equal(testobj)