mir/apparmor
2
0
Fork 0
mirror of https://gitlab.com/apparmor/apparmor synced 2025-08-22 18:17:09 +00:00
Code Issues Releases Wiki Activity

Do not use permission hashing for minimization by default. While this

Browse Source 
improves minimization performance, it can slow down total creation time and
result in larger compressed dfas.

This is because it results in the dfa not being completely minimized which
with the current O(n2) dfa table compression algorithm can result in slower
compressed dfa generation.
This commit is contained in:
John Johansen 2010-11-09 11:27:36 -08:00
parent 51f443c7b6
commit a84844cea5
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
parser/libapparmor_re/regexp.y
View File

@ -1811,7 +1811,8 @@ void DFA::minimize(dfaflags_t flags)
/* Remap the dfa so it uses the representative states /* Remap the dfa so it uses the representative states
* Use the first state of a partition as the representative state * Use the first state of a partition as the representative state
* At this point all states with in a partion have transitions * At this point all states with in a partion have transitions
* to states within the same partitions * to states within the same partitions, however this can slow
* down compressed dfa compression as there are more states,
*/ */
for (list <Partition *>::iterator p = partitions.begin(); for (list <Partition *>::iterator p = partitions.begin();
p != partitions.end(); p++) { p != partitions.end(); p++) {

2
parser/parser_main.c
View File

@ -69,7 +69,7 @@ int binary_input = 0;
int names_only = 0; int names_only = 0;
int dump_vars = 0; int dump_vars = 0;
int dump_expanded_vars = 0; int dump_expanded_vars = 0;
dfaflags_t dfaflags = DFA_CONTROL_TREE_NORMAL | DFA_CONTROL_TREE_SIMPLE | DFA_CONTROL_MINIMIZE | DFA_CONTROL_MINIMIZE_HASH_TRANS | DFA_CONTROL_MINIMIZE_HASH_PERMS; dfaflags_t dfaflags = DFA_CONTROL_TREE_NORMAL | DFA_CONTROL_TREE_SIMPLE | DFA_CONTROL_MINIMIZE | DFA_CONTROL_MINIMIZE_HASH_TRANS;
int conf_verbose = 0; int conf_verbose = 0;
int conf_quiet = 0; int conf_quiet = 0;
int kernel_load = 1; int kernel_load = 1;