mirror of
https://gitlab.com/apparmor/apparmor
synced 2025-08-30 22:05:27 +00:00
0005895e3d
The writeu16() function was returning the address of the passed in
std::ostringstream and then the callers of that function were
incorrectly writing that address to the rule buffer.
Before:
$ echo "/t { unix (connect,read,write) type=stream, }" |
apparmor_parser -qQD dfa-states
{1} <== (allow/deny/audit/quiet)
{2} (0x 4/0/0/0)
{3} (0x 4/0/0/0)
{43} (0x 46/0/0/0)
{44} (0x 46/0/0/0)
{1} -> {2}: 0x2
{1} -> {3}: 0x4
{1} -> {2}: 0x7
{1} -> {2}: 0x9
{1} -> {2}: 0xa
{1} -> {2}: 0x20 \
{1} -> {4}: 0x34 4
{3} (0x 4/0/0/0) -> {5}: 0x0
{4} -> {6}: 0x0
{5} -> {7}: 0x1
{6} -> {2}: 0x31 1
{7} -> {8}: 0x30 0
{8} -> {9}: 0x78 x
{9} -> {10}: 0x37 7
{10} -> {11}: 0x66 f
{11} -> {12}: 0x66 f
{12} -> {13}: 0x66 f
{13} -> {14}: 0x31 1
{14} -> {15}: 0x30 0
{15} -> {16}: 0x34 4
{16} -> {17}: 0x66 f
{17} -> {18}: 0x33 3
{18} -> {19}: 0x35 5
{19} -> {20}: 0x31 1
{20} -> {21}: 0x38 8
{21} -> {22}: 0x0
{22} -> {23}: 0x1
{23} -> {24}: 0x30 0
{24} -> {25}: 0x78 x
{25} -> {26}: 0x37 7
{26} -> {27}: 0x66 f
{27} -> {28}: 0x66 f
{28} -> {29}: 0x66 f
{29} -> {30}: 0x31 1
{30} -> {31}: 0x30 0
{31} -> {32}: 0x34 4
{32} -> {33}: 0x66 f
{33} -> {34}: 0x33 3
{34} -> {35}: 0x35 5
{35} -> {36}: 0x31 1
{36} -> {37}: 0x38 8
{37} -> {38}: []
{38} -> {39}: []
{39} -> {40}: 0x0
{39} -> {39}: []
{40} -> {40}: 0x0
{40} -> {41}: 0x1
{40} -> {39}: []
{41} -> {42}: 0x0
{41} -> {39}: []
{42} -> {40}: 0x0
{42} -> {44}: 0x1
{42} -> {43}: []
{43} (0x 46/0/0/0) -> {40}: 0x0
{43} (0x 46/0/0/0) -> {43}: []
{44} (0x 46/0/0/0) -> {42}: 0x0
{44} (0x 46/0/0/0) -> {43}: []
After:
$ echo "/t { unix (connect,read,write) type=stream, }" |
apparmor_parser -qQD dfa-states
{1} <== (allow/deny/audit/quiet)
{2} (0x 4/0/0/0)
{3} (0x 4/0/0/0)
{15} (0x 46/0/0/0)
{16} (0x 46/0/0/0)
{1} -> {2}: 0x2
{1} -> {3}: 0x4
{1} -> {2}: 0x7
{1} -> {2}: 0x9
{1} -> {2}: 0xa
{1} -> {2}: 0x20 \
{1} -> {4}: 0x34 4
{3} (0x 4/0/0/0) -> {5}: 0x0
{4} -> {6}: 0x0
{5} -> {7}: 0x1
{6} -> {2}: 0x31 1
{7} -> {8}: 0x0
{8} -> {9}: 0x1
{9} -> {10}: []
{10} -> {11}: []
{11} -> {12}: 0x0
{11} -> {11}: []
{12} -> {12}: 0x0
{12} -> {13}: 0x1
{12} -> {11}: []
{13} -> {14}: 0x0
{13} -> {11}: []
{14} -> {12}: 0x0
{14} -> {16}: 0x1
{14} -> {15}: []
{15} (0x 46/0/0/0) -> {12}: 0x0
{15} (0x 46/0/0/0) -> {15}: []
{16} (0x 46/0/0/0) -> {14}: 0x0
{16} (0x 46/0/0/0) -> {15}: []
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Acked-by: Seth Arnold <seth.arnold@canonical.com>
The apparmor_parser allows you to add, replace, and remove AppArmor policy through the use of command line options. The default is to add. `apparmor_parser --help` shows what the command line options are. You can also find more information at http://wiki.apparmor.net Please send all complaints, feature requests, rants about the software, and questions to the apparmor@lists.ubuntu.com mailing list. Bug reports can be filed against the AppArmor project on launchpad.net at https://launchpad.net/apparmor or reported to the mailing list directly for those who wish not to register for an account on launchpad. Security issues can be filed as security bugs on launchpad or directed to security@ubuntu.com. We will attempt to conform to the RFP vulnerability disclosure protocol: http://www.wiretrip.net/rfp/policy.html Thanks. -- The AppArmor development team