mirror of
https://gitlab.com/apparmor/apparmor
synced 2025-08-22 01:57:43 +00:00
ba5e007287
Parsing mount options (also) accepted partial matches as long as the option started with the right characters. For example, 'options=syncfoo' was parsed as 'sync'. This is also the reason why the list of mount options was re-ordered so that 'r' and 'w' came last to give longer options a chance to match (otherwise, 'rw' would be interpreted as 'r'). Fix parsing by adding a lookahead match so that the regex enforces that the mount option is followed by whitespace, or is at the end of rule_details. Note that this issue only affected the options=foo syntax. options=(foo) worked correctly even without this fix. Now that this is fixed, move 'r' and 'w' back to their original position in the list of mount options. Also add a test where a mount rule ends with 'options=rw,' to ensure that the '$' lookahead works.
Known Bugs: Will allow multiple letters in the () due to translation/unicode issues with regexing the key. User input will probably bug out in a different locale.