mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-28 04:58:04 +00:00
Code Issues Releases Wiki Activity
bind/lib/dns/rdata/generic/naptr_35.c

718 lines
14 KiB
C
Raw Normal View History

Initial implementation
1999-02-01 23:49:47 +00:00
/*
Update license headers to not include years in copyright in all applicable files
2018-02-23 09:53:12 +01:00
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your own CVS tree will help minimize CVS conflicts. Maybe not. Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
*
Update the copyright information in all files in the repository This commit converts the license handling to adhere to the REUSE specification. It specifically: 1. Adds used licnses to LICENSES/ directory 2. Add "isc" template for adding the copyright boilerplate 3. Changes all source files to include copyright and SPDX license header, this includes all the C sources, documentation, zone files, configuration files. There are notes in the doc/dev/copyrights file on how to add correct headers to the new files. 4. Handle the rest that can't be modified via .reuse/dep5 file. The binary (or otherwise unmodifiable) files could have license places next to them in <foo>.license file, but this would lead to cluttered repository and most of the files handled in the .reuse/dep5 file are system test files.
2021-06-03 08:37:05 +02:00
* SPDX-License-Identifier: MPL-2.0
*
4401. [misc] Change LICENSE to MPL 2.0.
2016-06-27 14:56:38 +10:00
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
update all copyright headers to eliminate the typo
2020-09-14 16:20:40 -07:00
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
Update license headers to not include years in copyright in all applicable files
2018-02-23 09:53:12 +01:00
*
* See the COPYRIGHT file distributed with this work for additional
* information regarding copyright ownership.
Initial implementation
1999-02-01 23:49:47 +00:00
*/
1851. [doc] Doxygen comment markup. [RT #11398]
2005-04-27 04:57:32 +00:00
/* RFC2915 */
Initial implementation
1999-02-01 23:49:47 +00:00
3142. [bug] NAPTR is class agnostic. [RT #25429]
2011-08-16 00:02:38 +00:00
#ifndef RDATA_GENERIC_NAPTR_35_C
#define RDATA_GENERIC_NAPTR_35_C
Initial implementation
1999-02-01 23:49:47 +00:00
add attributes (line singleton, exlcusive, meta, etc) to rdata C files, and build a table of them using gen.c. This means the names are stored twice, but that will change in the near future. This will speed up number to text conversions for rdatatypes, and I plan on speeding up text->number as well, soon.
2000-04-07 03:54:52 +00:00
#define RRTYPE_NAPTR_ATTRIBUTES (0)
3500. [port] Support NAPTR regular expression validation on all platforms. [RT #32688]
2013-02-27 08:59:04 +11:00
#include <isc/regex.h>
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
/*
* Check the wire format of the Regexp field.
fix spelling errors reported by Fossies.
2020-02-20 14:49:36 -08:00
* Don't allow embedded NUL's.
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
*/
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
txt_valid_regex(const unsigned char *txt) {
unsigned int nsub = 0;
char regex[256];
char *cp;
bool flags = false;
bool replace = false;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
unsigned char c;
unsigned char delim;
apply the modified style
2020-02-13 14:44:37 -08:00
unsigned int len;
int n;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
len = *txt++;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (len == 0U) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (ISC_R_SUCCESS);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
delim = *txt++;
len--;
/*
* Digits, backslash and flags can't be delimiters.
*/
switch (delim) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
case '0':
case '1':
case '2':
case '3':
case '4':
case '5':
case '6':
case '7':
case '8':
case '9':
case '\\':
case 'i':
case 0:
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
}
cp = regex;
while (len-- > 0) {
c = *txt++;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (c == 0) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
if (c == delim && !replace) {
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
replace = true;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
continue;
} else if (c == delim && !flags) {
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
flags = true;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
continue;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
} else if (c == delim) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
/*
* Flags are not escaped.
*/
if (flags) {
switch (c) {
case 'i':
continue;
default:
return (DNS_R_SYNTAX);
}
}
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (!replace) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
*cp++ = c;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
if (c == '\\') {
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (len == 0) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
c = *txt++;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (c == 0) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
len--;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (replace) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
switch (c) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
case '0':
return (DNS_R_SYNTAX);
case '1':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 1) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 1;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '2':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 2) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 2;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '3':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 3) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 3;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '4':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 4) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 4;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '5':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 5) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 5;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '6':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 6) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 6;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '7':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 7) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 7;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '8':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 8) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 8;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
case '9':
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (nsub < 9) {
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
nsub = 9;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
break;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
}
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
if (!replace) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
*cp++ = c;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
}
}
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (!flags) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
*cp = '\0';
3500. [port] Support NAPTR regular expression validation on all platforms. [RT #32688]
2013-02-27 08:59:04 +11:00
n = isc_regex_validate(regex);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (n < 0 || nsub > (unsigned int)n) {
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (DNS_R_SYNTAX);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
return (ISC_R_SUCCESS);
}
add attributes (line singleton, exlcusive, meta, etc) to rdata C files, and build a table of them using gen.c. This means the names are stored twice, but that will change in the near future. This will speed up number to text conversions for rdatatypes, and I plan on speeding up text->number as well, soon.
2000-04-07 03:54:52 +00:00
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
fromtext_naptr(ARGS_FROMTEXT) {
isc_token_t token;
dns_name_t name;
isc_buffer_t buffer;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
unsigned char *regex;
Initial implementation
1999-02-01 23:49:47 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(type == dns_rdatatype_naptr);
Initial implementation
1999-02-01 23:49:47 +00:00
Fix a bunch of unused variable warnings that only occurred with assertions turned off.
2001-03-16 22:53:20 +00:00
UNUSED(type);
added UNUSED() macros for arguments that end up unused when assertion checking is turned off
2000-12-01 01:40:59 +00:00
UNUSED(rdclass);
936. [func] Warn when non dotted decimal quad's are used. [RT #1084] 935. [bug] inet_pton failed to reject leading zeros.
2001-07-16 03:06:53 +00:00
UNUSED(callbacks);
added UNUSED() macros for arguments that end up unused when assertion checking is turned off
2000-12-01 01:40:59 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order.
*/
The identical gettoken() routines in rdata.c, hex.c, and base64.c have been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_number,
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
false));
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (token.value.as_ulong > 0xffffU) {
769. [func] Improved error reporting when parsing rdata. [RT #740] Two new error codes. Also push back the last token, if it makes sense to do so, so that it gets printed in the error message using RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
RETTOK(ISC_R_RANGE);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(uint16_tobuffer(token.value.as_ulong, target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Preference.
*/
The identical gettoken() routines in rdata.c, hex.c, and base64.c have been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_number,
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
false));
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (token.value.as_ulong > 0xffffU) {
769. [func] Improved error reporting when parsing rdata. [RT #740] Two new error codes. Also push back the last token, if it makes sense to do so, so that it gets printed in the error message using RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
RETTOK(ISC_R_RANGE);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(uint16_tobuffer(token.value.as_ulong, target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
The identical gettoken() routines in rdata.c, hex.c, and base64.c have been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_qstring,
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
false));
769. [func] Improved error reporting when parsing rdata. [RT #740] Two new error codes. Also push back the last token, if it makes sense to do so, so that it gets printed in the error message using RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
RETTOK(txt_fromtext(&token.value.as_textregion, target));
Initial implementation
1999-02-01 23:49:47 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
The identical gettoken() routines in rdata.c, hex.c, and base64.c have been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_qstring,
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
false));
769. [func] Improved error reporting when parsing rdata. [RT #740] Two new error codes. Also push back the last token, if it makes sense to do so, so that it gets printed in the error message using RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
RETTOK(txt_fromtext(&token.value.as_textregion, target));
Initial implementation
1999-02-01 23:49:47 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
regex = isc_buffer_used(target);
The identical gettoken() routines in rdata.c, hex.c, and base64.c have been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_qstring,
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
false));
769. [func] Improved error reporting when parsing rdata. [RT #740] Two new error codes. Also push back the last token, if it makes sense to do so, so that it gets printed in the error message using RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
RETTOK(txt_fromtext(&token.value.as_textregion, target));
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
RETTOK(txt_valid_regex(regex));
Initial implementation
1999-02-01 23:49:47 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
The identical gettoken() routines in rdata.c, hex.c, and base64.c have been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
RETERR(isc_lex_getmastertoken(lexer, &token, isc_tokentype_string,
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
false));
Initial implementation
1999-02-01 23:49:47 +00:00
dns_name_init(&name, NULL);
103. [func] libisc buffer API changes for <isc/buffer.h>: Added: isc_buffer_base(b) (pointer) isc_buffer_current(b) (pointer) isc_buffer_active(b) (pointer) isc_buffer_used(b) (pointer) isc_buffer_length(b) (int) isc_buffer_usedlength(b) (int) isc_buffer_consumedlength(b) (int) isc_buffer_remaininglength(b) (int) isc_buffer_activelength(b) (int) isc_buffer_availablelength(b) (int) Removed: ISC_BUFFER_USEDCOUNT(b) ISC_BUFFER_AVAILABLECOUNT(b) isc_buffer_type(b) Changed names: isc_buffer_used(b, r) -> isc_buffer_usedregion(b, r) isc_buffer_available(b, r) -> isc_buffer_available_region(b, r) isc_buffer_consumed(b, r) -> isc_buffer_consumedregion(b, r) isc_buffer_active(b, r) -> isc_buffer_activeregion(b, r) isc_buffer_remaining(b, r) -> isc_buffer_remainingregion(b, r) Buffer types were removed, so the ISC_BUFFERTYPE_* macros are no more, and the type argument to isc_buffer_init and isc_buffer_allocate were removed. isc_buffer_putstr is now void (instead of isc_result_t) and requires that the caller ensure that there is enough available buffer space for the string.
2000-04-27 00:03:12 +00:00
buffer_fromregion(&buffer, &token.value.as_region);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (origin == NULL) {
4214. [protocol] Add support for TALINK. [RT #40544]
2015-09-18 07:43:43 +10:00
origin = dns_rootname;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
1586. [func] "check-names" is now implemented.
2004-02-27 20:41:51 +00:00
RETTOK(dns_name_fromtext(&name, &buffer, origin, options, target));
769. [func] Improved error reporting when parsing rdata. [RT #740] Two new error codes. Also push back the last token, if it makes sense to do so, so that it gets printed in the error message using RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
return (ISC_R_SUCCESS);
Initial implementation
1999-02-01 23:49:47 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
totext_naptr(ARGS_TOTEXT) {
isc_region_t region;
dns_name_t name;
dns_name_t prefix;
bool sub;
char buf[sizeof("64000")];
Initial implementation
1999-02-01 23:49:47 +00:00
unsigned short num;
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata->type == dns_rdatatype_naptr);
Remove the rdata->length == 0 checks, UPDATE pseudo rdata are now tagged. Add sanity checks to rdata types where the length cannot legally be zero.
2000-10-25 05:44:10 +00:00
REQUIRE(rdata->length != 0);
Initial implementation
1999-02-01 23:49:47 +00:00
dns_name_init(&name, NULL);
dns_name_init(&prefix, NULL);
dns_rdata_toregion(rdata, &region);
code review, including fixes to suspicious looking memcmp()s
2000-03-17 02:47:01 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
num = uint16_fromregion(&region);
isc_region_consume(&region, 2);
4748. [cleanup] Sprintf to snprintf coversions. [RT #46132]
2017-10-03 14:54:19 +11:00
snprintf(buf, sizeof(buf), "%u", num);
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(str_totext(buf, target));
RETERR(str_totext(" ", target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Preference.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
num = uint16_fromregion(&region);
isc_region_consume(&region, 2);
4748. [cleanup] Sprintf to snprintf coversions. [RT #46132]
2017-10-03 14:54:19 +11:00
snprintf(buf, sizeof(buf), "%u", num);
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(str_totext(buf, target));
RETERR(str_totext(" ", target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
RETERR(txt_totext(&region, true, target));
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(str_totext(" ", target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
RETERR(txt_totext(&region, true, target));
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(str_totext(" ", target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
RETERR(txt_totext(&region, true, target));
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(str_totext(" ", target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
dns_name_fromregion(&name, &region);
added dns_db_dump(), $DATE, and supporting changes
1999-06-08 10:35:23 +00:00
sub = name_prefix(&name, tctx->origin, &prefix);
code review, including fixes to suspicious looking memcmp()s
2000-03-17 02:47:01 +00:00
return (dns_name_totext(&prefix, sub, target));
Initial implementation
1999-02-01 23:49:47 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
fromwire_naptr(ARGS_FROMWIRE) {
dns_name_t name;
isc_region_t sr;
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
unsigned char *regex;
Initial implementation
1999-02-01 23:49:47 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(type == dns_rdatatype_naptr);
Add decompression.
1999-02-24 06:31:35 +00:00
Fix a bunch of unused variable warnings that only occurred with assertions turned off.
2001-03-16 22:53:20 +00:00
UNUSED(type);
added UNUSED() macros for arguments that end up unused when assertion checking is turned off
2000-12-01 01:40:59 +00:00
UNUSED(rdclass);
Shrink decompression contexts It's wasteful to use 20 bytes and a pointer indirection to represent two bits of information, so turn the struct into an enum. And change the names of the enumeration constants to make the intent more clear. This change introduces some inline functions into another header, which confuses `gcovr` when it is trying to collect code coverage statistics. So, in the CI job, copy more header files into a directory where `gcovr` looks for them.
2022-05-05 16:36:52 +01:00
dctx = dns_decompress_setpermitted(dctx, false);
Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your own CVS tree will help minimize CVS conflicts. Maybe not. Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
update copyright notice
2008-02-15 23:46:51 +00:00
dns_name_init(&name, NULL);
Initial implementation
1999-02-01 23:49:47 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order, preference.
*/
103. [func] libisc buffer API changes for <isc/buffer.h>: Added: isc_buffer_base(b) (pointer) isc_buffer_current(b) (pointer) isc_buffer_active(b) (pointer) isc_buffer_used(b) (pointer) isc_buffer_length(b) (int) isc_buffer_usedlength(b) (int) isc_buffer_consumedlength(b) (int) isc_buffer_remaininglength(b) (int) isc_buffer_activelength(b) (int) isc_buffer_availablelength(b) (int) Removed: ISC_BUFFER_USEDCOUNT(b) ISC_BUFFER_AVAILABLECOUNT(b) isc_buffer_type(b) Changed names: isc_buffer_used(b, r) -> isc_buffer_usedregion(b, r) isc_buffer_available(b, r) -> isc_buffer_available_region(b, r) isc_buffer_consumed(b, r) -> isc_buffer_consumedregion(b, r) isc_buffer_active(b, r) -> isc_buffer_activeregion(b, r) isc_buffer_remaining(b, r) -> isc_buffer_remainingregion(b, r) Buffer types were removed, so the ISC_BUFFERTYPE_* macros are no more, and the type argument to isc_buffer_init and isc_buffer_allocate were removed. isc_buffer_putstr is now void (instead of isc_result_t) and requires that the caller ensure that there is enough available buffer space for the string.
2000-04-27 00:03:12 +00:00
isc_buffer_activeregion(source, &sr);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (sr.length < 4) {
s/DNS_R_/ISC_R_/ change for some codes.
2000-04-06 22:03:35 +00:00
return (ISC_R_UNEXPECTEDEND);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(mem_tobuffer(target, sr.base, 4));
isc_buffer_forward(source, 4);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(txt_fromwire(source, target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(txt_fromwire(source, target));
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
regex = isc_buffer_used(target);
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(txt_fromwire(source, target));
2534. [func] Check NAPTR records regular expressions and replacement strings to ensure they are syntaxically valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
RETERR(txt_valid_regex(regex));
Initial implementation
1999-02-01 23:49:47 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
1586. [func] "check-names" is now implemented.
2004-02-27 20:41:51 +00:00
return (dns_name_fromwire(&name, source, dctx, options, target));
Initial implementation
1999-02-01 23:49:47 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
towire_naptr(ARGS_TOWIRE) {
dns_name_t name;
In the towire_* and additionaldata_* routines, add an offsets table to names passed into dns_name_toregion(). This is effectively free, and reduces the number of calls to set_offsets() and dns_name_clone() in name compression.
2001-02-12 03:05:05 +00:00
dns_offsets_t offsets;
apply the modified style
2020-02-13 14:44:37 -08:00
isc_region_t sr;
Initial implementation
1999-02-01 23:49:47 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata->type == dns_rdatatype_naptr);
Remove the rdata->length == 0 checks, UPDATE pseudo rdata are now tagged. Add sanity checks to rdata types where the length cannot legally be zero.
2000-10-25 05:44:10 +00:00
REQUIRE(rdata->length != 0);
Initial implementation
1999-02-01 23:49:47 +00:00
There can no longer be multiple compression methods The aim is to get rid of the obsolete term "GLOBAL14" and instead just refer to DNS name compression. This is mostly mechanically renaming from dns_(de)compress_(get|set)methods() to dns_(de)compress_(get|set)permitted() and replacing the related enum by a simple flag, because compression is either on or off.
2022-05-05 14:52:44 +01:00
dns_compress_setpermitted(cctx, false);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order, preference.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
dns_rdata_toregion(rdata, &sr);
RETERR(mem_tobuffer(target, sr.base, 4));
isc_region_consume(&sr, 4);
Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your own CVS tree will help minimize CVS conflicts. Maybe not. Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(mem_tobuffer(target, sr.base, sr.base[0] + 1));
isc_region_consume(&sr, sr.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(mem_tobuffer(target, sr.base, sr.base[0] + 1));
isc_region_consume(&sr, sr.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
RETERR(mem_tobuffer(target, sr.base, sr.base[0] + 1));
isc_region_consume(&sr, sr.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
In the towire_* and additionaldata_* routines, add an offsets table to names passed into dns_name_toregion(). This is effectively free, and reduces the number of calls to set_offsets() and dns_name_clone() in name compression.
2001-02-12 03:05:05 +00:00
dns_name_init(&name, offsets);
Initial implementation
1999-02-01 23:49:47 +00:00
dns_name_fromregion(&name, &sr);
return (dns_name_towire(&name, cctx, target));
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static int
apply the modified style
2020-02-13 14:44:37 -08:00
compare_naptr(ARGS_COMPARE) {
dns_name_t name1;
dns_name_t name2;
Initial implementation
1999-02-01 23:49:47 +00:00
isc_region_t region1;
isc_region_t region2;
apply the modified style
2020-02-13 14:44:37 -08:00
int order, len;
Initial implementation
1999-02-01 23:49:47 +00:00
REQUIRE(rdata1->type == rdata2->type);
class to rdclass; additional data support
1999-08-02 22:18:31 +00:00
REQUIRE(rdata1->rdclass == rdata2->rdclass);
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata1->type == dns_rdatatype_naptr);
Remove the rdata->length == 0 checks, UPDATE pseudo rdata are now tagged. Add sanity checks to rdata types where the length cannot legally be zero.
2000-10-25 05:44:10 +00:00
REQUIRE(rdata1->length != 0);
REQUIRE(rdata2->length != 0);
Initial implementation
1999-02-01 23:49:47 +00:00
dns_rdata_toregion(rdata1, &region1);
dns_rdata_toregion(rdata2, &region2);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order, preference.
*/
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
order = memcmp(region1.base, region2.base, 4);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (order != 0) {
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
return (order < 0 ? -1 : 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
isc_region_consume(&region1, 4);
isc_region_consume(&region2, 4);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
code review, including fixes to suspicious looking memcmp()s
2000-03-17 02:47:01 +00:00
len = ISC_MIN(region1.base[0], region2.base[0]);
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
order = memcmp(region1.base, region2.base, len + 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (order != 0) {
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
return (order < 0 ? -1 : 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
isc_region_consume(&region1, region1.base[0] + 1);
isc_region_consume(&region2, region2.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
code review, including fixes to suspicious looking memcmp()s
2000-03-17 02:47:01 +00:00
len = ISC_MIN(region1.base[0], region2.base[0]);
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
order = memcmp(region1.base, region2.base, len + 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (order != 0) {
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
return (order < 0 ? -1 : 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
isc_region_consume(&region1, region1.base[0] + 1);
isc_region_consume(&region2, region2.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
code review, including fixes to suspicious looking memcmp()s
2000-03-17 02:47:01 +00:00
len = ISC_MIN(region1.base[0], region2.base[0]);
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
order = memcmp(region1.base, region2.base, len + 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (order != 0) {
avoid calling variables 'result' if they are not of type isc_result_t
2000-03-20 22:44:36 +00:00
return (order < 0 ? -1 : 1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
Initial implementation
1999-02-01 23:49:47 +00:00
isc_region_consume(&region1, region1.base[0] + 1);
isc_region_consume(&region2, region2.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
Initial implementation
1999-02-01 23:49:47 +00:00
dns_name_init(&name1, NULL);
dns_name_init(&name2, NULL);
dns_name_fromregion(&name1, &region1);
dns_name_fromregion(&name2, &region2);
Created dns_name_rdatacompare() to do DNSSEC rdata comparisions as opposed to DNSSEC owner name comparisions of names. Changed all rdata types that were using dns_name_compare() to use dns_name_rdatacompare().
1999-02-15 05:44:22 +00:00
return (dns_name_rdatacompare(&name1, &name2));
Initial implementation
1999-02-01 23:49:47 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
fromstruct_naptr(ARGS_FROMSTRUCT) {
3142. [bug] NAPTR is class agnostic. [RT #25429]
2011-08-16 00:02:38 +00:00
dns_rdata_naptr_t *naptr = source;
apply the modified style
2020-02-13 14:44:37 -08:00
isc_region_t region;
Initial implementation
1999-02-01 23:49:47 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(type == dns_rdatatype_naptr);
lib/dns/rdata/*/*.c: Silence false positive nullPointerRedundantCheck warning from Cppcheck Cppcheck gets confused by: void bar(void *arg) { foo *data = arg; REQUIRE(source != NULL); REQUIRE(data->member != NULL); } and for consistency the DbC check needs to be changed to void bar(void *arg) { foo *data = arg; REQUIRE(data != NULL); REQUIRE(data->member != NULL); }
2019-09-27 10:40:51 +02:00
REQUIRE(naptr != NULL);
Implement dns_rdata_fromstruct() where not already done. Add missing REQUIRE tests to existing implementations.
2000-05-22 12:38:12 +00:00
REQUIRE(naptr->common.rdtype == type);
REQUIRE(naptr->common.rdclass == rdclass);
Relax REQUIRES() in *fromstruct() and unconditionally call mem_maybedup() in *tostruct(). TXT is one or more (not zero or more) strings.
2001-06-21 04:00:47 +00:00
REQUIRE(naptr->flags != NULL || naptr->flags_len == 0);
2334. [bug] Bad REQUIRES in fromstruct_in_naptr(), off by one bug in fromstruct_txt(). [RT #17609]
2008-02-15 03:28:49 +00:00
REQUIRE(naptr->service != NULL || naptr->service_len == 0);
REQUIRE(naptr->regexp != NULL || naptr->regexp_len == 0);
Implement dns_rdata_fromstruct() where not already done. Add missing REQUIRE tests to existing implementations.
2000-05-22 12:38:12 +00:00
Fix a bunch of unused variable warnings that only occurred with assertions turned off.
2001-03-16 22:53:20 +00:00
UNUSED(type);
added UNUSED() macros for arguments that end up unused when assertion checking is turned off
2000-12-01 01:40:59 +00:00
UNUSED(rdclass);
Implement dns_rdata_fromstruct() where not already done. Add missing REQUIRE tests to existing implementations.
2000-05-22 12:38:12 +00:00
RETERR(uint16_tobuffer(naptr->order, target));
RETERR(uint16_tobuffer(naptr->preference, target));
RETERR(uint8_tobuffer(naptr->flags_len, target));
RETERR(mem_tobuffer(target, naptr->flags, naptr->flags_len));
RETERR(uint8_tobuffer(naptr->service_len, target));
RETERR(mem_tobuffer(target, naptr->service, naptr->service_len));
RETERR(uint8_tobuffer(naptr->regexp_len, target));
RETERR(mem_tobuffer(target, naptr->regexp, naptr->regexp_len));
dns_name_toregion(&naptr->replacement, &region);
return (isc_buffer_copyregion(target, &region));
Initial implementation
1999-02-01 23:49:47 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
tostruct_naptr(ARGS_TOSTRUCT) {
3142. [bug] NAPTR is class agnostic. [RT #25429]
2011-08-16 00:02:38 +00:00
dns_rdata_naptr_t *naptr = target;
apply the modified style
2020-02-13 14:44:37 -08:00
isc_region_t r;
dns_name_t name;
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata->type == dns_rdatatype_naptr);
lib/dns/rdata/*/*.c: Silence false positive nullPointerRedundantCheck warning from Cppcheck Cppcheck gets confused by: void bar(void *arg) { foo *data = arg; REQUIRE(source != NULL); REQUIRE(data->member != NULL); } and for consistency the DbC check needs to be changed to void bar(void *arg) { foo *data = arg; REQUIRE(data != NULL); REQUIRE(data->member != NULL); }
2019-09-27 10:40:51 +02:00
REQUIRE(naptr != NULL);
Remove the rdata->length == 0 checks, UPDATE pseudo rdata are now tagged. Add sanity checks to rdata types where the length cannot legally be zero.
2000-10-25 05:44:10 +00:00
REQUIRE(rdata->length != 0);
Initial implementation
1999-02-01 23:49:47 +00:00
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
naptr->common.rdclass = rdata->rdclass;
naptr->common.rdtype = rdata->type;
ISC_LINK_INIT(&naptr->common, link);
naptr->flags = NULL;
naptr->service = NULL;
naptr->regexp = NULL;
dns_rdata_toregion(rdata, &r);
naptr->order = uint16_fromregion(&r);
isc_region_consume(&r, 2);
naptr->preference = uint16_fromregion(&r);
isc_region_consume(&r, 2);
naptr->flags_len = uint8_fromregion(&r);
isc_region_consume(&r, 1);
Relax REQUIRES() in *fromstruct() and unconditionally call mem_maybedup() in *tostruct(). TXT is one or more (not zero or more) strings.
2001-06-21 04:00:47 +00:00
INSIST(naptr->flags_len <= r.length);
naptr->flags = mem_maybedup(mctx, r.base, naptr->flags_len);
isc_region_consume(&r, naptr->flags_len);
declare arguments as UNUSED() when used in assertions only
2000-04-28 01:24:18 +00:00
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
naptr->service_len = uint8_fromregion(&r);
isc_region_consume(&r, 1);
Relax REQUIRES() in *fromstruct() and unconditionally call mem_maybedup() in *tostruct(). TXT is one or more (not zero or more) strings.
2001-06-21 04:00:47 +00:00
INSIST(naptr->service_len <= r.length);
naptr->service = mem_maybedup(mctx, r.base, naptr->service_len);
isc_region_consume(&r, naptr->service_len);
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
naptr->regexp_len = uint8_fromregion(&r);
isc_region_consume(&r, 1);
Relax REQUIRES() in *fromstruct() and unconditionally call mem_maybedup() in *tostruct(). TXT is one or more (not zero or more) strings.
2001-06-21 04:00:47 +00:00
INSIST(naptr->regexp_len <= r.length);
naptr->regexp = mem_maybedup(mctx, r.base, naptr->regexp_len);
isc_region_consume(&r, naptr->regexp_len);
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
Name structures were not being initialized.
2000-05-19 02:06:00 +00:00
dns_name_init(&name, NULL);
dns_name_fromregion(&name, &r);
dns_name_init(&naptr->replacement, NULL);
dns/rdata.c: Return void when ISC_R_SUCCESS is only returned value With isc_mem_get() and dns_name_dup() no longer being able to fail, some functions can now only return ISC_R_SUCCESS. Change the return type to void for the following function(s): * name_duporclone()
2021-10-06 12:57:24 +02:00
name_duporclone(&name, mctx, &naptr->replacement);
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
naptr->mctx = mctx;
return ISC_R_SUCCESS from tostruct().
2000-05-19 13:28:36 +00:00
return (ISC_R_SUCCESS);
Initial implementation
1999-02-01 23:49:47 +00:00
}
dns_rdata_tostruct() may require memory to be allocted and hence it will need to be freed, dns_rdata_freestruct(). Changes to implement this. Added C++ support to rdatastruct.h
1999-05-07 03:24:15 +00:00
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static void
apply the modified style
2020-02-13 14:44:37 -08:00
freestruct_naptr(ARGS_FREESTRUCT) {
3142. [bug] NAPTR is class agnostic. [RT #25429]
2011-08-16 00:02:38 +00:00
dns_rdata_naptr_t *naptr = source;
Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your own CVS tree will help minimize CVS conflicts. Maybe not. Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
lib/dns/rdata/*/*.c: Silence false positive nullPointerRedundantCheck warning from Cppcheck Cppcheck gets confused by: void bar(void *arg) { foo *data = arg; REQUIRE(source != NULL); REQUIRE(data->member != NULL); } and for consistency the DbC check needs to be changed to void bar(void *arg) { foo *data = arg; REQUIRE(data != NULL); REQUIRE(data->member != NULL); }
2019-09-27 10:40:51 +02:00
REQUIRE(naptr != NULL);
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(naptr->common.rdtype == dns_rdatatype_naptr);
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (naptr->mctx == NULL) {
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
return;
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (naptr->flags != NULL) {
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
isc_mem_free(naptr->mctx, naptr->flags);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
if (naptr->service != NULL) {
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
isc_mem_free(naptr->mctx, naptr->service);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
if (naptr->regexp != NULL) {
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
isc_mem_free(naptr->mctx, naptr->regexp);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx' is NULL then you need to preserve the 'rdata' until you have finished using the structure as there may be references to the associated memory. If 'mctx' is non NULL it is guarenteed that there are no references to to memory addsociated with 'rdata'. dns_rdata_freestruct() must be called if 'mctx' was non NULL and may safely be called if 'mctx' was NULL. Finish implementing 153 for IN specific types. naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
dns_name_free(&naptr->replacement, naptr->mctx);
naptr->mctx = NULL;
dns_rdata_tostruct() may require memory to be allocted and hence it will need to be freed, dns_rdata_freestruct(). Changes to implement this. Added C++ support to rdatastruct.h
1999-05-07 03:24:15 +00:00
}
class to rdclass; additional data support
1999-08-02 22:18:31 +00:00
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
additionaldata_naptr(ARGS_ADDLDATA) {
dns_name_t name;
dns_offsets_t offsets;
isc_region_t sr;
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
dns_rdatatype_t atype;
apply the modified style
2020-02-13 14:44:37 -08:00
unsigned int i, flagslen;
char *cp;
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata->type == dns_rdatatype_naptr);
class to rdclass; additional data support
1999-08-02 22:18:31 +00:00
Add additional processing to HTTPS and SVBC records The additional processing method has been expanded to take the owner name of the record, as HTTPS and SVBC need it to process "." in service form. The additional section callback can now return the RRset that was added. We use this when adding CNAMEs. Previously, the recursion would stop if it detected that a record you added already exists. With CNAMEs this rule doesn't work, as you ultimately care about the RRset at the target of the CNAME and not the presence of the CNAME itself. Returning the record allows the caller to restart with the target name. As CNAMEs can form loops, loop protection was added. As HTTPS and SVBC can produce infinite chains, we prevent this by tracking recursion depth and stopping if we go too deep.
2019-07-05 16:20:20 +10:00
UNUSED(owner);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order, preference.
*/
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
dns_rdata_toregion(rdata, &sr);
isc_region_consume(&sr, 4);
Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your own CVS tree will help minimize CVS conflicts. Maybe not. Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
atype = 0;
flagslen = sr.base[0];
cp = (char *)&sr.base[1];
for (i = 0; i < flagslen; i++, cp++) {
if (*cp == 'S' || *cp == 's') {
atype = dns_rdatatype_srv;
break;
}
if (*cp == 'A' || *cp == 'a') {
atype = dns_rdatatype_a;
break;
}
}
isc_region_consume(&sr, flagslen + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
isc_region_consume(&sr, sr.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
isc_region_consume(&sr, sr.base[0] + 1);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
In the towire_* and additionaldata_* routines, add an offsets table to names passed into dns_name_toregion(). This is effectively free, and reduces the number of calls to set_offsets() and dns_name_clone() in name compression.
2001-02-12 03:05:05 +00:00
dns_name_init(&name, offsets);
implement NAPTR additional data
2000-01-07 02:44:27 +00:00
dns_name_fromregion(&name, &sr);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (atype != 0) {
Add additional processing to HTTPS and SVBC records The additional processing method has been expanded to take the owner name of the record, as HTTPS and SVBC need it to process "." in service form. The additional section callback can now return the RRset that was added. We use this when adding CNAMEs. Previously, the recursion would stop if it detected that a record you added already exists. With CNAMEs this rule doesn't work, as you ultimately care about the RRset at the target of the CNAME and not the presence of the CNAME itself. Returning the record allows the caller to restart with the target name. As CNAMEs can form loops, loop protection was added. As HTTPS and SVBC can produce infinite chains, we prevent this by tracking recursion depth and stopping if we go too deep.
2019-07-05 16:20:20 +10:00
return ((add)(arg, &name, atype, NULL));
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
class to rdclass; additional data support
1999-08-02 22:18:31 +00:00
s/DNS_R_/ISC_R_/ change for some codes.
2000-04-06 22:03:35 +00:00
return (ISC_R_SUCCESS);
class to rdclass; additional data support
1999-08-02 22:18:31 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static isc_result_t
apply the modified style
2020-02-13 14:44:37 -08:00
digest_naptr(ARGS_DIGEST) {
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
isc_region_t r1, r2;
unsigned int length, n;
dns_result_t is no more. s/dns_result_t/isc_result_t/ -- more later, when I need a break.
1999-12-23 00:09:04 +00:00
isc_result_t result;
apply the modified style
2020-02-13 14:44:37 -08:00
dns_name_t name;
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata->type == dns_rdatatype_naptr);
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
dns_rdata_toregion(rdata, &r1);
r2 = r1;
length = 0;
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Order, preference.
*/
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
length += 4;
isc_region_consume(&r2, 4);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Flags.
*/
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
n = r2.base[0] + 1;
length += n;
isc_region_consume(&r2, n);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Service.
*/
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
n = r2.base[0] + 1;
length += n;
isc_region_consume(&r2, n);
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Regexp.
*/
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
n = r2.base[0] + 1;
length += n;
isc_region_consume(&r2, n);
/*
* Digest the RR up to the replacement name.
*/
r1.length = length;
result = (digest)(arg, &r1);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
if (result != ISC_R_SUCCESS) {
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
return (result);
Use clang-tidy to add curly braces around one-line statements The command used to reformat the files in this commit was: ./util/run-clang-tidy \ -clang-tidy-binary clang-tidy-11 -clang-apply-replacements-binary clang-apply-replacements-11 \ -checks=-*,readability-braces-around-statements \ -j 9 \ -fix \ -format \ -style=file \ -quiet clang-format -i --style=format $(git ls-files '*.c' '*.h') uncrustify -c .uncrustify.cfg --replace --no-backup $(git ls-files '*.c' '*.h') clang-format -i --style=format $(git ls-files '*.c' '*.h')
2020-02-13 21:48:23 +01:00
}
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
DNS_R_RANGE -> ISC_R_RANGE
2000-05-15 21:14:38 +00:00
/*
* Replacement.
*/
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
dns_name_init(&name, NULL);
dns_name_fromregion(&name, &r2);
Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your own CVS tree will help minimize CVS conflicts. Maybe not. Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
compare did not handle some cases; add digest support
1999-08-31 22:04:00 +00:00
return (dns_name_digest(&name, digest, arg));
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static bool
apply the modified style
2020-02-13 14:44:37 -08:00
checkowner_naptr(ARGS_CHECKOWNER) {
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(type == dns_rdatatype_naptr);
1586. [func] "check-names" is now implemented.
2004-02-27 20:41:51 +00:00
UNUSED(name);
UNUSED(type);
UNUSED(rdclass);
UNUSED(wildcard);
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
return (true);
1586. [func] "check-names" is now implemented.
2004-02-27 20:41:51 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static bool
apply the modified style
2020-02-13 14:44:37 -08:00
checknames_naptr(ARGS_CHECKNAMES) {
Use mnemonics for RR class and type comparisons (#40297)
2015-08-17 12:23:35 +05:30
REQUIRE(rdata->type == dns_rdatatype_naptr);
1586. [func] "check-names" is now implemented.
2004-02-27 20:41:51 +00:00
UNUSED(rdata);
UNUSED(owner);
UNUSED(bad);
Replace custom isc_boolean_t with C standard bool type
2018-04-17 08:29:14 -07:00
return (true);
1586. [func] "check-names" is now implemented.
2004-02-27 20:41:51 +00:00
}
Remove use of the inline keyword used as suggestion to compiler Historically, the inline keyword was a strong suggestion to the compiler that it should inline the function marked inline. As compilers became better at optimising, this functionality has receded, and using inline as a suggestion to inline a function is obsolete. The compiler will happily ignore it and inline something else entirely if it finds that's a better optimisation. Therefore, remove all the occurences of the inline keyword with static functions inside single compilation unit and leave the decision whether to inline a function or not entirely on the compiler NOTE: We keep the usage the inline keyword when the purpose is to change the linkage behaviour.
2021-10-11 13:43:12 +02:00
static int
apply the modified style
2020-02-13 14:44:37 -08:00
casecompare_naptr(ARGS_COMPARE) {
3142. [bug] NAPTR is class agnostic. [RT #25429]
2011-08-16 00:02:38 +00:00
return (compare_naptr(rdata1, rdata2));
2801. [func] Detect and report records that are different according to DNSSEC but are sematically equal according to plain DNS. Apply plain DNS comparisons rather than DNSSEC comparisons when processing UPDATE requests. dnssec-signzone now removes such semantically duplicate records prior to signing the RRset. named-checkzone -r {ignore|warn|fail} (default warn) named-compilezone -r {ignore|warn|fail} (default warn) named.conf: check-dup-records {ignore|warn|fail};
2009-12-04 21:09:34 +00:00
}
Use clang-format to reformat the source files
2020-02-12 13:59:18 +01:00
#endif /* RDATA_GENERIC_NAPTR_35_C */
Reference in New Issue Copy Permalink