bind/bin/tests/system/rollover-algo-csk/tests_rollover_algo_csk_initial.py

# Copyright (C) Internet Systems Consortium, Inc. ("ISC")
#
# SPDX-License-Identifier: MPL-2.0
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0.  If a copy of the MPL was not distributed with this
# file, you can obtain one at https://mozilla.org/MPL/2.0/.
#
# See the COPYRIGHT file distributed with this work for additional
# information regarding copyright ownership.

# pylint: disable=redefined-outer-name,unused-import

import isctest
from rollover.common import (
    pytestmark,
    CDSS,
    DURATION,
    TIMEDELTA,
    ALGOROLL_CONFIG,
)


def test_algoroll_csk_initial(ns6):
    config = ALGOROLL_CONFIG
    policy = "csk-algoroll"
    zone = "step1.csk-algorithm-roll.kasp"

    isctest.kasp.wait_keymgr_done(ns6, zone)

    step = {
        "zone": zone,
        "cdss": CDSS,
        "keyprops": [
            f"csk 0 8 2048 goal:omnipresent dnskey:omnipresent krrsig:omnipresent zrrsig:omnipresent ds:omnipresent offset:{-DURATION['P7D']}",
        ],
        "nextev": TIMEDELTA["PT1H"],
    }
    isctest.kasp.check_rollover_step(ns6, config, policy, step)
Isolate rollover-algo-csk test 2025-06-06 16:49:14 +02:00			`# Copyright (C) Internet Systems Consortium, Inc. ("ISC")`
			`#`
			`# SPDX-License-Identifier: MPL-2.0`
			`#`
			`# This Source Code Form is subject to the terms of the Mozilla Public`
			`# License, v. 2.0. If a copy of the MPL was not distributed with this`
			`# file, you can obtain one at https://mozilla.org/MPL/2.0/.`
			`#`
			`# See the COPYRIGHT file distributed with this work for additional`
			`# information regarding copyright ownership.`

			`# pylint: disable=redefined-outer-name,unused-import`

			`import isctest`
Use full path for shared test code imports in rollover tests Previously, symlinks and relative directory imports were used in test modules. This caused a name clash when a shared code module "common.py" was introduced for a different test. To avoid the issue, use full paths in imports. 2025-08-04 16:30:41 +02:00			`from rollover.common import (`
Isolate rollover-algo-csk test 2025-06-06 16:49:14 +02:00			`pytestmark,`
			`CDSS,`
			`DURATION,`
			`TIMEDELTA,`
			`ALGOROLL_CONFIG,`
			`)`


Add nsX fixtures to system tests Many of our test cases only use a single NamedInstance from the `servers` fixture. Introduce `nsX` helper fixtures to simplify these tests and reduce boilterplate code further. Specifically, the test no longer has to either define its own variable to extract a single server from the list, or use the longer servers["nsX"] syntax. While this may seem minor, the amount of times it is repeated across the tests justifies the change. It also promotes using more explicit server identification, i.e. `nsX`, rather than generic `server`. This also improves the clarity of the tests and may be helpful in traceback during debugging as well. 2025-07-08 15:26:09 +02:00			`def test_algoroll_csk_initial(ns6):`
Isolate rollover-algo-csk test 2025-06-06 16:49:14 +02:00			`config = ALGOROLL_CONFIG`
			`policy = "csk-algoroll"`
Add wait_for_keymgr_done() util function to tests The kasp test cases assume that keymgr operations on the zone under test have been completed before the test is executed. These are typically quite fast, but the logs need to be explicitly checked for the messages, otherwise there's a possibility of race conditions causing the kasp/rollover tests to become unstable. Call the wait function in all the kasp/rollover tests where it is expected (which is generally in each test, unless we're dealing with unsigned zones). 2025-07-08 13:46:01 +02:00			`zone = "step1.csk-algorithm-roll.kasp"`

			`isctest.kasp.wait_keymgr_done(ns6, zone)`
Isolate rollover-algo-csk test 2025-06-06 16:49:14 +02:00
			`step = {`
Add wait_for_keymgr_done() util function to tests The kasp test cases assume that keymgr operations on the zone under test have been completed before the test is executed. These are typically quite fast, but the logs need to be explicitly checked for the messages, otherwise there's a possibility of race conditions causing the kasp/rollover tests to become unstable. Call the wait function in all the kasp/rollover tests where it is expected (which is generally in each test, unless we're dealing with unsigned zones). 2025-07-08 13:46:01 +02:00			`"zone": zone,`
Isolate rollover-algo-csk test 2025-06-06 16:49:14 +02:00			`"cdss": CDSS,`
			`"keyprops": [`
			`f"csk 0 8 2048 goal:omnipresent dnskey:omnipresent krrsig:omnipresent zrrsig:omnipresent ds:omnipresent offset:{-DURATION['P7D']}",`
			`],`
			`"nextev": TIMEDELTA["PT1H"],`
			`}`
Add nsX fixtures to system tests Many of our test cases only use a single NamedInstance from the `servers` fixture. Introduce `nsX` helper fixtures to simplify these tests and reduce boilterplate code further. Specifically, the test no longer has to either define its own variable to extract a single server from the list, or use the longer servers["nsX"] syntax. While this may seem minor, the amount of times it is repeated across the tests justifies the change. It also promotes using more explicit server identification, i.e. `nsX`, rather than generic `server`. This also improves the clarity of the tests and may be helpful in traceback during debugging as well. 2025-07-08 15:26:09 +02:00			`isctest.kasp.check_rollover_step(ns6, config, policy, step)`