2023-11-29 13:29:08 -08:00
|
|
|
/*
|
|
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
|
|
*
|
|
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
|
|
*
|
|
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
*
|
|
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
|
|
* information regarding copyright ownership.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <inttypes.h>
|
|
|
|
#include <sched.h> /* IWYU pragma: keep */
|
|
|
|
#include <setjmp.h>
|
|
|
|
#include <stdarg.h>
|
|
|
|
#include <stddef.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
|
|
|
|
#define UNIT_TESTING
|
|
|
|
#include <cmocka.h>
|
|
|
|
|
2025-02-04 13:17:31 +01:00
|
|
|
#include <isc/lib.h>
|
2023-11-29 13:29:08 -08:00
|
|
|
#include <isc/util.h>
|
|
|
|
|
2025-02-04 13:17:31 +01:00
|
|
|
#include <dns/lib.h>
|
2023-11-29 13:29:08 -08:00
|
|
|
#include <dns/qp.h>
|
|
|
|
#include <dns/rdatalist.h>
|
|
|
|
#include <dns/rdataset.h>
|
|
|
|
#include <dns/rdataslab.h>
|
|
|
|
#include <dns/rdatastruct.h>
|
|
|
|
#define KEEP_BEFORE
|
|
|
|
|
|
|
|
/* Include the main file */
|
|
|
|
|
|
|
|
#pragma GCC diagnostic push
|
|
|
|
#pragma GCC diagnostic ignored "-Wshadow"
|
|
|
|
#undef CHECK
|
|
|
|
#include "qpzone.c"
|
|
|
|
#pragma GCC diagnostic pop
|
|
|
|
|
|
|
|
#undef CHECK
|
|
|
|
#include <tests/dns.h>
|
|
|
|
|
|
|
|
#define CASESET(header) \
|
|
|
|
((atomic_load_acquire(&(header)->attributes) & \
|
|
|
|
DNS_SLABHEADERATTR_CASESET) != 0)
|
|
|
|
|
|
|
|
const char *ownercase_vectors[12][2] = {
|
|
|
|
{
|
|
|
|
"AaBbCcDdEeFfGgHhIiJjKkLlMmNnOoPpQqRrSsTtUuVvWwXxYyZz",
|
|
|
|
"aabbccddeeffgghhiijjkkllmmnnooppqqrrssttuuvvwwxxyyzz",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"aabbccddeeffgghhiijjkkllmmnnooppqqrrssttuuvvwwxxyyzz",
|
|
|
|
"AABBCCDDEEFFGGHHIIJJKKLLMMNNOOPPQQRRSSTTUUVVWWXXYYZZ",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"AABBCCDDEEFFGGHHIIJJKKLLMMNNOOPPQQRRSSTTUUVVWWXXYYZZ",
|
|
|
|
"aabbccddeeffgghhiijjkkllmmnnooppqqrrssttuuvvwwxxyyzz",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"aAbBcCdDeEfFgGhHiIjJkKlLmMnNoOpPqQrRsStTuUvVwWxXyYzZ",
|
|
|
|
"aabbccddeeffgghhiijjkkllmmnnooppqqrrssttuuvvwwxxyyzz",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"aAbBcCdDeEfFgGhHiIjJkKlLmMnNoOpPqQrRsStTuUvVxXyYzZ",
|
|
|
|
"aabbccddeeffgghhiijjkkllmmnnooppqqrrssttuuvvxxyyzz",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"WwW.ExAmPlE.OrG",
|
|
|
|
"wWw.eXaMpLe.oRg",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"_SIP.tcp.example.org",
|
|
|
|
"_sip.TCP.example.org",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"bind-USERS.lists.example.org",
|
|
|
|
"bind-users.lists.example.org",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"a0123456789.example.org",
|
|
|
|
"A0123456789.example.org",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"\\000.example.org",
|
|
|
|
"\\000.example.org",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"wWw.\\000.isc.org",
|
|
|
|
"www.\\000.isc.org",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
"\255.example.org",
|
|
|
|
"\255.example.ORG",
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
static bool
|
|
|
|
ownercase_test_one(const char *str1, const char *str2) {
|
|
|
|
isc_result_t result;
|
2025-02-04 16:50:27 +01:00
|
|
|
uint8_t qpdb_s[sizeof(qpzonedb_t) + sizeof(qpzone_bucket_t)];
|
|
|
|
qpzonedb_t *qpdb = (qpzonedb_t *)&qpdb_s;
|
|
|
|
*qpdb = (qpzonedb_t){
|
2023-11-29 13:29:08 -08:00
|
|
|
.common.methods = &qpdb_zonemethods,
|
2025-07-15 12:56:04 +02:00
|
|
|
.common.mctx = isc_g_mctx,
|
2023-11-29 13:29:08 -08:00
|
|
|
};
|
Decouple database and node lifetimes by adding node-specific vtables
All databases in the codebase follow the same structure: a database is
an associative container from DNS names to nodes, and each node is an
associative container from RR types to RR data.
Each database implementation (qpzone, qpcache, sdlz, builtin, dyndb) has
its own corresponding node type (qpznode, qpcnode, etc). However, some
code needs to work with nodes generically regardless of their specific
type - for example, to acquire locks, manage references, or
register/unregister slabs from the heap.
Currently, these generic node operations are implemented as methods in
the database vtable, which creates problematic coupling between database
and node lifetimes. If a node outlives its parent database, the node
destructor will destroy all RR data, and each RR data destructor will
try to unregister from heaps by calling a virtual function from the
database vtable. Since the database was already freed, this causes a
crash.
This commit breaks the coupling by standardizing the layout of all
database nodes, adding a dedicated vtable for node operations, and
moving node-specific methods from the database vtable to the node
vtable.
2025-06-05 11:51:29 +02:00
|
|
|
qpznode_t node = { .methods = &qpznode_methods, .locknum = 0 };
|
2023-11-29 13:29:08 -08:00
|
|
|
dns_slabheader_t header = {
|
2024-11-05 16:13:10 +01:00
|
|
|
.node = (dns_dbnode_t *)&node,
|
2023-11-29 13:29:08 -08:00
|
|
|
};
|
|
|
|
unsigned char *raw = (unsigned char *)(&header) + sizeof(header);
|
|
|
|
dns_rdataset_t rdataset = {
|
|
|
|
.magic = DNS_RDATASET_MAGIC,
|
2025-02-04 16:50:27 +01:00
|
|
|
.slab = { .db = (dns_db_t *)qpdb,
|
2024-11-05 16:13:10 +01:00
|
|
|
.node = (dns_dbnode_t *)&node,
|
|
|
|
.raw = raw,
|
|
|
|
},
|
2023-11-29 13:29:08 -08:00
|
|
|
.methods = &dns_rdataslab_rdatasetmethods,
|
|
|
|
};
|
|
|
|
isc_buffer_t b;
|
|
|
|
dns_fixedname_t fname1, fname2;
|
|
|
|
dns_name_t *name1 = dns_fixedname_initname(&fname1);
|
|
|
|
dns_name_t *name2 = dns_fixedname_initname(&fname2);
|
|
|
|
|
|
|
|
/* Minimal initialization of the mock objects */
|
|
|
|
isc_buffer_constinit(&b, str1, strlen(str1));
|
|
|
|
isc_buffer_add(&b, strlen(str1));
|
2025-02-22 00:11:38 -08:00
|
|
|
result = dns_name_fromtext(name1, &b, dns_rootname, 0);
|
2023-11-29 13:29:08 -08:00
|
|
|
assert_int_equal(result, ISC_R_SUCCESS);
|
|
|
|
|
|
|
|
isc_buffer_constinit(&b, str2, strlen(str2));
|
|
|
|
isc_buffer_add(&b, strlen(str2));
|
2025-02-22 00:11:38 -08:00
|
|
|
result = dns_name_fromtext(name2, &b, dns_rootname, 0);
|
2023-11-29 13:29:08 -08:00
|
|
|
assert_int_equal(result, ISC_R_SUCCESS);
|
|
|
|
|
|
|
|
/* Store the case from name1 */
|
|
|
|
dns_rdataset_setownercase(&rdataset, name1);
|
|
|
|
|
|
|
|
assert_true(CASESET(&header));
|
|
|
|
|
|
|
|
/* Retrieve the case to name2 */
|
|
|
|
dns_rdataset_getownercase(&rdataset, name2);
|
|
|
|
|
|
|
|
return dns_name_caseequal(name1, name2);
|
|
|
|
}
|
|
|
|
|
|
|
|
ISC_RUN_TEST_IMPL(ownercase) {
|
|
|
|
UNUSED(state);
|
|
|
|
|
|
|
|
for (size_t n = 0; n < ARRAY_SIZE(ownercase_vectors); n++) {
|
|
|
|
assert_true(ownercase_test_one(ownercase_vectors[n][0],
|
|
|
|
ownercase_vectors[n][1]));
|
|
|
|
}
|
|
|
|
|
|
|
|
assert_false(ownercase_test_one("W.example.org", "\\000.example.org"));
|
|
|
|
|
|
|
|
/* Ö and ö in ISO Latin 1 */
|
|
|
|
assert_false(ownercase_test_one("\\216", "\\246"));
|
|
|
|
}
|
|
|
|
|
|
|
|
ISC_RUN_TEST_IMPL(setownercase) {
|
|
|
|
isc_result_t result;
|
2025-02-04 16:50:27 +01:00
|
|
|
uint8_t qpdb_s[sizeof(qpzonedb_t) + sizeof(qpzone_bucket_t)];
|
|
|
|
qpzonedb_t *qpdb = (qpzonedb_t *)&qpdb_s;
|
|
|
|
*qpdb = (qpzonedb_t){
|
2023-11-29 13:29:08 -08:00
|
|
|
.common.methods = &qpdb_zonemethods,
|
2025-07-15 12:56:04 +02:00
|
|
|
.common.mctx = isc_g_mctx,
|
2023-11-29 13:29:08 -08:00
|
|
|
};
|
Decouple database and node lifetimes by adding node-specific vtables
All databases in the codebase follow the same structure: a database is
an associative container from DNS names to nodes, and each node is an
associative container from RR types to RR data.
Each database implementation (qpzone, qpcache, sdlz, builtin, dyndb) has
its own corresponding node type (qpznode, qpcnode, etc). However, some
code needs to work with nodes generically regardless of their specific
type - for example, to acquire locks, manage references, or
register/unregister slabs from the heap.
Currently, these generic node operations are implemented as methods in
the database vtable, which creates problematic coupling between database
and node lifetimes. If a node outlives its parent database, the node
destructor will destroy all RR data, and each RR data destructor will
try to unregister from heaps by calling a virtual function from the
database vtable. Since the database was already freed, this causes a
crash.
This commit breaks the coupling by standardizing the layout of all
database nodes, adding a dedicated vtable for node operations, and
moving node-specific methods from the database vtable to the node
vtable.
2025-06-05 11:51:29 +02:00
|
|
|
qpznode_t node = { .methods = &qpznode_methods, .locknum = 0 };
|
2023-11-29 13:29:08 -08:00
|
|
|
dns_slabheader_t header = {
|
2024-11-05 16:13:10 +01:00
|
|
|
.node = (dns_dbnode_t *)&node,
|
2023-11-29 13:29:08 -08:00
|
|
|
};
|
|
|
|
unsigned char *raw = (unsigned char *)(&header) + sizeof(header);
|
|
|
|
dns_rdataset_t rdataset = {
|
|
|
|
.magic = DNS_RDATASET_MAGIC,
|
2025-02-04 16:50:27 +01:00
|
|
|
.slab = { .db = (dns_db_t *)qpdb,
|
2024-11-05 16:13:10 +01:00
|
|
|
.node = (dns_dbnode_t *)&node,
|
|
|
|
.raw = raw,
|
|
|
|
},
|
2023-11-29 13:29:08 -08:00
|
|
|
.methods = &dns_rdataslab_rdatasetmethods,
|
|
|
|
};
|
|
|
|
const char *str1 =
|
|
|
|
"AaBbCcDdEeFfGgHhIiJjKkLlMmNnOoPpQqRrSsTtUuVvWwXxYyZz";
|
|
|
|
isc_buffer_t b;
|
|
|
|
dns_fixedname_t fname1, fname2;
|
|
|
|
dns_name_t *name1 = dns_fixedname_initname(&fname1);
|
|
|
|
dns_name_t *name2 = dns_fixedname_initname(&fname2);
|
|
|
|
|
|
|
|
UNUSED(state);
|
|
|
|
|
|
|
|
/* Minimal initialization of the mock objects */
|
|
|
|
isc_buffer_constinit(&b, str1, strlen(str1));
|
|
|
|
isc_buffer_add(&b, strlen(str1));
|
2025-02-22 00:11:38 -08:00
|
|
|
result = dns_name_fromtext(name1, &b, dns_rootname, 0);
|
2023-11-29 13:29:08 -08:00
|
|
|
assert_int_equal(result, ISC_R_SUCCESS);
|
|
|
|
|
|
|
|
isc_buffer_constinit(&b, str1, strlen(str1));
|
|
|
|
isc_buffer_add(&b, strlen(str1));
|
2025-02-22 00:11:38 -08:00
|
|
|
result = dns_name_fromtext(name2, &b, dns_rootname, 0);
|
2023-11-29 13:29:08 -08:00
|
|
|
assert_int_equal(result, ISC_R_SUCCESS);
|
|
|
|
|
|
|
|
assert_false(CASESET(&header));
|
|
|
|
|
|
|
|
/* Retrieve the case to name2 */
|
|
|
|
dns_rdataset_getownercase(&rdataset, name2);
|
|
|
|
|
|
|
|
assert_true(dns_name_caseequal(name1, name2));
|
|
|
|
}
|
|
|
|
|
|
|
|
ISC_TEST_LIST_START
|
|
|
|
ISC_TEST_ENTRY(ownercase)
|
|
|
|
ISC_TEST_ENTRY(setownercase)
|
|
|
|
ISC_TEST_LIST_END
|
|
|
|
|
|
|
|
ISC_TEST_MAIN
|