2022-07-26 13:03:48 +02:00
|
|
|
/*
|
|
|
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
|
|
|
*
|
|
|
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
|
|
|
*
|
|
|
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
|
*
|
|
|
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
|
|
|
* information regarding copyright ownership.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <isc/atomic.h>
|
|
|
|
|
#include <isc/netmgr.h>
|
|
|
|
|
#include <isc/refcount.h>
|
|
|
|
|
#include <isc/thread.h>
|
2023-01-10 10:20:44 +01:00
|
|
|
#include <isc/util.h>
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
#include "netmgr/netmgr-int.h"
|
|
|
|
|
|
2022-10-11 12:03:17 +02:00
|
|
|
/*
|
|
|
|
|
* Pick unused port outside the ephemeral port range, so we don't clash with
|
|
|
|
|
* connected sockets.
|
|
|
|
|
*/
|
|
|
|
|
#define UDP_TEST_PORT 9153
|
|
|
|
|
#define TCP_TEST_PORT 9154
|
|
|
|
|
#define TLS_TEST_PORT 9155
|
|
|
|
|
#define TCPDNS_TEST_PORT 9156
|
|
|
|
|
#define TLSDNS_TEST_PORT 9157
|
|
|
|
|
|
2022-07-26 13:03:48 +02:00
|
|
|
typedef void (*stream_connect_function)(isc_nm_t *nm);
|
|
|
|
|
typedef void (*connect_func)(isc_nm_t *);
|
|
|
|
|
|
|
|
|
|
extern isc_nm_t *listen_nm;
|
|
|
|
|
extern isc_nm_t *connect_nm;
|
|
|
|
|
|
|
|
|
|
extern isc_sockaddr_t tcp_listen_addr;
|
|
|
|
|
extern isc_sockaddr_t tcp_connect_addr;
|
|
|
|
|
extern isc_tlsctx_t *tcp_listen_tlsctx;
|
|
|
|
|
extern isc_tlsctx_t *tcp_connect_tlsctx;
|
|
|
|
|
extern isc_tlsctx_client_session_cache_t *tcp_tlsctx_client_sess_cache;
|
|
|
|
|
|
|
|
|
|
extern uint64_t send_magic;
|
|
|
|
|
extern uint64_t stop_magic;
|
|
|
|
|
|
|
|
|
|
extern isc_region_t send_msg;
|
|
|
|
|
extern isc_region_t stop_msg;
|
|
|
|
|
|
|
|
|
|
extern atomic_bool do_send;
|
|
|
|
|
|
|
|
|
|
extern atomic_int_fast64_t nsends;
|
|
|
|
|
extern int_fast64_t esends; /* expected sends */
|
|
|
|
|
|
|
|
|
|
extern atomic_int_fast64_t ssends;
|
|
|
|
|
extern atomic_int_fast64_t sreads;
|
|
|
|
|
extern atomic_int_fast64_t saccepts;
|
|
|
|
|
|
|
|
|
|
extern atomic_int_fast64_t cconnects;
|
|
|
|
|
extern atomic_int_fast64_t csends;
|
|
|
|
|
extern atomic_int_fast64_t creads;
|
|
|
|
|
extern atomic_int_fast64_t ctimeouts;
|
|
|
|
|
|
|
|
|
|
extern int expected_ssends;
|
|
|
|
|
extern int expected_sreads;
|
|
|
|
|
extern int expected_csends;
|
|
|
|
|
extern int expected_cconnects;
|
|
|
|
|
extern int expected_creads;
|
|
|
|
|
extern int expected_ctimeouts;
|
|
|
|
|
|
|
|
|
|
extern bool ssends_shutdown;
|
|
|
|
|
extern bool sreads_shutdown;
|
|
|
|
|
extern bool csends_shutdown;
|
|
|
|
|
extern bool cconnects_shutdown;
|
|
|
|
|
extern bool creads_shutdown;
|
|
|
|
|
extern bool ctimeouts_shutdown;
|
|
|
|
|
|
|
|
|
|
#define have_expected_ssends(v) ((v) >= expected_ssends && expected_ssends >= 0)
|
|
|
|
|
#define have_expected_sreads(v) ((v) >= expected_sreads && expected_sreads >= 0)
|
|
|
|
|
#define have_expected_saccepts(v) \
|
|
|
|
|
((v) >= expected_saccepts && expected_saccepts >= 0)
|
|
|
|
|
#define have_expected_csends(v) ((v) >= expected_csends && expected_csends >= 0)
|
|
|
|
|
#define have_expected_cconnects(v) \
|
|
|
|
|
((v) >= expected_cconnects && expected_cconnects >= 0)
|
|
|
|
|
#define have_expected_creads(v) ((v) >= expected_creads && expected_creads >= 0)
|
|
|
|
|
#define have_expected_ctimeouts(v) \
|
|
|
|
|
((v) >= expected_ctimeouts && expected_ctimeouts >= 0)
|
|
|
|
|
|
|
|
|
|
#define do_ssends_shutdown(lm) \
|
|
|
|
|
if (ssends_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
#define do_sreads_shutdown(lm) \
|
|
|
|
|
if (sreads_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
#define do_saccepts_shutdown(lm) \
|
|
|
|
|
if (saccepts_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
#define do_csends_shutdown(lm) \
|
|
|
|
|
if (csends_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
#define do_cconnects_shutdown(lm) \
|
|
|
|
|
if (cconnects_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
#define do_creads_shutdown(lm) \
|
|
|
|
|
if (creads_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
#define do_ctimeouts_shutdown(lm) \
|
|
|
|
|
if (ctimeouts_shutdown) { \
|
|
|
|
|
isc_loopmgr_shutdown(lm); \
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
extern isc_refcount_t active_cconnects;
|
|
|
|
|
extern isc_refcount_t active_csends;
|
|
|
|
|
extern isc_refcount_t active_creads;
|
|
|
|
|
extern isc_refcount_t active_ssends;
|
|
|
|
|
extern isc_refcount_t active_sreads;
|
|
|
|
|
|
|
|
|
|
extern isc_nmsocket_t *listen_sock;
|
|
|
|
|
|
|
|
|
|
extern isc_quota_t listener_quota;
|
|
|
|
|
extern atomic_bool check_listener_quota;
|
|
|
|
|
|
|
|
|
|
extern bool allow_send_back;
|
|
|
|
|
extern bool noanswer;
|
|
|
|
|
extern bool stream_use_TLS;
|
2022-08-29 10:55:10 +02:00
|
|
|
extern bool stream;
|
2022-10-11 12:03:17 +02:00
|
|
|
extern in_port_t stream_port;
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
extern isc_nm_recv_cb_t connect_readcb;
|
|
|
|
|
|
|
|
|
|
#define NSENDS 100
|
|
|
|
|
|
|
|
|
|
/* Timeout for soft-timeout tests (0.05 seconds) */
|
|
|
|
|
#define T_SOFT 50
|
|
|
|
|
|
|
|
|
|
/* Timeouts in miliseconds */
|
|
|
|
|
#define T_INIT 120 * 1000
|
|
|
|
|
#define T_IDLE 120 * 1000
|
|
|
|
|
#define T_KEEPALIVE 120 * 1000
|
|
|
|
|
#define T_ADVERTISED 120 * 1000
|
|
|
|
|
#define T_CONNECT 30 * 1000
|
|
|
|
|
|
|
|
|
|
/* Wait for 1 second (1000 milliseconds) */
|
|
|
|
|
#define WAIT_REPEATS 1000
|
|
|
|
|
#define T_WAIT 1 /* 1 millisecond */
|
|
|
|
|
|
|
|
|
|
#define WAIT_FOR(v, op, val) \
|
|
|
|
|
{ \
|
|
|
|
|
X(v); \
|
|
|
|
|
int_fast64_t __r = WAIT_REPEATS; \
|
|
|
|
|
int_fast64_t __o = 0; \
|
|
|
|
|
do { \
|
|
|
|
|
int_fast64_t __l = atomic_load(&v); \
|
|
|
|
|
if (__l op val) { \
|
|
|
|
|
break; \
|
|
|
|
|
}; \
|
|
|
|
|
if (__o == __l) { \
|
|
|
|
|
__r--; \
|
|
|
|
|
} else { \
|
|
|
|
|
__r = WAIT_REPEATS; \
|
|
|
|
|
} \
|
|
|
|
|
__o = __l; \
|
|
|
|
|
uv_sleep(T_WAIT); \
|
|
|
|
|
} while (__r > 0); \
|
|
|
|
|
X(v); \
|
|
|
|
|
P(__r); \
|
|
|
|
|
assert_true(atomic_load(&v) op val); \
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#define WAIT_FOR_EQ(v, val) WAIT_FOR(v, ==, val)
|
|
|
|
|
#define WAIT_FOR_NE(v, val) WAIT_FOR(v, !=, val)
|
|
|
|
|
#define WAIT_FOR_LE(v, val) WAIT_FOR(v, <=, val)
|
|
|
|
|
#define WAIT_FOR_LT(v, val) WAIT_FOR(v, <, val)
|
|
|
|
|
#define WAIT_FOR_GE(v, val) WAIT_FOR(v, >=, val)
|
|
|
|
|
#define WAIT_FOR_GT(v, val) WAIT_FOR(v, >, val)
|
|
|
|
|
|
|
|
|
|
#define DONE() atomic_store(&do_send, false);
|
|
|
|
|
|
|
|
|
|
#define CHECK_RANGE_FULL(v) \
|
|
|
|
|
{ \
|
|
|
|
|
int __v = atomic_load(&v); \
|
|
|
|
|
assert_true(__v > 1); \
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#define CHECK_RANGE_HALF(v) \
|
|
|
|
|
{ \
|
|
|
|
|
int __v = atomic_load(&v); \
|
|
|
|
|
assert_true(__v > 1); \
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Enable this to print values while running tests */
|
|
|
|
|
#undef PRINT_DEBUG
|
|
|
|
|
#ifdef PRINT_DEBUG
|
|
|
|
|
#define X(v) \
|
|
|
|
|
fprintf(stderr, "%s:%s:%d:%s = %" PRId64 "\n", __func__, __FILE__, \
|
|
|
|
|
__LINE__, #v, atomic_load(&v))
|
|
|
|
|
#define P(v) fprintf(stderr, #v " = %" PRId64 "\n", v)
|
Fix the streaming read callback shutdown logic
When shutting down TCP sockets, the read callback calling logic was
flawed, it would call either one less callback or one extra. Fix the
logic in the way:
1. When isc_nm_read() has been called but isc_nm_read_stop() hasn't on
the handle, the read callback will be called with ISC_R_CANCELED to
cancel active reading from the socket/handle.
2. When isc_nm_read() has been called and isc_nm_read_stop() has been
called on the on the handle, the read callback will be called with
ISC_R_SHUTTINGDOWN to signal that the dormant (not-reading) socket
is being shut down.
3. The .reading and .recv_read flags are little bit tricky. The
.reading flag indicates if the outer layer is reading the data (that
would be uv_tcp_t for TCP and isc_nmsocket_t (TCP) for TLSStream),
the .recv_read flag indicates whether somebody is interested in the
data read from the socket.
Usually, you would expect that the .reading should be false when
.recv_read is false, but it gets even more tricky with TLSStream as
the TLS protocol might need to read from the socket even when sending
data.
Fix the usage of the .recv_read and .reading flags in the TLSStream
to their true meaning - which mostly consist of using .recv_read
everywhere and then wrapping isc_nm_read() and isc_nm_read_stop()
with the .reading flag.
4. The TLS failed read helper has been modified to resemble the TCP code
as much as possible, clearing and re-setting the .recv_read flag in
the TCP timeout code has been fixed and .recv_read is now cleared
when isc_nm_read_stop() has been called on the streaming socket.
5. The use of Network Manager in the named_controlconf, isccc_ccmsg, and
isc_httpd units have been greatly simplified due to the improved design.
6. More unit tests for TCP and TLS testing the shutdown conditions have
been added.
Co-authored-by: Ondřej Surý <ondrej@isc.org>
Co-authored-by: Artem Boldariev <artem@isc.org>
2023-04-13 17:27:50 +02:00
|
|
|
#define F() \
|
|
|
|
|
fprintf(stderr, "%u:%s(%p, %s, %p)\n", isc_tid(), __func__, handle, \
|
2022-07-26 13:03:48 +02:00
|
|
|
isc_result_totext(eresult), cbarg)
|
|
|
|
|
|
Fix the streaming read callback shutdown logic
When shutting down TCP sockets, the read callback calling logic was
flawed, it would call either one less callback or one extra. Fix the
logic in the way:
1. When isc_nm_read() has been called but isc_nm_read_stop() hasn't on
the handle, the read callback will be called with ISC_R_CANCELED to
cancel active reading from the socket/handle.
2. When isc_nm_read() has been called and isc_nm_read_stop() has been
called on the on the handle, the read callback will be called with
ISC_R_SHUTTINGDOWN to signal that the dormant (not-reading) socket
is being shut down.
3. The .reading and .recv_read flags are little bit tricky. The
.reading flag indicates if the outer layer is reading the data (that
would be uv_tcp_t for TCP and isc_nmsocket_t (TCP) for TLSStream),
the .recv_read flag indicates whether somebody is interested in the
data read from the socket.
Usually, you would expect that the .reading should be false when
.recv_read is false, but it gets even more tricky with TLSStream as
the TLS protocol might need to read from the socket even when sending
data.
Fix the usage of the .recv_read and .reading flags in the TLSStream
to their true meaning - which mostly consist of using .recv_read
everywhere and then wrapping isc_nm_read() and isc_nm_read_stop()
with the .reading flag.
4. The TLS failed read helper has been modified to resemble the TCP code
as much as possible, clearing and re-setting the .recv_read flag in
the TCP timeout code has been fixed and .recv_read is now cleared
when isc_nm_read_stop() has been called on the streaming socket.
5. The use of Network Manager in the named_controlconf, isccc_ccmsg, and
isc_httpd units have been greatly simplified due to the improved design.
6. More unit tests for TCP and TLS testing the shutdown conditions have
been added.
Co-authored-by: Ondřej Surý <ondrej@isc.org>
Co-authored-by: Artem Boldariev <artem@isc.org>
2023-04-13 17:27:50 +02:00
|
|
|
#define isc_loopmgr_shutdown(loopmgr) \
|
|
|
|
|
{ \
|
|
|
|
|
fprintf(stderr, "%u:%s:%s:%d:isc_loopmgr_shutdown(%p)\n", \
|
|
|
|
|
isc_tid(), __func__, __FILE__, __LINE__, loopmgr); \
|
|
|
|
|
isc_loopmgr_shutdown(loopmgr); \
|
2022-07-26 13:03:48 +02:00
|
|
|
}
|
|
|
|
|
#else
|
|
|
|
|
#define X(v)
|
|
|
|
|
#define P(v)
|
|
|
|
|
#define F()
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
#define atomic_assert_int_eq(val, exp) assert_int_equal(atomic_load(&val), exp)
|
|
|
|
|
#define atomic_assert_int_ne(val, exp) \
|
|
|
|
|
assert_int_not_equal(atomic_load(&val), exp)
|
|
|
|
|
#define atomic_assert_int_le(val, exp) assert_true(atomic_load(&val) <= exp)
|
|
|
|
|
#define atomic_assert_int_lt(val, exp) assert_true(atomic_load(&val) > exp)
|
|
|
|
|
#define atomic_assert_int_ge(val, exp) assert_true(atomic_load(&val) >= exp)
|
|
|
|
|
#define atomic_assert_int_gt(val, exp) assert_true(atomic_load(&val) > exp)
|
|
|
|
|
|
|
|
|
|
int
|
|
|
|
|
setup_netmgr_test(void **state);
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
teardown_netmgr_test(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
void
|
|
|
|
|
noop_recv_cb(isc_nmhandle_t *handle, isc_result_t eresult, isc_region_t *region,
|
|
|
|
|
void *cbarg);
|
|
|
|
|
|
Fix the streaming read callback shutdown logic
When shutting down TCP sockets, the read callback calling logic was
flawed, it would call either one less callback or one extra. Fix the
logic in the way:
1. When isc_nm_read() has been called but isc_nm_read_stop() hasn't on
the handle, the read callback will be called with ISC_R_CANCELED to
cancel active reading from the socket/handle.
2. When isc_nm_read() has been called and isc_nm_read_stop() has been
called on the on the handle, the read callback will be called with
ISC_R_SHUTTINGDOWN to signal that the dormant (not-reading) socket
is being shut down.
3. The .reading and .recv_read flags are little bit tricky. The
.reading flag indicates if the outer layer is reading the data (that
would be uv_tcp_t for TCP and isc_nmsocket_t (TCP) for TLSStream),
the .recv_read flag indicates whether somebody is interested in the
data read from the socket.
Usually, you would expect that the .reading should be false when
.recv_read is false, but it gets even more tricky with TLSStream as
the TLS protocol might need to read from the socket even when sending
data.
Fix the usage of the .recv_read and .reading flags in the TLSStream
to their true meaning - which mostly consist of using .recv_read
everywhere and then wrapping isc_nm_read() and isc_nm_read_stop()
with the .reading flag.
4. The TLS failed read helper has been modified to resemble the TCP code
as much as possible, clearing and re-setting the .recv_read flag in
the TCP timeout code has been fixed and .recv_read is now cleared
when isc_nm_read_stop() has been called on the streaming socket.
5. The use of Network Manager in the named_controlconf, isccc_ccmsg, and
isc_httpd units have been greatly simplified due to the improved design.
6. More unit tests for TCP and TLS testing the shutdown conditions have
been added.
Co-authored-by: Ondřej Surý <ondrej@isc.org>
Co-authored-by: Artem Boldariev <artem@isc.org>
2023-04-13 17:27:50 +02:00
|
|
|
isc_result_t
|
|
|
|
|
noop_accept_cb(isc_nmhandle_t *handle ISC_ATTR_UNUSED, unsigned int result,
|
|
|
|
|
void *cbarg ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
void
|
|
|
|
|
connect_send_cb(isc_nmhandle_t *handle, isc_result_t eresult, void *cbarg);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
connect_send(isc_nmhandle_t *handle);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
connect_read_cb(isc_nmhandle_t *handle, isc_result_t eresult,
|
|
|
|
|
isc_region_t *region, void *cbarg);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
connect_connect_cb(isc_nmhandle_t *handle, isc_result_t eresult, void *cbarg);
|
|
|
|
|
void
|
|
|
|
|
connect_success_cb(isc_nmhandle_t *handle, isc_result_t eresult, void *cbarg);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
listen_send_cb(isc_nmhandle_t *handle, isc_result_t eresult, void *cbarg);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
listen_read_cb(isc_nmhandle_t *handle, isc_result_t eresult,
|
|
|
|
|
isc_region_t *region, void *cbarg);
|
|
|
|
|
|
|
|
|
|
isc_result_t
|
|
|
|
|
listen_accept_cb(isc_nmhandle_t *handle, isc_result_t eresult, void *cbarg);
|
|
|
|
|
|
|
|
|
|
isc_result_t
|
|
|
|
|
stream_accept_cb(isc_nmhandle_t *handle, isc_result_t eresult, void *cbarg);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
timeout_retry_cb(isc_nmhandle_t *handle, isc_result_t eresult,
|
|
|
|
|
isc_region_t *region, void *cbarg);
|
|
|
|
|
|
|
|
|
|
isc_quota_t *
|
|
|
|
|
tcp_listener_init_quota(size_t nthreads);
|
|
|
|
|
|
|
|
|
|
stream_connect_function
|
|
|
|
|
get_stream_connect_function(void);
|
|
|
|
|
|
|
|
|
|
isc_result_t
|
|
|
|
|
stream_listen(isc_nm_accept_cb_t accept_cb, void *accept_cbarg, int backlog,
|
|
|
|
|
isc_quota_t *quota, isc_nmsocket_t **sockp);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
stream_connect(isc_nm_cb_t cb, void *cbarg, unsigned int timeout);
|
|
|
|
|
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_noop_setup(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_noop(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_noop_teardown(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_noresponse_setup(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_noresponse(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_noresponse_teardown(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_timeout_recovery_setup(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_timeout_recovery(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_timeout_recovery_teardown(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_one_setup(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_one(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_one_teardown(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_two_setup(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_two(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_two_teardown(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
|
|
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_send_setup(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_send(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
int
|
2023-01-10 10:20:44 +01:00
|
|
|
stream_recv_send_teardown(void **state ISC_ATTR_UNUSED);
|
2022-07-26 13:03:48 +02:00
|
|
|
void
|
|
|
|
|
stream_recv_send_connect(void *arg);
|
Fix the streaming read callback shutdown logic
When shutting down TCP sockets, the read callback calling logic was
flawed, it would call either one less callback or one extra. Fix the
logic in the way:
1. When isc_nm_read() has been called but isc_nm_read_stop() hasn't on
the handle, the read callback will be called with ISC_R_CANCELED to
cancel active reading from the socket/handle.
2. When isc_nm_read() has been called and isc_nm_read_stop() has been
called on the on the handle, the read callback will be called with
ISC_R_SHUTTINGDOWN to signal that the dormant (not-reading) socket
is being shut down.
3. The .reading and .recv_read flags are little bit tricky. The
.reading flag indicates if the outer layer is reading the data (that
would be uv_tcp_t for TCP and isc_nmsocket_t (TCP) for TLSStream),
the .recv_read flag indicates whether somebody is interested in the
data read from the socket.
Usually, you would expect that the .reading should be false when
.recv_read is false, but it gets even more tricky with TLSStream as
the TLS protocol might need to read from the socket even when sending
data.
Fix the usage of the .recv_read and .reading flags in the TLSStream
to their true meaning - which mostly consist of using .recv_read
everywhere and then wrapping isc_nm_read() and isc_nm_read_stop()
with the .reading flag.
4. The TLS failed read helper has been modified to resemble the TCP code
as much as possible, clearing and re-setting the .recv_read flag in
the TCP timeout code has been fixed and .recv_read is now cleared
when isc_nm_read_stop() has been called on the streaming socket.
5. The use of Network Manager in the named_controlconf, isccc_ccmsg, and
isc_httpd units have been greatly simplified due to the improved design.
6. More unit tests for TCP and TLS testing the shutdown conditions have
been added.
Co-authored-by: Ondřej Surý <ondrej@isc.org>
Co-authored-by: Artem Boldariev <artem@isc.org>
2023-04-13 17:27:50 +02:00
|
|
|
|
|
|
|
|
int
|
|
|
|
|
stream_shutdownconnect_setup(void **state ISC_ATTR_UNUSED);
|
|
|
|
|
void
|
|
|
|
|
stream_shutdownconnect(void **state ISC_ATTR_UNUSED);
|
|
|
|
|
int
|
|
|
|
|
stream_shutdownconnect_teardown(void **state ISC_ATTR_UNUSED);
|
|
|
|
|
|
|
|
|
|
int
|
|
|
|
|
stream_shutdownread_setup(void **state ISC_ATTR_UNUSED);
|
|
|
|
|
void
|
|
|
|
|
stream_shutdownread(void **state ISC_ATTR_UNUSED);
|
|
|
|
|
int
|
|
|
|
|
stream_shutdownread_teardown(void **state ISC_ATTR_UNUSED);
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
stop_listening(void *arg ISC_ATTR_UNUSED);
|