From 00a09e0d35b2da327b178baf9864a96e469062e2 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Wed, 9 Aug 2023 15:20:36 +1000 Subject: [PATCH] Only set key->engine if engine != NULL --- lib/dns/openssleddsa_link.c | 2 +- lib/dns/opensslrsa_link.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dns/openssleddsa_link.c b/lib/dns/openssleddsa_link.c index f6d1fa3a14..7e976a7756 100644 --- a/lib/dns/openssleddsa_link.c +++ b/lib/dns/openssleddsa_link.c @@ -527,7 +527,7 @@ openssleddsa_fromlabel(dst_key_t *key, const char *engine, const char *label, goto err; } - if (key->engine != NULL) { + if (engine != NULL) { key->engine = isc_mem_strdup(key->mctx, engine); } key->label = isc_mem_strdup(key->mctx, label); diff --git a/lib/dns/opensslrsa_link.c b/lib/dns/opensslrsa_link.c index 54ab04dcf7..79cae64add 100644 --- a/lib/dns/opensslrsa_link.c +++ b/lib/dns/opensslrsa_link.c @@ -1051,7 +1051,7 @@ opensslrsa_fromlabel(dst_key_t *key, const char *engine, const char *label, DST_RET(ISC_R_RANGE); } - if (key->engine != NULL) { + if (engine != NULL) { key->engine = isc_mem_strdup(key->mctx, engine); } key->label = isc_mem_strdup(key->mctx, label);