mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 15:05:23 +00:00
Code Issues Releases Wiki Activity

'closest' must be non NULL, remove test.

Browse Source 
6412 cleanup:
6413        dns_rdataset_disassociate(&neg);
6414        dns_rdataset_disassociate(&negsig);

	CID 1452700 (#1 of 1): Dereference before null check (REVERSE_INULL)
	check_after_deref: Null-checking closest suggests that it
	may be null, but it has already been dereferenced on all
	paths leading to the check.

6415        if (closest != NULL)
6416                free_noqname(mctx, &closest);
This commit is contained in:
Mark Andrews
2020-02-05 16:37:33 +11:00
parent d64921848d
commit 0312e73e16
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/dns/rbtdb.c
View File

@@ -6412,8 +6412,7 @@ addclosest(dns_rbtdb_t *rbtdb, rdatasetheader_t *newheader,
cleanup: cleanup:
dns_rdataset_disassociate(&neg); dns_rdataset_disassociate(&neg);
dns_rdataset_disassociate(&negsig); dns_rdataset_disassociate(&negsig);
if (closest != NULL) free_noqname(mctx, &closest);
free_noqname(mctx, &closest);
return(result); return(result);
} }