From f1ee5e4a166b84bc0ae23dc3eddf251a10d85fac Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Wed, 27 Jun 2018 11:10:59 +1000 Subject: [PATCH] cfg_parse_boolean's REQUIRE test for ret was incomplete. --- lib/isccfg/parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/isccfg/parser.c b/lib/isccfg/parser.c index b9eb914928..3a10d713f6 100644 --- a/lib/isccfg/parser.c +++ b/lib/isccfg/parser.c @@ -1304,7 +1304,7 @@ cfg_parse_boolean(cfg_parser_t *pctx, const cfg_type_t *type, cfg_obj_t **ret) cfg_obj_t *obj = NULL; REQUIRE(pctx != NULL); - REQUIRE(ret != NULL && ret != NULL); + REQUIRE(ret != NULL && *ret == NULL); UNUSED(type);