From 063e05491b9f9ea72c8324ea3ff5bb6e0d59642f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 15 Apr 2020 12:28:53 +0200 Subject: [PATCH] Disable C4090 MSVC warning MSVC documentation states: "This warning can be caused when a pointer to a const or volatile item is assigned to a pointer not declared as pointing to const or volatile." Unfortunately, this happens when we dynamically allocate and deallocate block of atomic variables using isc_mem_get and isc_mem_put. Couple of examples: lib\isc\hp.c(134): warning C4090: 'function': different 'volatile' qualifiers [C:\builds\isc-projects\bind9\lib\isc\win32\libisc.vcxproj] lib\isc\hp.c(144): warning C4090: 'function': different 'volatile' qualifiers [C:\builds\isc-projects\bind9\lib\isc\win32\libisc.vcxproj] lib\isc\stats.c(55): warning C4090: 'function': different 'volatile' qualifiers [C:\builds\isc-projects\bind9\lib\isc\win32\libisc.vcxproj] lib\isc\stats.c(87): warning C4090: 'function': different 'volatile' qualifiers [C:\builds\isc-projects\bind9\lib\isc\win32\libisc.vcxproj] --- lib/isc/win32/include/isc/stdatomic.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/isc/win32/include/isc/stdatomic.h b/lib/isc/win32/include/isc/stdatomic.h index 0fccf4600c..eb22a80665 100644 --- a/lib/isc/win32/include/isc/stdatomic.h +++ b/lib/isc/win32/include/isc/stdatomic.h @@ -19,6 +19,7 @@ #include #pragma warning(disable : 4133) +#pragma warning(disable : 4090) #define InterlockedExchangeAdd8 _InterlockedExchangeAdd8 #define InterlockedCompareExchange8 _InterlockedCompareExchange8