mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 14:35:26 +00:00
Code Issues Releases Wiki Activity

Return the old counter value in isc_stats_increment

Browse Source 
Returning the value allows for better high-water tracking without
running into edge cases like the following:

0. The counter is at value X
1. Increment the value (X+1)
2. The value is decreased multiple times in another threads (X+1-Y)
3. Get the value (X+1-Y)
4. Update-if-greater misses the X+1 value which should have been the
   high-water
This commit is contained in:
Aydın Mercan
2024-04-30 14:37:26 +03:00
parent ced011f05a
commit 09e4fb2ffa
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ns/include/ns/stats.h
View File

@@ -124,7 +124,7 @@ ns_stats_detach(ns_stats_t **statsp);
void
ns_stats_create(isc_mem_t *mctx, int ncounters, ns_stats_t **statsp);
void
isc_statscounter_t
ns_stats_increment(ns_stats_t *stats, isc_statscounter_t counter);
void

4
lib/ns/stats.c
View File

@@ -78,11 +78,11 @@ ns_stats_create(isc_mem_t *mctx, int ncounters, ns_stats_t **statsp) {
/*%
* Increment/Decrement methods
*/
void
isc_statscounter_t
ns_stats_increment(ns_stats_t *stats, isc_statscounter_t counter) {
REQUIRE(NS_STATS_VALID(stats));
isc_stats_increment(stats->counters, counter);
return (isc_stats_increment(stats->counters, counter));
}
void