From 0a9a3d8c6daf9ffcfb62dbe366e26f521cbb9736 Mon Sep 17 00:00:00 2001 From: Brian Wellington Date: Fri, 15 Jun 2001 02:24:02 +0000 Subject: [PATCH] 904. [bug] The server would leak memory if attempting to use an expired TSIG key. [RT #1406] --- CHANGES | 3 +++ lib/dns/tsig.c | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index 6bfa75a83e..b6022f48ef 100644 --- a/CHANGES +++ b/CHANGES @@ -1,4 +1,7 @@ + 904. [bug] The server would leak memory if attempting to use + an expired TSIG key. [RT #1406] + 903. [bug] dig should not crash when receiving a TCP packet of length 0. diff --git a/lib/dns/tsig.c b/lib/dns/tsig.c index e0d5aa6225..ccb7b9270d 100644 --- a/lib/dns/tsig.c +++ b/lib/dns/tsig.c @@ -16,7 +16,7 @@ */ /* - * $Id: tsig.c,v 1.109 2001/06/04 19:33:14 tale Exp $ + * $Id: tsig.c,v 1.110 2001/06/15 02:24:02 bwelling Exp $ */ #include @@ -1123,7 +1123,6 @@ dns_tsigkey_find(dns_tsigkey_t **tsigkey, dns_name_t *name, * The key has expired. */ RWUNLOCK(&ring->lock, isc_rwlocktype_read); - isc_refcount_decrement(&key->refs, NULL); RWLOCK(&ring->lock, isc_rwlocktype_write); (void) dns_rbt_deletename(ring->keys, name, ISC_FALSE); RWUNLOCK(&ring->lock, isc_rwlocktype_write);