mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 14:07:59 +00:00
Code Issues Releases Wiki Activity

DoH: Remove unneeded isc__nmsocket_prep_destroy() call

Browse Source 
This commit removes unneeded isc__nmsocket_prep_destroy() call on ALPN
negotiation failure, which was eventually causing the TLS handle to
leak.

This call is not needed, as not attaching to the transport (TLS)
handle should be enough. At this point it seems like a kludge from
earlier days of the TLS code.
This commit is contained in:
Artem Boldariev
2021-11-24 14:03:44 +02:00
parent c52a383523
commit 0b0c29dd51
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/isc/netmgr/http.c
View File

@@ -1379,7 +1379,6 @@ transport_connect_cb(isc_nmhandle_t *handle, isc_result_t result, void *cbarg) {
* client will fail if HTTP/2 cannot be * client will fail if HTTP/2 cannot be
* negotiated via ALPN. * negotiated via ALPN.
*/ */
isc__nmsocket_prep_destroy(transp_sock);
result = ISC_R_HTTP2ALPNERROR; result = ISC_R_HTTP2ALPNERROR;
goto error; goto error;
} }