mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-22 10:10:06 +00:00
Code Issues Releases Wiki Activity

Warn about release notes without CHANGES entry

Browse Source
This commit is contained in:
Petr Špaček 2024-03-07 16:58:29 +01:00
parent 82cfb48295
commit 0ba29730f7
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dangerfile.py
View File

@ -342,6 +342,11 @@ if changes_added_lines:
# RR types are a user-visible change (and so is removing support for # RR types are a user-visible change (and so is removing support for
# existing ones). # existing ones).
# #
# * "Release notes" and "No CHANGES" labels are both set at the same time.
# (If something is worth a release note, it should surely show up in
# CHANGES.) MRs with certain labels set ("Documentation", "Release") are
# exempt because these are typically used during release process.
#
# - WARN if any of the following is true: # - WARN if any of the following is true:
# #
# * This merge request does not update release notes and has the "Customer" # * This merge request does not update release notes and has the "Customer"
@ -381,6 +386,15 @@ if release_notes_changed and not release_notes_label_set:
"This merge request modifies release notes. " "This merge request modifies release notes. "
"Revert release note modifications or set the *Release Notes* label." "Revert release note modifications or set the *Release Notes* label."
) )
if (
release_notes_label_set
and no_changes_label_set
and not ("Documentation" in mr_labels or "Release" in mr_labels)
):
fail(
"This merge request is labeled with both *Release notes* and *No CHANGES*. "
"A user-visible change should also be mentioned in the `CHANGES` file."
)
if release_notes_changed: if release_notes_changed:
modified_or_new_files = danger.git.modified_files + danger.git.created_files modified_or_new_files = danger.git.modified_files + danger.git.created_files