mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 14:35:26 +00:00
Code Issues Releases Wiki Activity

4861. [bug] The isc_crc64 unit test was not endian independent.

Browse Source 
[RT #46973]
This commit is contained in:
Mark Andrews
2018-01-10 09:46:08 +11:00
parent 21f708c88c
commit 0ce212b9f5
2 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
4861. [bug] The isc_crc64 unit test was not endian independent.
[RT #46973]
4860. [bug] isc_int8_t should be signed char. [RT #46973] 4860. [bug] isc_int8_t should be signed char. [RT #46973]
4859. [bug] A loop was possible when attempting to validate 4859. [bug] A loop was possible when attempting to validate

15
lib/isc/tests/hash_test.c
View File

@@ -1798,29 +1798,29 @@ ATF_TC_BODY(isc_crc64, tc) {
}, },
{ {
TEST_INPUT("a"), TEST_INPUT("a"),
"0x9AA9C0AC27F473CE", 1 "0xCE73F427ACC0A99A", 1
}, },
{ {
TEST_INPUT("abc"), TEST_INPUT("abc"),
"0x0297F4F93A818B04", 1 "0x048B813AF9F49702", 1
}, },
{ {
TEST_INPUT("message digest"), TEST_INPUT("message digest"),
"0xF47B357AEAF97352", 1 "0x5273F9EA7A357BF4", 1
}, },
{ {
TEST_INPUT("abcdefghijklmnopqrstuvwxyz"), TEST_INPUT("abcdefghijklmnopqrstuvwxyz"),
"0xA1AA8B21F979F059", 1 "0x59F079F9218BAAA1", 1
}, },
{ {
TEST_INPUT("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklm" TEST_INPUT("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklm"
"nopqrstuvwxyz0123456789"), "nopqrstuvwxyz0123456789"),
"0xFBB6781EF7A86DA3", 1 "0xA36DA8F71E78B6FB", 1
}, },
{ {
TEST_INPUT("123456789012345678901234567890123456789" TEST_INPUT("123456789012345678901234567890123456789"
"01234567890123456789012345678901234567890"), "01234567890123456789012345678901234567890"),
"0x4A87E7C873EBE581", 1 "0x81E5EB73C8E7874A", 1
}, },
{ NULL, 0, NULL, 1 } { NULL, 0, NULL, 1 }
}; };
@@ -1835,7 +1835,8 @@ ATF_TC_BODY(isc_crc64, tc) {
testcase->input_len); testcase->input_len);
} }
isc_crc64_final(&crc); isc_crc64_final(&crc);
tohexstr((unsigned char *) &crc, sizeof(crc), str, sizeof(str)); snprintf(str, sizeof(str),
"0x%016" ISC_PRINT_QUADFORMAT "X", crc);
ATF_CHECK_STREQ(str, testcase->result); ATF_CHECK_STREQ(str, testcase->result);
testcase++; testcase++;