mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 22:15:20 +00:00
Code Issues Releases Wiki Activity

Assert on unknown isc_quota_attach() return values

Browse Source 
The only values that the isc_quota_attach() function (called from
check_recursionquota() via recursionquotatype_attach_soft()) can
currently return are: ISC_R_SUCCESS, ISC_R_SOFTQUOTA, and ISC_R_QUOTA.
Instead of just propagating any other (unexpected) error up the call
stack, assert immediately, so that if the isc_quota_* API gets updated
in the future to return values currently matching the "default"
statement, check_recursionquota() can be promptly updated to handle such
new return values as desired.
This commit is contained in:
Michał Kępień
2022-06-14 13:13:32 +02:00
parent 8d64beb06f
commit 0d7e5d513c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ns/query.c
View File

@@ -6357,9 +6357,9 @@ check_recursionquota(ns_client_t *client, ns_query_rectype_t recursion_type) {
"no more recursive clients (%u/%u/%u)", "no more recursive clients (%u/%u/%u)",
&client->manager->sctx->recursionquota); &client->manager->sctx->recursionquota);
ns_client_killoldestquery(client); ns_client_killoldestquery(client);
FALLTHROUGH;
default:
return (result); return (result);
default:
UNREACHABLE();
} }
dns_message_clonebuffer(client->message); dns_message_clonebuffer(client->message);