mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 05:57:52 +00:00
Code Issues Releases Wiki Activity

removed bitstring avoidance code since it was only effective when

Browse Source 
reverse mapping the exact same name multiple times within a 10-minute
window, and the resolver's EDNS0 capability flagging achieves much of
the same effect in a much more general way
This commit is contained in:
Andreas Gustafsson 2001-01-22 22:29:04 +00:00
parent 9fb7cdd126
commit 1d830654f5
3 changed files with 3 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bin/named/include/named/lwdclient.h
View File

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: lwdclient.h,v 1.11 2001/01/09 21:40:20 bwelling Exp $ */
/* $Id: lwdclient.h,v 1.12 2001/01/22 22:29:04 gson Exp $ */
#ifndef NAMED_LWDCLIENT_H
#define NAMED_LWDCLIENT_H 1
@ -80,7 +80,6 @@ struct ns_lwdclient {
dns_byaddr_t *byaddr;
unsigned int options;
isc_netaddr_t na;
dns_adbaddrinfo_t *addrinfo;
/*
* grbn (get rrset by name) state info.

3
bin/named/lwdclient.c
View File

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: lwdclient.c,v 1.12 2001/01/09 21:39:47 bwelling Exp $ */
/* $Id: lwdclient.c,v 1.13 2001/01/22 22:29:02 gson Exp $ */
#include <config.h>
@ -441,7 +441,6 @@ ns_lwdclient_initialize(ns_lwdclient_t *client, ns_lwdclientmgr_t *cmgr) {
client->options = 0;
client->byaddr = NULL;
client->addrinfo = NULL;
client->lookup = NULL;

35
bin/named/lwdgnba.c
View File

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: lwdgnba.c,v 1.11 2001/01/09 21:39:51 bwelling Exp $ */
/* $Id: lwdgnba.c,v 1.12 2001/01/22 22:29:01 gson Exp $ */
#include <config.h>
@ -46,7 +46,6 @@ byaddr_done(isc_task_t *task, isc_event_t *event) {
isc_buffer_t b;
lwres_gnbaresponse_t *gnba;
isc_uint16_t naliases;
isc_stdtime_t now;
UNUSED(task);
@ -67,16 +66,7 @@ byaddr_done(isc_task_t *task, isc_event_t *event) {
isc_event_free(&event);
bevent = NULL;
/*
* Were we trying bitstring or nibble mode? If bitstring,
* and we got FORMERR or SERVFAIL, set the flag to
* avoid bitstring labels for 10 minutes. If we got any
* other error (NXDOMAIN, etc) just try again without
* bitstrings, and let our cache handle the negative answer
* for bitstrings.
*/
if ((client->options & DNS_BYADDROPT_IPV6NIBBLE) != 0) {
dns_adb_freeaddrinfo(cm->view->adb, &client->addrinfo);
if (result == DNS_R_NCACHENXDOMAIN ||
result == DNS_R_NCACHENXRRSET ||
result == DNS_R_NXDOMAIN ||
@ -88,13 +78,6 @@ byaddr_done(isc_task_t *task, isc_event_t *event) {
return;
}
isc_stdtime_get(&now);
if (result == DNS_R_FORMERR ||
result == DNS_R_SERVFAIL ||
result == ISC_R_FAILURE)
dns_adb_setavoidbitstring(cm->view->adb,
client->addrinfo, now + 600);
/*
* Fall back to nibble reverse if the default of bitstrings
* fails.
@ -132,7 +115,6 @@ byaddr_done(isc_task_t *task, isc_event_t *event) {
}
dns_byaddr_destroy(&client->byaddr);
dns_adb_freeaddrinfo(cm->view->adb, &client->addrinfo);
isc_event_free(&event);
/*
@ -163,8 +145,6 @@ byaddr_done(isc_task_t *task, isc_event_t *event) {
out:
if (client->byaddr != NULL)
dns_byaddr_destroy(&client->byaddr);
if (client->addrinfo != NULL)
dns_adb_freeaddrinfo(cm->view->adb, &client->addrinfo);
if (lwb.base != NULL)
lwres_context_freemem(cm->lwctx,
lwb.base, lwb.length);
@ -186,7 +166,6 @@ start_byaddr(ns_lwdclient_t *client) {
client->options, cm->task, byaddr_done,
client, &client->byaddr);
if (result != ISC_R_SUCCESS) {
dns_adb_freeaddrinfo(cm->view->adb, &client->addrinfo);
ns_lwdclient_errorpktsend(client, LWRES_R_FAILURE);
return;
}
@ -272,18 +251,6 @@ ns_lwdclient_processgnba(ns_lwdclient_t *client, lwres_buffer_t *b) {
init_gnba(client);
client->options = 0;
/*
* See if we should skip the byaddr bit.
*/
INSIST(client->addrinfo == NULL);
result = dns_adb_findaddrinfo(cm->view->adb, &sa,
&client->addrinfo, 0);
if (result != ISC_R_SUCCESS)
goto out;
if (client->addrinfo->avoid_bitstring > 0)
client->options |= DNS_BYADDROPT_IPV6NIBBLE;
/*
* Start the find.
*/