From 1dd4c2b9e2649f8dc41335e15180c0dc5ad4efbb Mon Sep 17 00:00:00 2001 From: Tom Krizek Date: Thu, 22 Jun 2023 17:57:22 +0200 Subject: [PATCH] Check for proper log message in kasp test The log message is supposed to contain the zone name which was erroneously omitted, but didn't pop up during tests, since return code was silently ignored. Now it actually waits for the proper log message rather than being an equivalent of 3 second sleep (which was also sufficient to make the test pass, thus we detected no failure). --- bin/tests/system/kasp/tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/tests/system/kasp/tests.sh b/bin/tests/system/kasp/tests.sh index 9766c380c8..8378feff72 100644 --- a/bin/tests/system/kasp/tests.sh +++ b/bin/tests/system/kasp/tests.sh @@ -328,7 +328,7 @@ ret=0 nextpart $DIR/named.run > /dev/null rndccmd 10.53.0.3 loadkeys "$ZONE" > /dev/null || log_error "rndc loadkeys zone ${ZONE} failed" -wait_for_log 3 "keymgr: done" $DIR/named.run +wait_for_log 3 "keymgr: $ZONE done" $DIR/named.run privkey_stat2=$(key_stat "${basefile}.private") pubkey_stat2=$(key_stat "${basefile}.key") state_stat2=$(key_stat "${basefile}.state")