mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-25 11:38:29 +00:00
Code Issues Releases Wiki Activity

mkeys: Prevent failing grep invocations

Browse Source 
Some 'grep' invocations were not guarded from interrupting the test
prematurely, e.g. when no text was matched.
This commit is contained in:
Michal Nowak 2020-01-22 14:53:01 +00:00
parent 1f3502f564
commit 20b446cdc3
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
bin/tests/system/mkeys/tests.sh
View File

@ -172,7 +172,7 @@ n=$((n+1))
echo_i "remove untrusted standby key, check timer restarts ($n)" echo_i "remove untrusted standby key, check timer restarts ($n)"
ret=0 ret=0
mkeys_sync_on 2 || ret=1 mkeys_sync_on 2 || ret=1
t1=$(grep "trust pending" ns2/managed-keys.bind) t1=$(grep "trust pending" ns2/managed-keys.bind) || true
$SETTIME -D now -K ns1 "$standby1" > /dev/null $SETTIME -D now -K ns1 "$standby1" > /dev/null
mkeys_loadkeys_on 1 || ret=1 mkeys_loadkeys_on 1 || ret=1
# Less than a second may have passed since the last time ns2 received a # Less than a second may have passed since the last time ns2 received a
@ -182,7 +182,7 @@ mkeys_loadkeys_on 1 || ret=1
sleep 1 sleep 1
mkeys_refresh_on 2 || ret=1 mkeys_refresh_on 2 || ret=1
mkeys_sync_on 2 || ret=1 mkeys_sync_on 2 || ret=1
t2=$(grep "trust pending" ns2/managed-keys.bind) t2=$(grep "trust pending" ns2/managed-keys.bind) || true
# trust pending date must be different # trust pending date must be different
[ -n "$t2" ] || ret=1 [ -n "$t2" ] || ret=1
[ "$t1" = "$t2" ] && ret=1 [ "$t1" = "$t2" ] && ret=1
@ -220,7 +220,7 @@ count=$(grep -c "remove at" rndc.out.$n) || true
count=$(grep -c "trust pending" rndc.out.$n) || true count=$(grep -c "trust pending" rndc.out.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
# pending date moved forward for the standby key # pending date moved forward for the standby key
t2=$(grep "trust pending" ns2/managed-keys.bind) t2=$(grep "trust pending" ns2/managed-keys.bind) || true
[ -n "$t2" ] || ret=1 [ -n "$t2" ] || ret=1
[ "$t1" = "$t2" ] && ret=1 [ "$t1" = "$t2" ] && ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi if [ $ret != 0 ]; then echo_i "failed"; fi
@ -254,7 +254,7 @@ count=$(grep -c "remove at" rndc.out.$n) || true
count=$(grep -c "trust pending" rndc.out.$n) || true count=$(grep -c "trust pending" rndc.out.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
# pending date moved forward for the standby key # pending date moved forward for the standby key
t2=$(grep "trust pending" ns2/managed-keys.bind) t2=$(grep "trust pending" ns2/managed-keys.bind) || true
[ -n "$t2" ] || ret=1 [ -n "$t2" ] || ret=1
[ "$t1" = "$t2" ] && ret=1 [ "$t1" = "$t2" ] && ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi if [ $ret != 0 ]; then echo_i "failed"; fi
@ -292,7 +292,7 @@ count=$(grep -c "remove at" rndc.out.$n) || true
count=$(grep -c "trust pending" rndc.out.$n) || true count=$(grep -c "trust pending" rndc.out.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
# pending date moved forward for the standby key # pending date moved forward for the standby key
t2=$(grep "trust pending" ns2/managed-keys.bind) t2=$(grep "trust pending" ns2/managed-keys.bind) || true
[ -n "$t2" ] || ret=1 [ -n "$t2" ] || ret=1
[ "$t1" = "$t2" ] && ret=1 [ "$t1" = "$t2" ] && ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi if [ $ret != 0 ]; then echo_i "failed"; fi
@ -571,7 +571,7 @@ ret=0
# set using -T mkeytimers). # set using -T mkeytimers).
mkeys_refresh_on 2 || ret=1 mkeys_refresh_on 2 || ret=1
mkeys_status_on 2 > rndc.out.1.$n 2>&1 || ret=1 mkeys_status_on 2 > rndc.out.1.$n 2>&1 || ret=1
t1=$(grep 'next refresh:' rndc.out.1.$n) t1=$(grep 'next refresh:' rndc.out.1.$n) || true
$PERL $SYSTEMTESTTOP/stop.pl --use-rndc --port "${CONTROLPORT}" mkeys ns1 $PERL $SYSTEMTESTTOP/stop.pl --use-rndc --port "${CONTROLPORT}" mkeys ns1
rm -f ns1/root.db.signed.jnl rm -f ns1/root.db.signed.jnl
cp ns1/root.db ns1/root.db.signed cp ns1/root.db ns1/root.db.signed
@ -594,7 +594,7 @@ count=$(grep -c "trust" rndc.out.2.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
count=$(grep -c "trusted since" rndc.out.2.$n) || true count=$(grep -c "trusted since" rndc.out.2.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
t2=$(grep 'next refresh:' rndc.out.2.$n) t2=$(grep 'next refresh:' rndc.out.2.$n) || true
[ "$t1" = "$t2" ] && ret=1 [ "$t1" = "$t2" ] && ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi if [ $ret != 0 ]; then echo_i "failed"; fi
status=$((status+ret)) status=$((status+ret))
@ -605,7 +605,7 @@ ret=0
# Refresh keys first to prevent previous checks from influencing this one # Refresh keys first to prevent previous checks from influencing this one
mkeys_refresh_on 2 || ret=1 mkeys_refresh_on 2 || ret=1
mkeys_status_on 2 > rndc.out.1.$n 2>&1 || ret=1 mkeys_status_on 2 > rndc.out.1.$n 2>&1 || ret=1
t1=$(grep 'next refresh:' rndc.out.1.$n) t1=$(grep 'next refresh:' rndc.out.1.$n) || true
$PERL $SYSTEMTESTTOP/stop.pl --use-rndc --port "${CONTROLPORT}" mkeys ns1 $PERL $SYSTEMTESTTOP/stop.pl --use-rndc --port "${CONTROLPORT}" mkeys ns1
rm -f ns1/root.db.signed.jnl rm -f ns1/root.db.signed.jnl
cat ns1/K*.key >> ns1/root.db.signed cat ns1/K*.key >> ns1/root.db.signed
@ -632,7 +632,7 @@ count=$(grep -c "trust" rndc.out.2.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
count=$(grep -c "trusted since" rndc.out.2.$n) || true count=$(grep -c "trusted since" rndc.out.2.$n) || true
[ "$count" -eq 1 ] || ret=1 [ "$count" -eq 1 ] || ret=1
t2=$(grep 'next refresh:' rndc.out.2.$n) t2=$(grep 'next refresh:' rndc.out.2.$n) || true
[ "$t1" = "$t2" ] && ret=1 [ "$t1" = "$t2" ] && ret=1
if [ $ret != 0 ]; then echo_i "failed"; fi if [ $ret != 0 ]; then echo_i "failed"; fi
status=$((status+ret)) status=$((status+ret))
@ -682,7 +682,7 @@ echo_i "check that trust-anchor-telemetry queries contain the correct key ($n)"
ret=0 ret=0
# convert the hexadecimal key from the TAT query into decimal and # convert the hexadecimal key from the TAT query into decimal and
# compare against the known key. # compare against the known key.
tathex=$(grep "query '_ta-[0-9a-f][0-9a-f]*/NULL/IN' approved" ns1/named.run | awk '{print $6; exit 0}' | sed -e 's/(_ta-\([0-9a-f][0-9a-f]*\)):/\1/') tathex=$(grep "query '_ta-[0-9a-f][0-9a-f]*/NULL/IN' approved" ns1/named.run | awk '{print $6; exit 0}' | sed -e 's/(_ta-\([0-9a-f][0-9a-f]*\)):/\1/') || true
tatkey=$($PERL -e 'printf("%d\n", hex(@ARGV[0]));' "$tathex") tatkey=$($PERL -e 'printf("%d\n", hex(@ARGV[0]));' "$tathex")
realkey=$(rndccmd 10.53.0.2 secroots - | sed -n 's#.*SHA256/\([0-9][0-9]*\) ; .*managed.*#\1#p') realkey=$(rndccmd 10.53.0.2 secroots - | sed -n 's#.*SHA256/\([0-9][0-9]*\) ; .*managed.*#\1#p')
[ "$tatkey" -eq "$realkey" ] || ret=1 [ "$tatkey" -eq "$realkey" ] || ret=1