mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 06:25:31 +00:00
Code Issues Releases Wiki Activity

Remove use of the inline keyword used as suggestion to compiler

Browse Source 
Historically, the inline keyword was a strong suggestion to the compiler
that it should inline the function marked inline.  As compilers became
better at optimising, this functionality has receded, and using inline
as a suggestion to inline a function is obsolete.  The compiler will
happily ignore it and inline something else entirely if it finds that's
a better optimisation.

Therefore, remove all the occurences of the inline keyword with static
functions inside single compilation unit and leave the decision whether
to inline a function or not entirely on the compiler

NOTE: We keep the usage the inline keyword when the purpose is to change
the linkage behaviour.
This commit is contained in:
Ondřej Surý
2021-10-11 13:43:12 +02:00
committed by Ondřej Surý
parent 04d0b70ba2
commit 20f0936cf2
151 changed files with 1485 additions and 1488 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bin/named/server.c
View File

@@ -455,7 +455,7 @@ end_reserved_dispatches(named_server_t *server, bool all);
static void
newzone_cfgctx_destroy(void **cfgp);
static inline isc_result_t
static isc_result_t
putstr(isc_buffer_t **b, const char *str);
static isc_result_t
@@ -464,7 +464,7 @@ putmem(isc_buffer_t **b, const char *str, size_t len);
static isc_result_t
putuint8(isc_buffer_t **b, uint8_t val);
static inline isc_result_t
static isc_result_t
putnull(isc_buffer_t **b);
static int
@@ -15037,7 +15037,7 @@ cleanup:
return (result);
}
static inline bool
static bool
argcheck(char *cmd, const char *full) {
size_t l;
@@ -15375,7 +15375,7 @@ putmem(isc_buffer_t **b, const char *str, size_t len) {
return (ISC_R_SUCCESS);
}
static inline isc_result_t
static isc_result_t
putstr(isc_buffer_t **b, const char *str) {
return (putmem(b, str, strlen(str)));
}
@@ -15393,7 +15393,7 @@ putuint8(isc_buffer_t **b, uint8_t val) {
return (ISC_R_SUCCESS);
}
static inline isc_result_t
static isc_result_t
putnull(isc_buffer_t **b) {
return (putuint8(b, 0));
}