mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 14:35:26 +00:00
Code Issues Releases Wiki Activity

Remove use of the inline keyword used as suggestion to compiler

Browse Source 
Historically, the inline keyword was a strong suggestion to the compiler
that it should inline the function marked inline.  As compilers became
better at optimising, this functionality has receded, and using inline
as a suggestion to inline a function is obsolete.  The compiler will
happily ignore it and inline something else entirely if it finds that's
a better optimisation.

Therefore, remove all the occurences of the inline keyword with static
functions inside single compilation unit and leave the decision whether
to inline a function or not entirely on the compiler

NOTE: We keep the usage the inline keyword when the purpose is to change
the linkage behaviour.
This commit is contained in:
Ondřej Surý
2021-10-11 13:43:12 +02:00
committed by Ondřej Surý
parent 04d0b70ba2
commit 20f0936cf2
151 changed files with 1485 additions and 1488 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/isc/base64.c
View File

@@ -100,7 +100,7 @@ typedef struct {
int val[4];
} base64_decode_ctx_t;
static inline void
static void
base64_decode_init(base64_decode_ctx_t *ctx, int length, isc_buffer_t *target) {
ctx->digits = 0;
ctx->seen_end = false;
@@ -108,7 +108,7 @@ base64_decode_init(base64_decode_ctx_t *ctx, int length, isc_buffer_t *target) {
ctx->target = target;
}
static inline isc_result_t
static isc_result_t
base64_decode_char(base64_decode_ctx_t *ctx, int c) {
const char *s;
@@ -167,7 +167,7 @@ base64_decode_char(base64_decode_ctx_t *ctx, int c) {
return (ISC_R_SUCCESS);
}
static inline isc_result_t
static isc_result_t
base64_decode_finish(base64_decode_ctx_t *ctx) {
if (ctx->length > 0) {
return (ISC_R_UNEXPECTEDEND);