mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-08-30 22:15:20 +00:00
Warn when log files grow too big in system tests
Exerting excessive I/O load on the host running system tests should be avoided in order to limit the number of false positives reported by the system test suite. In some cases, running named with "-d 99" (which is the default for system tests) results in a massive amount of logs being generated, most of which are useless. Implement a log file size check to draw developers' attention to overly verbose named instances used in system tests. The warning threshold of 200,000 lines was chosen arbitrarily.
This commit is contained in:
@@ -321,6 +321,11 @@ else
|
|||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
NAMED_RUN_LINES_THRESHOLD=200000
|
||||||
|
find "${systest}" -type f -name "named.run" -exec wc -l {} \; | awk "\$1 > ${NAMED_RUN_LINES_THRESHOLD} { print \$2 }" | sort | while read -r LOG_FILE; do
|
||||||
|
echowarn "I:${systest}:${LOG_FILE} contains more than ${NAMED_RUN_LINES_THRESHOLD} lines, consider tweaking the test to limit disk I/O"
|
||||||
|
done
|
||||||
|
|
||||||
echoend "E:$systest:$(date_with_args)"
|
echoend "E:$systest:$(date_with_args)"
|
||||||
|
|
||||||
exit $status
|
exit $status
|
||||||
|
Reference in New Issue
Block a user