mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 22:15:20 +00:00
Code Issues Releases Wiki Activity

Merge branch 'master' of ssh://repo.isc.org/proj/git/prod/bind9

Browse Source
This commit is contained in:
Tinderbox User
2014-08-27 01:01:12 +00:00
parent 78c3882f77 1164997311
commit 2aced10e98
4 changed files with 63 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGES
View File

@@ -1,3 +1,8 @@
3931. [cleanup] Cleanup how dlz grammer is defined. [RT #36879]
3930. [bug] "rndc nta -r" could cause a server hang if the
NTA was not found. [RT #36909]
3929. [bug] 'host -a' needed to clear idnoptions. [RT #36963] 3929. [bug] 'host -a' needed to clear idnoptions. [RT #36963]
3928. [test] Improve rndc system test. [RT #36898] 3928. [test] Improve rndc system test. [RT #36898]

18
bin/named/server.c
View File

@@ -2562,13 +2562,10 @@ configure_view(dns_view_t *view, dns_viewlist_t *viewlist,
element != NULL; element != NULL;
element = cfg_list_next(element)) element = cfg_list_next(element))
{ {
const cfg_obj_t *dlzopts; dlz = cfg_listelt_value(element);
obj = NULL;
obj = NULL; obj = NULL;
dlz = cfg_listelt_value(element); (void)cfg_map_get(dlz, "database", &obj);
dlzopts = cfg_tuple_get(dlz, "options");
(void)cfg_map_get(dlzopts, "database", &obj);
if (obj != NULL) { if (obj != NULL) {
dns_dlzdb_t *dlzdb = NULL; dns_dlzdb_t *dlzdb = NULL;
const cfg_obj_t *name, *search = NULL; const cfg_obj_t *name, *search = NULL;
@@ -2585,7 +2582,7 @@ configure_view(dns_view_t *view, dns_viewlist_t *viewlist,
goto cleanup; goto cleanup;
} }
name = cfg_tuple_get(dlz, "name"); name = cfg_map_getname(dlz);
result = dns_dlzcreate(mctx, cfg_obj_asstring(name), result = dns_dlzcreate(mctx, cfg_obj_asstring(name),
dlzargv[0], dlzargc, dlzargv, dlzargv[0], dlzargc, dlzargv,
&dlzdb); &dlzdb);
@@ -2600,7 +2597,7 @@ configure_view(dns_view_t *view, dns_viewlist_t *viewlist,
* method now. If not searchable, we'll take * method now. If not searchable, we'll take
* care of it when we process the zone statement. * care of it when we process the zone statement.
*/ */
(void)cfg_map_get(dlzopts, "search", &search); (void)cfg_map_get(dlz, "search", &search);
if (search == NULL || cfg_obj_asboolean(search)) { if (search == NULL || cfg_obj_asboolean(search)) {
dlzdb->search = ISC_TRUE; dlzdb->search = ISC_TRUE;
result = dns_dlzconfigure(view, dlzdb, result = dns_dlzconfigure(view, dlzdb,
@@ -9870,7 +9867,7 @@ ns_server_nta(ns_server_t *server, char *args, isc_buffer_t *text) {
dns_fixedname_t fn; dns_fixedname_t fn;
dns_name_t *ntaname; dns_name_t *ntaname;
dns_ttl_t ntattl; dns_ttl_t ntattl;
isc_boolean_t ttlset = ISC_FALSE; isc_boolean_t ttlset = ISC_FALSE, excl = ISC_FALSE;
UNUSED(force); UNUSED(force);
@@ -9969,6 +9966,7 @@ ns_server_nta(ns_server_t *server, char *args, isc_buffer_t *text) {
result = isc_task_beginexclusive(server->task); result = isc_task_beginexclusive(server->task);
RUNTIME_CHECK(result == ISC_R_SUCCESS); RUNTIME_CHECK(result == ISC_R_SUCCESS);
excl = ISC_TRUE;
for (view = ISC_LIST_HEAD(server->viewlist); for (view = ISC_LIST_HEAD(server->viewlist);
view != NULL; view != NULL;
view = ISC_LIST_NEXT(view, link)) view = ISC_LIST_NEXT(view, link))
@@ -10037,11 +10035,13 @@ ns_server_nta(ns_server_t *server, char *args, isc_buffer_t *text) {
isc_buffer_putuint8(text, 0); isc_buffer_putuint8(text, 0);
} }
isc_task_endexclusive(server->task);
if (msg != NULL) if (msg != NULL)
(void) putstr(text, msg); (void) putstr(text, msg);
cleanup: cleanup:
if (excl)
isc_task_endexclusive(server->task);
if (ntatable != NULL) if (ntatable != NULL)
dns_ntatable_detach(&ntatable); dns_ntatable_detach(&ntatable);
return (result); return (result);

36
bin/tests/system/dnssec/tests.sh
View File

@@ -1766,6 +1766,42 @@ n=`expr $n + 1`
if [ $ret != 0 ]; then echo "I:failed - that all nta's have been lifted"; fi if [ $ret != 0 ]; then echo "I:failed - that all nta's have been lifted"; fi
status=`expr $status + $ret` status=`expr $status + $ret`
n=`expr $n + 1`
echo "I: testing NTA removals ($n)"
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta badds.example 2>&1 | sed 's/^/I:ns4 /'
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -d > rndc.out.ns4.test$n.1
grep "badds.example: expiry" rndc.out.ns4.test$n.1 > /dev/null || ret=1
$DIG $DIGOPTS a.badds.example. a @10.53.0.4 > dig.out.ns4.test$n.1 || ret=1
grep "^a.badds.example." dig.out.ns4.test$n.1 > /dev/null || ret=1
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -remove badds.example > rndc.out.ns4.test$n.2
grep "Negative trust anchor removed: badds.example/_default" rndc.out.ns4.test$n.2 > /dev/null || ret=1
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -d > rndc.out.ns4.test$n.3
grep "badds.example: expiry" rndc.out.ns4.test$n.3 > /dev/null && ret=1
$DIG $DIGOPTS a.badds.example. a @10.53.0.4 > dig.out.ns4.test$n.2 || ret=1
grep "status: SERVFAIL" dig.out.ns4.test$n.2 > /dev/null || ret=1
echo "I: remove non-existent NTA three times"
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -r foo > rndc.out.ns4.test$n.4 2>&1
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -remove foo > rndc.out.ns4.test$n.5 2>&1
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -r foo > rndc.out.ns4.test$n.6 2>&1
grep "'nta' failed: not found" rndc.out.ns4.test$n.6 > /dev/null || ret=1
if [ $ret != 0 ]; then echo "I:failed"; fi
status=`expr $status + $ret`
n=`expr $n + 1`
echo "I: testing NTA with bogus lifetimes ($n)"
echo "I:check with no nta lifetime specified"
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -l "" foo > rndc.out.ns4.test$n.1 2>&1
grep "'nta' failed: bad ttl" rndc.out.ns4.test$n.1 > /dev/null || ret=1
echo "I:check with bad nta lifetime"
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -l garbage foo > rndc.out.ns4.test$n.2 2>&1
grep "'nta' failed: bad ttl" rndc.out.ns4.test$n.2 > /dev/null || ret=1
echo "I:check with too long nta lifetime"
$RNDC -c ../common/rndc.conf -s 10.53.0.4 -p 9953 nta -l 5d23h foo > rndc.out.ns4.test$n.3 2>&1
grep "'nta' failed: out of range" rndc.out.ns4.test$n.3 > /dev/null || ret=1
if [ $ret != 0 ]; then echo "I:failed"; fi
status=`expr $status + $ret`
# Run a minimal update test if possible. This is really just # Run a minimal update test if possible. This is really just
# a regression test for RT #2399; more tests should be added. # a regression test for RT #2399; more tests should be added.

48
lib/isccfg/namedconf.c
View File

@@ -141,35 +141,8 @@ static cfg_type_t cfg_type_view;
static cfg_type_t cfg_type_viewopts; static cfg_type_t cfg_type_viewopts;
static cfg_type_t cfg_type_zone; static cfg_type_t cfg_type_zone;
static cfg_type_t cfg_type_zoneopts; static cfg_type_t cfg_type_zoneopts;
static cfg_type_t cfg_type_dynamically_loadable_zones;
static cfg_type_t cfg_type_dynamically_loadable_zones_opts;
static cfg_type_t cfg_type_filter_aaaa; static cfg_type_t cfg_type_filter_aaaa;
static cfg_type_t cfg_type_dlz;
/*
* Clauses that can be found in a 'dynamically loadable zones' statement
*/
static cfg_clausedef_t
dynamically_loadable_zones_clauses[] = {
{ "database", &cfg_type_astring, 0 },
{ "search", &cfg_type_boolean, 0 },
{ NULL, NULL, 0 }
};
/*
* A dynamically loadable zones statement.
*/
static cfg_tuplefielddef_t dynamically_loadable_zones_fields[] = {
{ "name", &cfg_type_astring, 0 },
{ "options", &cfg_type_dynamically_loadable_zones_opts, 0 },
{ NULL, NULL, 0 }
};
static cfg_type_t cfg_type_dynamically_loadable_zones = {
"dlz", cfg_parse_tuple, cfg_print_tuple, cfg_doc_tuple,
&cfg_rep_tuple,
dynamically_loadable_zones_fields
};
/*% tkey-dhkey */ /*% tkey-dhkey */
@@ -936,7 +909,7 @@ static cfg_clausedef_t
namedconf_or_view_clauses[] = { namedconf_or_view_clauses[] = {
{ "key", &cfg_type_key, CFG_CLAUSEFLAG_MULTI }, { "key", &cfg_type_key, CFG_CLAUSEFLAG_MULTI },
{ "zone", &cfg_type_zone, CFG_CLAUSEFLAG_MULTI }, { "zone", &cfg_type_zone, CFG_CLAUSEFLAG_MULTI },
{ "dlz", &cfg_type_dynamically_loadable_zones, CFG_CLAUSEFLAG_MULTI }, { "dlz", &cfg_type_dlz, CFG_CLAUSEFLAG_MULTI },
{ "server", &cfg_type_server, CFG_CLAUSEFLAG_MULTI }, { "server", &cfg_type_server, CFG_CLAUSEFLAG_MULTI },
{ "trusted-keys", &cfg_type_dnsseckeys, CFG_CLAUSEFLAG_MULTI }, { "trusted-keys", &cfg_type_dnsseckeys, CFG_CLAUSEFLAG_MULTI },
{ "managed-keys", &cfg_type_managedkeys, CFG_CLAUSEFLAG_MULTI }, { "managed-keys", &cfg_type_managedkeys, CFG_CLAUSEFLAG_MULTI },
@@ -1803,15 +1776,20 @@ static cfg_type_t cfg_type_zoneopts = {
/*% The "dynamically loadable zones" statement syntax. */ /*% The "dynamically loadable zones" statement syntax. */
static cfg_clausedef_t
dlz_clauses[] = {
{ "database", &cfg_type_astring, 0 },
{ "search", &cfg_type_boolean, 0 },
{ NULL, NULL, 0 }
};
static cfg_clausedef_t * static cfg_clausedef_t *
dynamically_loadable_zones_clausesets[] = { dlz_clausesets[] = {
dynamically_loadable_zones_clauses, dlz_clauses,
NULL NULL
}; };
static cfg_type_t cfg_type_dynamically_loadable_zones_opts = { static cfg_type_t cfg_type_dlz = {
"dynamically_loadable_zones_opts", cfg_parse_map, "dlz", cfg_parse_named_map, cfg_print_map, cfg_doc_map,
cfg_print_map, cfg_doc_map, &cfg_rep_map, &cfg_rep_map, dlz_clausesets
dynamically_loadable_zones_clausesets
}; };
/*% /*%