From da9fbf72e4172b73c3309ef90df30b7504096229 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Tue, 25 Feb 2025 14:54:55 +1100 Subject: [PATCH] Check if key is NULL before dereferencing it (cherry picked from commit 1784e4a9aebc83ef22018cc35eeeea12e7ae2a14) --- bin/dnssec/dnssec-signzone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c index 7e906dfd1d..c71d4160d2 100644 --- a/bin/dnssec/dnssec-signzone.c +++ b/bin/dnssec/dnssec-signzone.c @@ -551,7 +551,7 @@ signset(dns_diff_t *del, dns_diff_t *add, dns_dbnode_t *node, dns_name_t *name, future = isc_serial_lt(now, rrsig.timesigned); key = keythatsigned(&rrsig); - offline = key->pubkey; + offline = (key != NULL) ? key->pubkey : false; sig_format(&rrsig, sigstr, sizeof(sigstr)); expired = isc_serial_gt(now, rrsig.timeexpire); refresh = isc_serial_gt(now + cycle, rrsig.timeexpire);