From 3271f5fda447be30e6770419e1036830cfea6cf4 Mon Sep 17 00:00:00 2001 From: Alessio Podda Date: Tue, 19 Aug 2025 14:12:46 +0200 Subject: [PATCH] Do not skip cleanup for origin nodes in qpzone Per @each, skipping cleanup of (|nsec_|nsec3_)origin nodes in qpznode_release in qpzone.c is a residual from RBTDB, but it is unnecessary or at most a performance optimization with QP. Remove it to make it further changes easier to qpznode_release easier. --- lib/dns/qpzone.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/dns/qpzone.c b/lib/dns/qpzone.c index 53503c7668..43f28a2b3c 100644 --- a/lib/dns/qpzone.c +++ b/lib/dns/qpzone.c @@ -970,10 +970,7 @@ qpznode_release(qpzonedb_t *qpdb, qpznode_t *node, uint32_t least_serial, } /* Handle easy and typical case first. */ - if (!node->dirty && - (node->data != NULL || node == qpdb->origin || - node == qpdb->nsec_origin || node == qpdb->nsec3_origin)) - { + if (!node->dirty && node->data != NULL) { goto unref; }