From 32909254f5fa3fdb042ce8fa1e32f7b90ec6f68d Mon Sep 17 00:00:00 2001 From: Colin Vidal Date: Wed, 30 Jul 2025 10:35:26 +0200 Subject: [PATCH] fix ns_plugin_expandpath tests with no extension Parts of ns_plugin_expandpath() test expected the plugin extension to be appened automatically (the plugin name/path is provided without the extension), this enable to test the logic which adds the correct extension based on the platfrom. But the expected expanded paths from the test were hard coded with the `.so` extension, so the test can't pass on macOS platform. This fixes the test by using the macro providing the current-platform extension. --- tests/ns/plugin_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ns/plugin_test.c b/tests/ns/plugin_test.c index 3a23d43476..521931db57 100644 --- a/tests/ns/plugin_test.c +++ b/tests/ns/plugin_test.c @@ -150,7 +150,7 @@ ISC_RUN_TEST_IMPL(ns_plugin_expandpath) { .exists = false, .output_size = PATH_MAX, .result = ISC_R_SUCCESS, - .output = "/usr/lib/named/foo.so", + .output = "/usr/lib/named/foo" NAMED_PLUGINEXT, }, { NS_TEST_ID("correct use with a relative path and no " @@ -159,7 +159,7 @@ ISC_RUN_TEST_IMPL(ns_plugin_expandpath) { .exists = false, .output_size = PATH_MAX, .result = ISC_R_SUCCESS, - .output = "../../foo.so", + .output = "../../foo" NAMED_PLUGINEXT, }, { NS_TEST_ID("correct use with a filename and no " @@ -168,7 +168,7 @@ ISC_RUN_TEST_IMPL(ns_plugin_expandpath) { .exists = false, .output_size = PATH_MAX, .result = ISC_R_SUCCESS, - .output = NAMED_PLUGINDIR "/foo.so", + .output = NAMED_PLUGINDIR "/foo" NAMED_PLUGINEXT, }, { NS_TEST_ID("correct use with a filename and no " @@ -177,7 +177,7 @@ ISC_RUN_TEST_IMPL(ns_plugin_expandpath) { .exists = false, .output_size = PATH_MAX, .result = ISC_R_SUCCESS, - .output = NAMED_PLUGINDIR "/foo.bar.so", + .output = NAMED_PLUGINDIR "/foo.bar" NAMED_PLUGINEXT, }, { NS_TEST_ID("no space at all in target buffer"),