mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 06:25:31 +00:00
Code Issues Releases Wiki Activity

4615. [bug] AD could be set on truncated answer with no records

Browse Source 
present in the answer and authority sections.
                        [RT #45140]
This commit is contained in:
Mark Andrews
2017-05-03 07:51:41 +10:00
parent 78551a3f2c
commit 33e94f501f
4 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/dns/message.c
View File

@@ -1960,6 +1960,15 @@ renderset(dns_rdataset_t *rdataset, const dns_name_t *owner_name,
return (result);
}
static void
maybe_clear_ad(dns_message_t *msg, dns_section_t sectionid) {
if (msg->counts[sectionid] == 0 &&
(sectionid == DNS_SECTION_ANSWER ||
(sectionid == DNS_SECTION_AUTHORITY &&
msg->counts[DNS_SECTION_ANSWER] == 0)))
msg->flags &= ~DNS_MESSAGEFLAG_AD;
}
isc_result_t
dns_message_rendersection(dns_message_t *msg, dns_section_t sectionid,
unsigned int options)
@@ -2157,6 +2166,7 @@ dns_message_rendersection(dns_message_t *msg, dns_section_t sectionid,
*(msg->buffer) = st; /* rollback */
msg->buffer->length += msg->reserved;
msg->counts[sectionid] += total;
maybe_clear_ad(msg, sectionid);
return (result);
}