mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-02 15:45:25 +00:00
Code Issues Releases Wiki Activity

handle dynamic update meta-classes and empty rdatas

Browse Source
This commit is contained in:
Andreas Gustafsson
1999-06-20 08:05:56 +00:00
parent 54a64ec428
commit 3b40e78974
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
lib/dns/message.c
View File

@@ -692,6 +692,21 @@ getrdata(dns_name_t *name, isc_buffer_t *source, dns_message_t *msg,
dns_result_t result; dns_result_t result;
unsigned int tries; unsigned int tries;
/*
* In dynamic update messages, the rdata can be empty.
*/
if (msg->opcode == dns_opcode_update && rdatalen == 0) {
/*
* When the rdata is empty, the data pointer is never
* dereferenced, but it must still be non-NULL.
*/
rdata->data = "";
rdata->length = 0;
rdata->class = rdclass;
rdata->type = rdtype;
return DNS_R_SUCCESS;
}
scratch = currentbuffer(msg); scratch = currentbuffer(msg);
isc_buffer_setactive(source, rdatalen); isc_buffer_setactive(source, rdatalen);
@@ -983,15 +998,19 @@ getsection(isc_buffer_t *source, dns_message_t *msg, dns_decompress_t *dctx,
} }
/* /*
* Read the rdata from the wire format. * Read the rdata from the wire format. Interpret the
* rdata according to its actual class, even if it had a
* DynDNS meta-class in the packet. Then put the meta-class
* back into the finished rdata.
*/ */
rdata = newrdata(msg); rdata = newrdata(msg);
if (rdata == NULL) if (rdata == NULL)
return (DNS_R_NOMEMORY); return (DNS_R_NOMEMORY);
result = getrdata(name, source, msg, dctx, result = getrdata(name, source, msg, dctx,
rdclass, rdtype, rdatalen, rdata); msg->rdclass, rdtype, rdatalen, rdata);
if (result != DNS_R_SUCCESS) if (result != DNS_R_SUCCESS)
return (result); return (result);
rdata->class = rdclass;
/* /*
* XXXMLG Perform a totally ugly hack here to pull * XXXMLG Perform a totally ugly hack here to pull