From 42f0e25a4c40b231c04d0493ebbc21105d1617c7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Witold=20Kr=C4=99cicki?= <wpk@isc.org>
Date: Fri, 17 Jan 2020 12:07:34 +0100
Subject: [PATCH] calling isc__nm_udp_send() on a non-udp socket is not
 'unexpected', it's a critical failure

---
 lib/isc/netmgr/udp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/isc/netmgr/udp.c b/lib/isc/netmgr/udp.c
index cb14425703..d4f27a7c36 100644
--- a/lib/isc/netmgr/udp.c
+++ b/lib/isc/netmgr/udp.c
@@ -383,7 +383,8 @@ isc__nm_udp_send(isc_nmhandle_t *handle, isc_region_t *region,
 	} else if (sock->type == isc_nm_udplistener) {
 		psock = sock;
 	} else {
-		return (ISC_R_UNEXPECTED);
+		INSIST(0);
+		ISC_UNREACHABLE();
 	}
 
 	if (!isc__nmsocket_active(sock)) {