mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 14:07:59 +00:00
Code Issues Releases Wiki Activity

TLS Stream: remove incorrect/obsolete INSIST()s from tls_do_bio()

Browse Source 
With the changes to tls_try_handshake() made in
2846888c573fcc610cdf71bcdd5bb6f92ffaf499 there are some incorrect
INSISTS() related to handshake handling which better to be removed.
This commit is contained in:
Artem Boldariev 2023-03-30 18:17:11 +03:00
parent 696b2c8c89
commit 43e21d653f
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/isc/netmgr/tlsstream.c
View File

@ -524,20 +524,15 @@ tls_do_bio(isc_nmsocket_t *sock, isc_region_t *received_data,
hs_result != ISC_R_SUCCESS) hs_result != ISC_R_SUCCESS)
{ {
/* /*
* The accept callback has been called * The accept/connect callback has been
* unsuccessfully. Let's try to shut * called unsuccessfully. Let's try to
* down the TLS connection gracefully. * shut down the TLS connection
* gracefully.
*/ */
INSIST(SSL_is_init_finished( INSIST(SSL_is_init_finished(
sock->tlsstream.tls) == sock->tlsstream.tls) ==
1); 1);
INSIST(!sock->client);
finish = true; finish = true;
} else if (sock->tlsstream.state == TLS_IO &&
hs_result == ISC_R_SUCCESS &&
!sock->tlsstream.server)
{
INSIST(sock->client);
} }
} }
} else if (send_data != NULL) { } else if (send_data != NULL) {