Separate common templates and test code for rollover tests

This is a preparation to split up and further isolate the various
rollover tests in a subsequent commits.

bin/tests/system/rollover/common.py

@@ -0,0 +1,36 @@
+# Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+#
+# SPDX-License-Identifier: MPL-2.0
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0.  If a copy of the MPL was not distributed with this
+# file, you can obtain one at https://mozilla.org/MPL/2.0/.
+#
+# See the COPYRIGHT file distributed with this work for additional
+# information regarding copyright ownership.
+
+import pytest
+
+pytestmark = pytest.mark.extra_artifacts(
+    [
+        "*.axfr*",
+        "dig.out*",
+        "K*.key*",
+        "K*.private*",
+        "ns*/*.db",
+        "ns*/*.db.infile",
+        "ns*/*.db.jnl",
+        "ns*/*.db.jbk",
+        "ns*/*.db.signed",
+        "ns*/*.db.signed.jnl",
+        "ns*/*.conf",
+        "ns*/dsset-*",
+        "ns*/K*.key",
+        "ns*/K*.private",
+        "ns*/K*.state",
+        "ns*/keygen.out.*",
+        "ns*/settime.out.*",
+        "ns*/signer.out.*",
+        "ns*/zones",
+    ]
+)

bin/tests/system/rollover/ns3/named.common.conf.j2

@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+ *
+ * SPDX-License-Identifier: MPL-2.0
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0.  If a copy of the MPL was not distributed with this
+ * file, you can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See the COPYRIGHT file distributed with this work for additional
+ * information regarding copyright ownership.
+ */
+
+options {
+        query-source address 10.53.0.3;
+        notify-source 10.53.0.3;
+        transfer-source 10.53.0.3;
+        port @PORT@;
+        pid-file "named.pid";
+        listen-on { 10.53.0.3; };
+        listen-on-v6 { none; };
+        allow-transfer { any; };
+        recursion no;
+        dnssec-validation no;
+};
+
+key rndc_key {
+        secret "1234abcd8765";
+        algorithm @DEFAULT_HMAC@;
+};
+
+controls {
+        inet 10.53.0.3 port @CONTROLPORT@ allow { any; } keys { rndc_key; };
+};
+
+zone "." {
+        type hint;
+        file "../../_common/root.hint.blackhole";
+};

bin/tests/system/rollover/ns3/named.conf.j2

@@ -15,32 +15,7 @@
 
 include "kasp.conf";
 
-options {
+include "named.common.conf";
-        query-source address 10.53.0.3;
-        notify-source 10.53.0.3;
-        transfer-source 10.53.0.3;
-        port @PORT@;
-        pid-file "named.pid";
-        listen-on { 10.53.0.3; };
-        listen-on-v6 { none; };
-        allow-transfer { any; };
-        recursion no;
-        dnssec-validation no;
-};
-
-key rndc_key {
-        secret "1234abcd8765";
-        algorithm @DEFAULT_HMAC@;
-};
-
-controls {
-        inet 10.53.0.3 port @CONTROLPORT@ allow { any; } keys { rndc_key; };
-};
-
-zone "." {
-        type hint;
-        file "../../_common/root.hint.blackhole";
-};
 
 /* Manual rollover. */
 zone "manual-rollover.kasp" {

bin/tests/system/rollover/ns6/named.common.conf.j2

@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+ *
+ * SPDX-License-Identifier: MPL-2.0
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0.  If a copy of the MPL was not distributed with this
+ * file, you can obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * See the COPYRIGHT file distributed with this work for additional
+ * information regarding copyright ownership.
+ */
+
+options {
+	query-source address 10.53.0.6;
+	notify-source 10.53.0.6;
+	transfer-source 10.53.0.6;
+	port @PORT@;
+	pid-file "named.pid";
+	listen-on { 10.53.0.6; };
+	listen-on-v6 { none; };
+	allow-transfer { any; };
+	recursion no;
+	key-directory ".";
+	dnssec-validation no;
+};
+
+key rndc_key {
+	secret "1234abcd8765";
+	algorithm @DEFAULT_HMAC@;
+};
+
+controls {
+	inet 10.53.0.6 port @CONTROLPORT@ allow { any; } keys { rndc_key; };
+};

bin/tests/system/rollover/ns6/named.conf.j2

@@ -19,33 +19,7 @@
 include "kasp.conf";
 include "@_csk_file@";
 
-options {
+include "named.common.conf";
-	query-source address 10.53.0.6;
-	notify-source 10.53.0.6;
-	transfer-source 10.53.0.6;
-	port @PORT@;
-	pid-file "named.pid";
-	listen-on { 10.53.0.6; };
-	listen-on-v6 { none; };
-	allow-transfer { any; };
-	recursion no;
-	key-directory ".";  // TODO if csk_roll?
-	dnssec-validation no;
-};
-
-key rndc_key {
-	secret "1234abcd8765";
-	algorithm @DEFAULT_HMAC@;
-};
-
-controls {
-	inet 10.53.0.6 port @CONTROLPORT@ allow { any; } keys { rndc_key; };
-};
-
-zone "." {
-	type hint;
-	file "../../_common/root.hint.blackhole";
-};
 
 /* This zone switch from dynamic to inline-signing. */
 zone "dynamic2inline.kasp" {

bin/tests/system/rollover/tests_rollover.py

@@ -21,29 +21,7 @@ import dns.update
 import isctest
 from isctest.kasp import KeyTimingMetadata, Ipub, IpubC, Iret
 
-pytestmark = pytest.mark.extra_artifacts(
+from common import pytestmark
-    [
-        "*.axfr*",
-        "dig.out*",
-        "K*.key*",
-        "K*.private*",
-        "ns*/*.db",
-        "ns*/*.db.infile",
-        "ns*/*.db.jnl",
-        "ns*/*.db.jbk",
-        "ns*/*.db.signed",
-        "ns*/*.db.signed.jnl",
-        "ns*/*.conf",
-        "ns*/dsset-*",
-        "ns*/K*.key",
-        "ns*/K*.private",
-        "ns*/K*.state",
-        "ns*/keygen.out.*",
-        "ns*/settime.out.*",
-        "ns*/signer.out.*",
-        "ns*/zones",
-    ]
-)
 
 
 def test_rollover_manual(servers):